Cannot jetify library with invalid commented out proguard rules [134100420]

Fixed

Bug

Status Update

No update yet.

Description

ca...@gmail.com

created issue #1

May 31, 2019 11:37AM

OS: macOS 10.14.5
Java version "1.8.0_121"
Jetifier version: 1.0.0-beta04

Let there be a Library Foo with the following 'proguard-rules.txt' file:

# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
# Note: the configuration keeps the entry point 'com.raizlabs.android.dbflow.config.FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com.raizlabs.android.dbflow.config.FlowManager$1); }', but not the descriptor class 'com.raizlabs.android.dbflow.config.FlowManager$1'
-keep class com.raizlabs.android.dbflow.config.FlowManager$*

When trying to jetify this library:

./jetifier-standalone -i /Users/someuser/Downloads/foo/foo.aar -o newfoo.aar

The Jetifier fails with the following output:

Exception in thread "main" java.util.regex.PatternSyntaxException: Illegal repetition near index 147
com/raizlabs/android/dbflow/.*
# Note: the configuration keeps the entry point 'com/raizlabs/android/dbflow/config/FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com/raizlabs/android/dbflow/config/FlowManager$1); }'
^
at java.util.regex.Pattern.error(Pattern.java:1955)
at java.util.regex.Pattern.closure(Pattern.java:3157)
at java.util.regex.Pattern.sequence(Pattern.java:2134)
at java.util.regex.Pattern.expr(Pattern.java:1996)
at java.util.regex.Pattern.compile(Pattern.java:1696)
at java.util.regex.Pattern.<init>(Pattern.java:1351)
at java.util.regex.Pattern.compile(Pattern.java:1028)
at com.android.tools.build.jetifier.core.type.TypesMap.matchOldProguardForNewTypes(TypesMap.kt:112)
[...]

If i remove the notes, the new 'proguard-rules.txt' looks like this:

# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
-keep class com.raizlabs.android.dbflow.config.FlowManager$*

And this runs through the jetifier just fine. Please provide a fix for this issue, since i have to patch my dependencies currently in order to make AndroidX work for me.

Comments

do...@traveloka.com <do...@traveloka.com> #2Jul 9, 2019 09:39AM

Same problem here.

In config.ini, I have set:
sdcard.size=500 MiB

In hardware-qemu.ini, I have set:
hw.sdCard = true

pa...@gmail.com <pa...@gmail.com> #3Oct 17, 2019 09:40AM

The issue is that the sdcard is not writable. You can workaround this by running:

adb shell
su
mount -o rw,remount rootfs /
chmod 777 /mnt/sdcard

But those settings are lost once the emulator is closed.

pa...@gmail.com <pa...@gmail.com> #4Oct 17, 2019 09:44AM

I can confirm this an issue I am also having on Android Studio 2.3.

The second comment (

https://code.google.com/p/android/issues/detail?id=240155#c2) of making the SD card writable, does work for me. The camera continues to say "Insert an SD card before using the camera"

ga...@google.com <ga...@google.com> #5Oct 17, 2019 11:41AM

Assigned to pa...@google.com.

API 15 galaxy nexus sd card not detected in storage settings

pa...@google.com <pa...@google.com> #6Oct 25, 2019 03:40PM

Accepted by pa...@google.com.

Is there a solution to this at this point of time?
Having the same issue.
Can't download anything nor take any pictures even the sd card writable workaround does not work for me (API 17).

ap...@google.com <ap...@google.com> #7Oct 31, 2019 06:24PM

For some reason the sdcard is *not* being mounted in the android system (API 16,17 only, 18 onwards WORKS AS EXPECTED) within the emulator.
adb shell
root@android:/ # df
Filesystem Size Used Free Blksize
/dev 757M 68K 757M 4096
/mnt/secure 757M 0K 757M 4096
/mnt/asec 757M 0K 757M 4096
/mnt/obb 757M 0K 757M 4096
/system 532M 349M 183M 4096
/cache 60M 40K 60M 4096
/data 1G 83M 1G 4096

The above is for a API 17 img, same thing happens with both "Studio Managed" sdcard as well as sdcard img file created both via the GUI and mksdcard.
No clues at all in the dmesg, in logcat there is only:

05-12 03:22:54.430 1154-1154/? D/Vold: Volume sdcard state changing -1 (Initializing) -> 0 (No-Media)
05-12 03:22:56.380 1486-1499/system_process D/MountService: got storage path: /mnt/sdcard description: USB storage primary: true removable: false emulated: false mtpReserve: 0 allowMassStorage: false maxFileSize: 0
05-12 03:22:56.380 1486-1499/system_process D/MountService: addVolumeLocked() StorageVolume [mStorageId=0 mPath=/mnt/sdcard mDescriptionId=17040615 mPrimary=true mRemovable=false mEmulated=false mMtpReserveSpace=0 mAllowMassStorage=false mMaxFileSize=0 mOwner=null]
05-12 03:22:56.390 1486-1522/system_process D/MountService: volume state changed for /mnt/sdcard (null -> removed)
05-12 03:22:56.400 1486-1522/system_process I/PackageManager: No secure containers on sdcard
05-12 03:22:58.180 1738-1957/android.process.media W/MediaScanner: Error opening directory '/mnt/sdcard/', skipping: Permission denied.

Just updated to Emulator 26.0.3 and still happening as above.

pa...@google.com <pa...@google.com> #8Nov 26, 2019 02:34PM

Hello, I have the same problem. Anyone find a solution?

pa...@gmail.com <pa...@gmail.com> #9Nov 26, 2019 02:40PM

Unfortunately I had to go back to Android Studio 2.2 as I have to work with a SD card.

hu...@google.com <hu...@google.com> #10Nov 27, 2019 05:34PM

Marked as fixed.

Re: #8 and #9, please refrain from "me too" comments. Each new comment sends out an email to everyone who is subscribed to the defect (and my sincere apologies to everyone for the email that this comment generated!). Please just star the defect to let the devs know that you're interested in it and add a comment only if you have additional debugging/troubleshooting information to add.