Fixed
Status Update
Comments
do...@traveloka.com <do...@traveloka.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019
API lint check for the MinMaxConstant is enabled for androidx
Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25
M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java
https://android-review.googlesource.com/1114511
https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68
Branch: androidx-master-dev
commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019
API lint check for the MinMaxConstant is enabled for androidx
Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25
M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java
pa...@gmail.com <pa...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019
API lint check for the SetterReturnsThis is enabled for androidx
Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
https://android-review.googlesource.com/1123398
https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f
Branch: androidx-master-dev
commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019
API lint check for the SetterReturnsThis is enabled for androidx
Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
pa...@gmail.com <pa...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019
API lint check for the PackageLayering is enabled for androidx
PackageLayering is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
https://android-review.googlesource.com/1126765
https://goto.google.com/android-sha1/8aecbea988804f4f702812f6e7f50bc60359eed1
Branch: androidx-master-dev
commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019
API lint check for the PackageLayering is enabled for androidx
PackageLayering is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ga...@google.com <ga...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7426c6889ba80df99b2589454d0f604e0efd7b78
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:39:30 2019
API lint check for the OverlappingConstants is enabled for androidx
OverlappingConstants is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I312b39963b0b64e06a3bd5933156dc88bff76a1c
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
https://android-review.googlesource.com/1126766
https://goto.google.com/android-sha1/7426c6889ba80df99b2589454d0f604e0efd7b78
Branch: androidx-master-dev
commit 7426c6889ba80df99b2589454d0f604e0efd7b78
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:39:30 2019
API lint check for the OverlappingConstants is enabled for androidx
OverlappingConstants is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I312b39963b0b64e06a3bd5933156dc88bff76a1c
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
pa...@google.com <pa...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9108b6016c27854f67c529a98506f93ff3631a26
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:50:54 2019
API lint check for the IllegalStateException is enabled for androidx
IllegalStateException is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I025bd3b1ade7204b78b6c66b2b205a99ccc701cc
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
https://android-review.googlesource.com/1126767
https://goto.google.com/android-sha1/9108b6016c27854f67c529a98506f93ff3631a26
Branch: androidx-master-dev
commit 9108b6016c27854f67c529a98506f93ff3631a26
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:50:54 2019
API lint check for the IllegalStateException is enabled for androidx
IllegalStateException is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I025bd3b1ade7204b78b6c66b2b205a99ccc701cc
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2f50846ff288d3e18f197cb9243b40c971438e7e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 30 22:36:57 2019
API lint check for the PackageLayering is disabled for androidx
PackageLayering is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ib9cfe9d0a64f9a19b1c28a28762f38da5fe61169
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
https://android-review.googlesource.com/1131079
https://goto.google.com/android-sha1/2f50846ff288d3e18f197cb9243b40c971438e7e
Branch: androidx-master-dev
commit 2f50846ff288d3e18f197cb9243b40c971438e7e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 30 22:36:57 2019
API lint check for the PackageLayering is disabled for androidx
PackageLayering is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ib9cfe9d0a64f9a19b1c28a28762f38da5fe61169
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
pa...@google.com <pa...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 130035de9b227f0bedf6a4380f0a7dec89f41501
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 23 00:05:26 2019
API lint check for the ListenerLast is enabled for androidx
Existing issues are suppressed with updated baseline and the
ListenerLast is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ibc5ff8601a56c7d43793a1f0902d69468963c134
M appcompat/api/api_lint.ignore
M browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M media/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M ui/ui-foundation/api/api_lint.ignore
https://android-review.googlesource.com/1126768
https://goto.google.com/android-sha1/130035de9b227f0bedf6a4380f0a7dec89f41501
Branch: androidx-master-dev
commit 130035de9b227f0bedf6a4380f0a7dec89f41501
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 23 00:05:26 2019
API lint check for the ListenerLast is enabled for androidx
Existing issues are suppressed with updated baseline and the
ListenerLast is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ibc5ff8601a56c7d43793a1f0902d69468963c134
M appcompat/api/api_lint.ignore
M browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M media/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M ui/ui-foundation/api/api_lint.ignore
pa...@gmail.com <pa...@gmail.com> #9
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a509937bc0bf65df2a6e62882c5dcec5015e5e37
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Sep 11 19:12:07 2019
API lint check for the MissingBuild is enabled for androidx
Existing issues are suppressed with updated baseline and the
MissingBuild is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I407b60c1f717b8ad1c8b1c5a17aa2aba68824305
M appcompat/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
A navigation/navigation-runtime/api/api_lint.ignore
M paging/rxjava2/api/api_lint.ignore
A palette/palette/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
https://android-review.googlesource.com/1119191
https://goto.google.com/android-sha1/a509937bc0bf65df2a6e62882c5dcec5015e5e37
Branch: androidx-master-dev
commit a509937bc0bf65df2a6e62882c5dcec5015e5e37
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Sep 11 19:12:07 2019
API lint check for the MissingBuild is enabled for androidx
Existing issues are suppressed with updated baseline and the
MissingBuild is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I407b60c1f717b8ad1c8b1c5a17aa2aba68824305
M appcompat/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
A navigation/navigation-runtime/api/api_lint.ignore
M paging/rxjava2/api/api_lint.ignore
A palette/palette/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
hu...@google.com <hu...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b472cbf0b66dda85bc2a176136f5a01c905be944
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Oct 07 22:43:56 2019
API lint check for the IntentBuilderName is commented
The IntentBuilderName is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I2e6e5cd63f0b126b1c9388885abfc00c8289c2c7
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
https://android-review.googlesource.com/1115101
https://goto.google.com/android-sha1/b472cbf0b66dda85bc2a176136f5a01c905be944
Branch: androidx-master-dev
commit b472cbf0b66dda85bc2a176136f5a01c905be944
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Oct 07 22:43:56 2019
API lint check for the IntentBuilderName is commented
The IntentBuilderName is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I2e6e5cd63f0b126b1c9388885abfc00c8289c2c7
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
Description
Java version "1.8.0_121"
Jetifier version: 1.0.0-beta04
Let there be a Library Foo with the following 'proguard-rules.txt' file:
# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
# Note: the configuration keeps the entry point 'com.raizlabs.android.dbflow.config.FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com.raizlabs.android.dbflow.config.FlowManager$1); }', but not the descriptor class 'com.raizlabs.android.dbflow.config.FlowManager$1'
-keep class com.raizlabs.android.dbflow.config.FlowManager$*
When trying to jetify this library:
./jetifier-standalone -i /Users/someuser/Downloads/foo/foo.aar -o newfoo.aar
The Jetifier fails with the following output:
Exception in thread "main" java.util.regex.PatternSyntaxException: Illegal repetition near index 147
com/raizlabs/android/dbflow/.*
# Note: the configuration keeps the entry point 'com/raizlabs/android/dbflow/config/FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com/raizlabs/android/dbflow/config/FlowManager$1); }'
^
at java.util.regex.Pattern.error(Pattern.java:1955)
at java.util.regex.Pattern.closure(Pattern.java:3157)
at java.util.regex.Pattern.sequence(Pattern.java:2134)
at java.util.regex.Pattern.expr(Pattern.java:1996)
at java.util.regex.Pattern.compile(Pattern.java:1696)
at java.util.regex.Pattern.<init>(Pattern.java:1351)
at java.util.regex.Pattern.compile(Pattern.java:1028)
at com.android.tools.build.jetifier.core.type.TypesMap.matchOldProguardForNewTypes(TypesMap.kt:112)
[...]
If i remove the notes, the new 'proguard-rules.txt' looks like this:
# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
-keep class com.raizlabs.android.dbflow.config.FlowManager$*
And this runs through the jetifier just fine. Please provide a fix for this issue, since i have to patch my dependencies currently in order to make AndroidX work for me.