Cannot jetify library with invalid commented out proguard rules [134100420]

Fixed

Bug

Status Update

No update yet.

Description

ca...@gmail.com

created issue #1

May 31, 2019 11:37AM

OS: macOS 10.14.5
Java version "1.8.0_121"
Jetifier version: 1.0.0-beta04

Let there be a Library Foo with the following 'proguard-rules.txt' file:

# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
# Note: the configuration keeps the entry point 'com.raizlabs.android.dbflow.config.FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com.raizlabs.android.dbflow.config.FlowManager$1); }', but not the descriptor class 'com.raizlabs.android.dbflow.config.FlowManager$1'
-keep class com.raizlabs.android.dbflow.config.FlowManager$*

When trying to jetify this library:

./jetifier-standalone -i /Users/someuser/Downloads/foo/foo.aar -o newfoo.aar

The Jetifier fails with the following output:

Exception in thread "main" java.util.regex.PatternSyntaxException: Illegal repetition near index 147
com/raizlabs/android/dbflow/.*
# Note: the configuration keeps the entry point 'com/raizlabs/android/dbflow/config/FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com/raizlabs/android/dbflow/config/FlowManager$1); }'
^
at java.util.regex.Pattern.error(Pattern.java:1955)
at java.util.regex.Pattern.closure(Pattern.java:3157)
at java.util.regex.Pattern.sequence(Pattern.java:2134)
at java.util.regex.Pattern.expr(Pattern.java:1996)
at java.util.regex.Pattern.compile(Pattern.java:1696)
at java.util.regex.Pattern.<init>(Pattern.java:1351)
at java.util.regex.Pattern.compile(Pattern.java:1028)
at com.android.tools.build.jetifier.core.type.TypesMap.matchOldProguardForNewTypes(TypesMap.kt:112)
[...]

If i remove the notes, the new 'proguard-rules.txt' looks like this:

# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
-keep class com.raizlabs.android.dbflow.config.FlowManager$*

And this runs through the jetifier just fine. Please provide a fix for this issue, since i have to patch my dependencies currently in order to make AndroidX work for me.

Comments

do...@traveloka.com <do...@traveloka.com> #2Jul 9, 2019 09:39AM

Wow, it seems like a very important bug to fix.

Doing some investigations...

It works fine with CoreTextField as well as BaseTextField.

pa...@gmail.com <pa...@gmail.com> #3Oct 17, 2019 09:40AM

Seems to be a duplicate of b/163834907

pa...@gmail.com <pa...@gmail.com> #4Oct 17, 2019 09:44AM

It works fine with Material TextFields (both filled and outline) if you use TextFieldValue based overloads.

It doesn't work when you use String based overloads however (both Outline and Filled). I believe this is related to the one-frame lag as we host TextFieldValue internally and proxy only string.

ga...@google.com <ga...@google.com> #5Oct 17, 2019 11:41AM

Assigned to pa...@google.com.

Chatted with Anastasia.

We have this code

// "value: String" comes as a param in TextField
TextFieldImpl(
        type = TextFieldType.Outlined,
        value = textFieldValue,
        onValueChange = {
            selection = it.selection
            composition = it.composition
            if (value != it.text) {
                onValueChange(it.text)
            }
        },

and this value is always "" for me, as it's captured my lambda when lambda was created and this lambda is saved and reused by CoreTextField.

Anyway, two things we can do:

Remove this if and invoke onValueChange everytime, even on the selection change (which we don't care about). This will allow us to workaround quickly and not to let it slip through.
Find and implement the proper fix in CoreTextField

Let me know what you think

pa...@google.com <pa...@google.com> #6Oct 25, 2019 03:40PM

Accepted by pa...@google.com.

Updated the details here b/163834907.

ap...@google.com <ap...@google.com> #7Oct 31, 2019 06:24PM

Just a note that this issue affects String overrides of both material text fields as well as any custom String override text fields that developer might create on top of CoreTextField/BaseTextField.

pa...@google.com <pa...@google.com> #8Nov 26, 2019 02:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1717097cfa889c564450626af6d5dcc405581d79
Author: Anastasia Soboleva <soboleva@google.com>
Date: Mon Aug 24 16:38:59 2020

Fix lambda value being captured for string override text fields

Fixes: 163834907
Fixes: 163808219
Fixes: 165956313
Test: new test in TextFieldTest#stringOverrideTextField_canDeleteLastSymbol
Test: foundation and material tests passed
Change-Id: I9932a2bddc3859a2a35a54e0b6d7cb525853d3ac

M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldTest.kt

https://android-review.googlesource.com/1408268

pa...@gmail.com <pa...@gmail.com> #9Nov 26, 2019 02:40PM

Which release is this fix going to be a part of? Also, what's the best way to know which version a change will be a part of in general?

hu...@google.com <hu...@google.com> #10Nov 27, 2019 05:34PM

Marked as fixed.

This fix will be available in the upcoming release.

As for the second question, I'm not sure I've got a good answer for that one. I'd say normally if it's marked as fixed, it'll be available within two next releases.