Cannot jetify library with invalid commented out proguard rules [134100420]

Fixed

Bug

Status Update

No update yet.

Description

ca...@gmail.com

created issue #1

May 31, 2019 11:37AM

OS: macOS 10.14.5
Java version "1.8.0_121"
Jetifier version: 1.0.0-beta04

Let there be a Library Foo with the following 'proguard-rules.txt' file:

# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
# Note: the configuration keeps the entry point 'com.raizlabs.android.dbflow.config.FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com.raizlabs.android.dbflow.config.FlowManager$1); }', but not the descriptor class 'com.raizlabs.android.dbflow.config.FlowManager$1'
-keep class com.raizlabs.android.dbflow.config.FlowManager$*

When trying to jetify this library:

./jetifier-standalone -i /Users/someuser/Downloads/foo/foo.aar -o newfoo.aar

The Jetifier fails with the following output:

Exception in thread "main" java.util.regex.PatternSyntaxException: Illegal repetition near index 147
com/raizlabs/android/dbflow/.*
# Note: the configuration keeps the entry point 'com/raizlabs/android/dbflow/config/FlowManager$GlobalDatabaseHolder { FlowManager$GlobalDatabaseHolder(com/raizlabs/android/dbflow/config/FlowManager$1); }'
^
at java.util.regex.Pattern.error(Pattern.java:1955)
at java.util.regex.Pattern.closure(Pattern.java:3157)
at java.util.regex.Pattern.sequence(Pattern.java:2134)
at java.util.regex.Pattern.expr(Pattern.java:1996)
at java.util.regex.Pattern.compile(Pattern.java:1696)
at java.util.regex.Pattern.<init>(Pattern.java:1351)
at java.util.regex.Pattern.compile(Pattern.java:1028)
at com.android.tools.build.jetifier.core.type.TypesMap.matchOldProguardForNewTypes(TypesMap.kt:112)
[...]

If i remove the notes, the new 'proguard-rules.txt' looks like this:

# DBFlow
-keep class * extends com.raizlabs.android.dbflow.config.DatabaseHolder { *; }
-dontwarn com.raizlabs.android.dbflow.**
-keep class com.raizlabs.android.dbflow.config.FlowManager$*

And this runs through the jetifier just fine. Please provide a fix for this issue, since i have to patch my dependencies currently in order to make AndroidX work for me.

Comments

do...@traveloka.com <do...@traveloka.com> #2Jul 9, 2019 09:39AM

Thank you for the report. We will try to fix this soon. In the meantime, could you please start the emulator from the console (see the commands below), open the camera app to crash it and attach the output, it might help to figure out what the problem is:

cd /Users/YOUR_USERNAME/Library/Android/sdk/emulator
./emulator -list-avds
./emulator -verbose -avd YOUR_AVD_FROM_PREVIOUS_STEP

if there is a crash report to send, please send it and attach the report id.

pa...@gmail.com <pa...@gmail.com> #3Oct 17, 2019 09:40AM

We got a crash report (thanks JP): 872e3b20bc34905b. It says EXC_BAD_INSTRUCTION / 0x00000001 and the console also says "Illegal hardware instruction". I suspect the new MacOS brought a new hypervizor which causes this behavior. Haitao, could you please take a look?

pa...@gmail.com <pa...@gmail.com> #4Oct 17, 2019 09:44AM

We have quite some crashes like this:

product_name="AndroidEmulator" AND crash.Reason="EXC_BAD_INSTRUCTION / 0x00000001" AND cpu.Architecture="arm64"

ga...@google.com <ga...@google.com> #5Oct 17, 2019 11:41AM

Assigned to pa...@google.com.

The most of crashes happen here:

vVertical_Scale_ARGB_8888_Accelerate
vImageVerticalShear_ARGB8888
vImageVerticalShear_ARGB8888
vImageScale_ARGB8888

vRotateClockwise270Degree_ARGB8888_Accelerate2
vRotate_90_ARGB_8888_270Degree_Accelerate2

pa...@google.com <pa...@google.com> #6Oct 25, 2019 03:40PM

Accepted by pa...@google.com.

I suspect EXC_BAD_INSTRUCTION happens in vImageRotate90_ARGB8888 and vImageScale_ARGB8888 which are used by webcam on MacOS.

ap...@google.com <ap...@google.com> #7Oct 31, 2019 06:24PM

With complete honesty, I have to say that I’m extremely disappointed by the handling of this issue by google and by the fact that it came out in the first place. I need to use android studio for work purposes and I am forced to switch to a different machine. Mac OS Sonoma has been in beta testing for months and google has had plenty of time to ensure the application would be properly running. I expect this issue to have the maximum priority and to be solved very soon.

pa...@google.com <pa...@google.com> #8Nov 26, 2019 02:34PM

Hi rforzani22, I am sorry for this experience. This bug is my top priority. We expect a fix to be merged within a week. You should be able to download a build directly from our build server (https://ci.android.com/builds/branches/aosp-emu-master-dev/grid) once the fix is merged. The release process will take some additional time.

pa...@gmail.com <pa...@gmail.com> #9Nov 26, 2019 02:40PM

Thanks for making it a top priority, looking forward for the fix, good luck!

hu...@google.com <hu...@google.com> #10Nov 27, 2019 05:34PM

Marked as fixed.

We confirmed #comment6. I removed vImageRotate90... and vImageScale... and use what I could find (which is not as efficient as vImage... ones, we will try to figure out why these functions crash), it does not handle all aspect ratios and resolutions so far (it might crash for different reasons, I will be working on this tomorrow). If anyone wants to try my local build, I can share it.