[AGP 3.6.0-beta01] SecurityException: SHA1 digest error for BouncyCastleProvider when using Robolectric [142580430]

Fixed

Bug

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Oct 12, 2019 11:43PM

All of my Robolectric tests are now failing due to a SecurityException. These previously worked fine with AGP 3.6.0-alpha12.

Log:
java.lang.SecurityException: SHA1 digest error for org/bouncycastle/jce/provider/BouncyCastleProvider.class
at sun.security.util.ManifestEntryVerifier.verify(ManifestEntryVerifier.java:223)
at java.util.jar.JarVerifier.processEntry(JarVerifier.java:243)
at java.util.jar.JarVerifier.update(JarVerifier.java:230)
at java.util.jar.JarVerifier$VerifierStream.read(JarVerifier.java:484)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at java.io.FilterInputStream.read(FilterInputStream.java:107)
at org.robolectric.util.Util.copy(Util.java:46)
at org.robolectric.util.Util.readBytes(Util.java:63)
at org.robolectric.internal.bytecode.SandboxClassLoader.getByteCode(SandboxClassLoader.java:167)
at org.robolectric.internal.bytecode.SandboxClassLoader.maybeInstrumentClass(SandboxClassLoader.java:119)
at org.robolectric.internal.bytecode.SandboxClassLoader.lambda$findClass$0(SandboxClassLoader.java:112)
at org.robolectric.util.PerfStatsCollector.measure(PerfStatsCollector.java:53)
at org.robolectric.internal.bytecode.SandboxClassLoader.findClass(SandboxClassLoader.java:111)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.getDeclaredConstructors0(Native Method)
at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
at java.lang.Class.getConstructors(Class.java:1651)
at org.robolectric.util.inject.Injector.findConstructor(Injector.java:249)
at org.robolectric.util.inject.Injector.inject(Injector.java:232)
at org.robolectric.util.inject.Injector.lambda$new$0(Injector.java:115)
at org.robolectric.util.inject.Injector$MemoizingProvider.get(Injector.java:485)
at org.robolectric.util.inject.Injector.getInstanceInternal(Injector.java:213)
at org.robolectric.util.inject.Injector.getInstance(Injector.java:197)
at org.robolectric.util.inject.Injector.getInstance(Injector.java:191)
at org.robolectric.internal.AndroidSandbox.lambda$new$0(AndroidSandbox.java:51)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

Repro:
git clone -b cb/agb-3.6.0-beta01

https://github.com/chrisbanes/tivi.git
cd tivi
./gradlew testDebug

Comments

ga...@google.com <ga...@google.com> Oct 14, 2019 10:51AM

Assigned to ga...@google.com.

ga...@google.com <ga...@google.com> #2Oct 14, 2019 02:39PM

Here is a leak example for a real-life use case. Again, the MediaSession was released, but the leak sticks around:

* GC ROOT android.support.v4.media.session.MediaSessionCompat$MediaSessionImplApi21$ExtraSession.this$0
* references android.support.v4.media.session.MediaSessionCompat$MediaSessionImplApi21.mSessionObj
* references android.media.session.MediaSession.mController
* references android.media.session.MediaController.mContext
* leaks com.bubenheimer.rucksack.d.q instance

Message last modified on Oct 14, 2019 02:52PM

pa...@google.com <pa...@google.com> Oct 14, 2019 02:54PM

Reassigned to pa...@google.com.

ga...@google.com <ga...@google.com> #3Oct 14, 2019 03:12PM

Thank you for your feedback. We assure you that we are doing our best to address the issue reported, however our product team has shifted work priority that doesn't include this issue. For now, we will be closing the issue as won't fix obsolete. If this issue currently still exists, we request that you log a new issue along with latest bug report here

https://goo.gl/TbMiIO.

ch...@gmail.com <ch...@gmail.com> #4Oct 14, 2019 08:28PM

deleted

pa...@google.com <pa...@google.com> #5Oct 25, 2019 05:37PM

Accepted by pa...@google.com.

Can you please confirm whether this is still reproducible on API 33?

And if you happen to have access, also on the Developer Preview of API 34?

mi...@aexp.com <mi...@aexp.com> #6Nov 25, 2019 11:18PM

deleted

pa...@google.com <pa...@google.com> #7Nov 26, 2019 02:33PM

Final thing, is this a dup of https://issuetracker.google.com/220795151?

hu...@google.com <hu...@google.com> #8Nov 27, 2019 05:29PM

Marked as fixed.

Thanks, I believe it's a dup at this point.

The other issue was marked as fixed a year ago, but is still as reproducible as ever, I had just tested it on API 33 and UpsideDownCake DP2.