[AGP 3.6.0-beta01] SecurityException: SHA1 digest error for BouncyCastleProvider when using Robolectric [142580430]

Fixed

Bug

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Oct 12, 2019 11:43PM

All of my Robolectric tests are now failing due to a SecurityException. These previously worked fine with AGP 3.6.0-alpha12.

Log:
java.lang.SecurityException: SHA1 digest error for org/bouncycastle/jce/provider/BouncyCastleProvider.class
at sun.security.util.ManifestEntryVerifier.verify(ManifestEntryVerifier.java:223)
at java.util.jar.JarVerifier.processEntry(JarVerifier.java:243)
at java.util.jar.JarVerifier.update(JarVerifier.java:230)
at java.util.jar.JarVerifier$VerifierStream.read(JarVerifier.java:484)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at java.io.FilterInputStream.read(FilterInputStream.java:107)
at org.robolectric.util.Util.copy(Util.java:46)
at org.robolectric.util.Util.readBytes(Util.java:63)
at org.robolectric.internal.bytecode.SandboxClassLoader.getByteCode(SandboxClassLoader.java:167)
at org.robolectric.internal.bytecode.SandboxClassLoader.maybeInstrumentClass(SandboxClassLoader.java:119)
at org.robolectric.internal.bytecode.SandboxClassLoader.lambda$findClass$0(SandboxClassLoader.java:112)
at org.robolectric.util.PerfStatsCollector.measure(PerfStatsCollector.java:53)
at org.robolectric.internal.bytecode.SandboxClassLoader.findClass(SandboxClassLoader.java:111)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.getDeclaredConstructors0(Native Method)
at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
at java.lang.Class.getConstructors(Class.java:1651)
at org.robolectric.util.inject.Injector.findConstructor(Injector.java:249)
at org.robolectric.util.inject.Injector.inject(Injector.java:232)
at org.robolectric.util.inject.Injector.lambda$new$0(Injector.java:115)
at org.robolectric.util.inject.Injector$MemoizingProvider.get(Injector.java:485)
at org.robolectric.util.inject.Injector.getInstanceInternal(Injector.java:213)
at org.robolectric.util.inject.Injector.getInstance(Injector.java:197)
at org.robolectric.util.inject.Injector.getInstance(Injector.java:191)
at org.robolectric.internal.AndroidSandbox.lambda$new$0(AndroidSandbox.java:51)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

Repro:
git clone -b cb/agb-3.6.0-beta01

https://github.com/chrisbanes/tivi.git
cd tivi
./gradlew testDebug

Comments

ga...@google.com <ga...@google.com> Oct 14, 2019 10:51AM

Assigned to ga...@google.com.

ga...@google.com <ga...@google.com> #2Oct 14, 2019 02:39PM

Bringing setMaxSchedulerLimit to say 49 doesn't help. Same error.

Message last modified on Oct 14, 2019 02:52PM

pa...@google.com <pa...@google.com> Oct 14, 2019 02:54PM

Reassigned to pa...@google.com.

ga...@google.com <ga...@google.com> #3Oct 14, 2019 03:12PM

If you are using work-firebase then you should not be using JobScheduler directly. Can you please send us the full bug report so we can investigate ?

ch...@gmail.com <ch...@gmail.com> #4Oct 14, 2019 08:28PM

java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
at android.os.Parcel.readException(Parcel.java:1692)
at android.os.Parcel.readException(Parcel.java:1637)
at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(SystemJobScheduler.java:126)
at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(SystemJobScheduler.java:95)
at androidx.work.impl.Schedulers.scheduleInternal(Schedulers.java:104)
at androidx.work.impl.Schedulers.schedule(Schedulers.java:73)
at androidx.work.impl.WorkerWrapper.setSucceededAndNotify(WorkerWrapper.java:393)
at androidx.work.impl.WorkerWrapper.handleResult(WorkerWrapper.java:255)
at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:181)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)

pa...@google.com <pa...@google.com> #5Oct 25, 2019 05:37PM

Accepted by pa...@google.com.

What do you mean I shouldn't use JobScheduler directly? Isn't work-firebase is just for <21 devices, otherwise JobScheduler always used?

mi...@aexp.com <mi...@aexp.com> #6Nov 25, 2019 11:18PM

I think i was confused by your previous comment. You are right, we only use work-firebase for API < 23.
JobScheduler is used for API >= 23.

This issue should have been resolved in `alpha03` and `alpha04` (we addressed different parts of the problem). If you can reproduce this on a device, then can you do:

1. adb shell dumpsys jobscheduler for your app.
2. Reboot your device.
3. After the reboot, can you re-run adb shell dumpsys jobscheduler ?

I want to check if you see any differences in the jobs created before and after the reboot.

Thanks for your patience.

pa...@google.com <pa...@google.com> #7Nov 26, 2019 02:33PM

Actually for step 2, the easier thing to do is to force stop your app. You don't need to fo a full reboot.

hu...@google.com <hu...@google.com> #8Nov 27, 2019 05:29PM

Marked as fixed.

I don't have to to rummage through traces. Here's code snippet that sends app into a crash loop.

https://pastebin.com/NcTAnwjZ