Crash : IllegalArgumentException Can not get supported output size under supported maximum for the format: 34 [150506192]

Fixed

Bug

Status Update

No update yet.

Description

vi...@gmail.com

created issue #1

Feb 29, 2020 03:18AM

CAMERAX VERSION (ex - 1.0.0-alpha07)

1.0.0-alpha07

DEVICE NAME: (Nexus 5X, Samsung S6, etc)

name : FUJITSU arrowsM04
Android OS version : 7.1.1

name: FUJITSU F-04J
Android OS version : 6.0.1

name: FUJITSU F-05J
Android OS version : 7.1.1

DESCRIPTION:

We receive following crash report from our app user.

Fatal Exception: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at a.c.a.b.k0.a + 98(SupportedSurfaceCombination.java:98)
at a.c.a.b.k0.a + 30(SupportedSurfaceCombination.java:30)
at a.c.a.b.t.a + 22(Camera2DeviceSurfaceManager.java:22)
at androidx.camera.core.k1.a + 98(CameraX.java:98)
at androidx.camera.core.k1.a + 22(CameraX.java:22)
at a.c.b.c.a + 6(ProcessCameraProvider.java:6)
at <out app package name>.CameraFragment.a + 33(CameraFragment.kt:33)
at <out app package name>.CameraFragment.a + 1(CameraFragment.kt:1)
at <out app package name>.CameraFragment$m.run + 1(CameraFragment.kt:1)
at android.os.Handler.handleCallback + 751(Handler.java:751)
at android.os.Handler.dispatchMessage + 95(Handler.java:95)
at android.os.Looper.loop + 154(Looper.java:154)
at android.app.ActivityThread.main + 6262(ActivityThread.java:6262)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run + 890(ZygoteInit.java:890)
at com.android.internal.os.ZygoteInit.main + 780(ZygoteInit.java:780)

REPRODUCIBILITY: (5 of out 5, 1 out of 100, etc)

We receive this crash report from only three devices. And these devices's manufacturer is FUJITSU.

ADDITIONAL INFORMATION:

CODE FRAGMENTS (this will help us troubleshoot your issues):

Our app bind usecases by following code.

private fun bindCameraUseCases(processCameraProvider: ProcessCameraProvider) {
preview = Preview.Builder().apply {
setTargetAspectRatio(AspectRatio.RATIO_4_3)
}.build().apply {
previewSurfaceProvider = binding.previewViewCamera.previewSurfaceProvider
}

imageCapture = ImageCapture.Builder().apply {
setCaptureMode(ImageCapture.CaptureMode.MINIMIZE_LATENCY)
setTargetAspectRatio(AspectRatio.RATIO_4_3)
setFlashMode(FlashMode.OFF)
}.build()

val cameraSelector = CameraSelector.Builder().requireLensFacing(LensFacing.BACK).build()
processCameraProvider.bindToLifecycle(viewLifecycleOwner, cameraSelector, preview, imageCapture)
}

Comments

er...@google.com <er...@google.com> #2Mar 2, 2020 11:39PM

Reassigned to vi...@gmail.com.

That seems quite bad :/ weird.
We have fairly large test projects which do not take anywhere close to it, maybe your code is triggering some bad code path.

Can you provide a sample or share your project with us? It is impossible to do something here unless we have a reproduction case. Might also possibly be related to your machine configuration.

er...@google.com <er...@google.com> #3Mar 4, 2020 06:16PM

Reassigned to ca...@google.com.

Let me see what I can do on the reproduction as I am anyways blocked on this. I will try to extract out the DB module in a new project and see if it reproduces the issue.

ch...@google.com <ch...@google.com> Mar 5, 2020 02:41AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #4Mar 5, 2020 02:59AM

Attaching the sample project. When I run the project through the android studio or even command line, I see the described issue.
Try uncommenting room-compiler dependency from app's build.gradle, it does not have the issue because room compiler is not at work.

ch...@google.com <ch...@google.com> Mar 9, 2020 11:09AM

Accepted by ch...@google.com.

vi...@gmail.com <vi...@gmail.com> #5Mar 11, 2020 07:15AM

Did you get a chance to look at it?

ch...@google.com <ch...@google.com> #6Mar 18, 2020 07:49AM

Marked as fixed.

FYI. I see that if I comment out applying google-services plugin (at the end of the app's build.gradle file), that fixes the issue too. Hence, you may need to apply a google-services plugin with a json file to reproduce the issue.

Not sure what is going on but certainly, somethings are not playing well together.

vi...@gmail.com <vi...@gmail.com> #7Jul 5, 2020 07:23AM

Above comment is NOT TRUE, it seems I did not do a code change after commenting out apply google-services plugin. That's why the build passed.

ch...@google.com <ch...@google.com> #8Jul 6, 2020 01:41AM

Thanks for the sample app. I haven't gotten to the bottom of the issue yet but I wanted to give you an update and it does seem indeed that Room is taking a very long time to parse and understand your queries via the ANTLR generated parser that Room uses. I'm not sure what is so special about your queries that is causing this, but I'll comment back with an update once I find out. Sadly for now I don't have a recommendation on a workaround.

vi...@gmail.com <vi...@gmail.com> #9Jul 8, 2020 07:46AM

Alright, I've drill down the problem to being the various "OR <col_name> LIKE '%' : text '%'" in your queries. Specifically they cause the SQLiteParser in Room to go down a path with poor performance as described in

https://github.com/antlr/antlr4/issues/1398. A fix for this involves updating Room's ANTRL runtime library and generated parser code with the latest version. This update will likely be available in Room 2.1.0-alpha02.

vi...@gmail.com <vi...@gmail.com> #10Oct 13, 2020 02:44AM

Thanks for the update. Is 2.1.0-alpha02 around the corner?

vi...@gmail.com <vi...@gmail.com> #11Jan 3, 2021 10:57AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8e46b9ca1f55b040a18dd86833880b5106d103b2
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Oct 10 19:17:50 2018

Update Room's ANTLR Parser to 4.7.1

Updating to the latest ANTLR version fixes the performance issue
described in

https://github.com/antlr/antlr4/issues/1398 which affects
Room's SQL Parser since it contains left-recursive rules. Specifically
SQLite.g4 has multiple recursions to describe an expression as defined
in

https://www.sqlite.org/lang_expr.html, meaning if a user has certain
queries that causes the parser to use the adaptivePredict algorithm
then the build time increases significantly due to Room's query
parsing.

Also bumped Room's version to 2.1.0-alpha02

Bug: 117401230
Test: ./gradlew room:integration-tests:testapp:cC
Change-Id: I4d0799a11ccee816ab209cbf74e7dcf2b2ce1a18

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/UserDao.java

https://android-review.googlesource.com/786077

https://goto.google.com/android-sha1/8e46b9ca1f55b040a18dd86833880b5106d103b2

ch...@google.com <ch...@google.com> #12Jan 5, 2021 02:40AM

No concrete date on 2.1.0-alpha02, I want to get a few more bugs in before making the next alpha release. So maybe by the end of the month.

vi...@gmail.com <vi...@gmail.com> #13Jan 8, 2021 07:48AM

Thanks.

On Tue, Oct 16, 2018, 4:52 AM <buganizer-system@google.com> wrote:

- Show quoted text -

--

- Ankit

ch...@google.com <ch...@google.com> #14Jan 8, 2021 10:09AM

Status: In Progress (Accepted) (reopened)

I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.

ap...@google.com <ap...@google.com> #15Jan 12, 2021 02:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021

Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.

Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.

Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."

Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec

M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java

https://android-review.googlesource.com/1545624

ch...@google.com <ch...@google.com> #16Jan 12, 2021 02:49AM