Status Update
No update yet.
Comments
er...@google.com
adding
```#-keep class android.support.v4.** { *; }
#-keep interface android.support.v4.** { *; }```
on consumer proguard that not using androidx, enable jetifier on your project, the proguard.txt from that library will adding new rules:
```-keep class androidx.** { *; }
-keep interface androidx.** { *; }```
er...@google.com
We have this coming from a consumer proguard file in an AAR:
```proguard
# OkHttp platform used only on JVM and when Conscrypt dependency is available.
# OkHttp's ProGuard rules only suppress the main ConscryptPlatform class, let's also suppress its inner classes
-dontwarn okhttp3.internal.platform.ConscryptPlatform$*
# R8 Shrinker
# AGPBI: {"kind":"warning","text":"Missing class: org.conscrypt.ConscryptHostnameVerifier","sources":[{}],"tool":"D8"}
-dontwarn org.conscrypt.ConscryptHostnameVerifier
```
The exception is:
```
Caused by: java.util.regex.PatternSyntaxException: Illegal repetition near index 72
okhttp3/internal/platform/ConscryptPlatform$[^/]*
# R8 Shrinker
# AGPBI: {"kind":"warning"
^
```
If we account for newlines as characters and use a fixed width font, the ^ pointer is pointing at {"kind" where " is not a number as expected by the {N} repetition operator.
I hacked the AAR file in Gradle caches:
Tried adding an empty line between the rule and the comment, but didn't help, but
```diff
-# AGPBI: {"kind":"warning","text":"Missing class: ...
+# AGPBI: \{"kind":"warning","text":"Missing class: ...
```
works.
Since we can't change the Gradle caches on all machines this is a blocker for using Jetifier.
ch...@google.com
ch...@google.com
ch...@google.com
vi...@gmail.com
ch...@google.com
Pending cl with fix is here:
The fix will be available once we release new jetifier which should be in few weeks at most. Sorry for troubles.
vi...@gmail.com
Branch: androidx-master-dev
commit 0ca83fae309187d476d8e5baa59d7e0f33c6f8d8
Author: Filip Pavlis <pavlis@google.com>
Date: Fri Oct 25 16:34:14 2019
Fix proguard regular expression.
The matcher in dontwarn was too hungry and was also matching new
lines and comments.
Also make sure we don' match comments in ProGuardClassSpecParser.
Test: Added
Bug:
Change-Id: I77cf40dd880b5bee9a30dad82c82dc1fa5a71aa9
M jetifier/jetifier/processor/src/main/kotlin/com/android/tools/build/jetifier/processor/transform/proguard/ProGuardClassFilterParser.kt
M jetifier/jetifier/processor/src/main/kotlin/com/android/tools/build/jetifier/processor/transform/proguard/ProGuardClassSpecParser.kt
M jetifier/jetifier/processor/src/main/kotlin/com/android/tools/build/jetifier/processor/transform/proguard/patterns/PatternHelper.kt
M jetifier/jetifier/processor/src/test/kotlin/com/android/tools/build/jetifier/processor/transform/proguard/ClassFilterTest.kt
M jetifier/jetifier/processor/src/test/kotlin/com/android/tools/build/jetifier/processor/transform/proguard/ProguardSamplesTest.kt
ch...@google.com
To avoid waiting for new Android Studio you can workaround this in the meantime by forcing usage of a new version of jetifier in gradle:
buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:x.y.z'
classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta08' // <- Add this
}
}
vi...@gmail.com
vi...@gmail.com
vi...@gmail.com
ch...@google.com
I tried to find the device specs and both 720x1280 size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480 but the device only supports a 480x480 size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04 release. Before 480x480 size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480 size threshold was removed and then the 480x480 size would be kept and selected to use.
It looks like 1.0.0-beta04 release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04 release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04 version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01 version for your application. Thanks.
vi...@gmail.com
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10 and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J or Fujitsu arrows M04 so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
ch...@google.com
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
ap...@google.com
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
Description
1.0.0-alpha07
DEVICE NAME: (Nexus 5X, Samsung S6, etc)
name : FUJITSU arrowsM04
Android OS version : 7.1.1
name: FUJITSU F-04J
Android OS version : 6.0.1
name: FUJITSU F-05J
Android OS version : 7.1.1
DESCRIPTION:
We receive following crash report from our app user.
Fatal Exception: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at a.c.a.b.k0.a + 98(SupportedSurfaceCombination.java:98)
at a.c.a.b.k0.a + 30(SupportedSurfaceCombination.java:30)
at a.c.a.b.t.a + 22(Camera2DeviceSurfaceManager.java:22)
at androidx.camera.core.k1.a + 98(CameraX.java:98)
at androidx.camera.core.k1.a + 22(CameraX.java:22)
at a.c.b.c.a + 6(ProcessCameraProvider.java:6)
at <out app package name>.CameraFragment.a + 33(CameraFragment.kt:33)
at <out app package name>.CameraFragment.a + 1(CameraFragment.kt:1)
at <out app package name>.CameraFragment$m.run + 1(CameraFragment.kt:1)
at android.os.Handler.handleCallback + 751(Handler.java:751)
at android.os.Handler.dispatchMessage + 95(Handler.java:95)
at android.os.Looper.loop + 154(Looper.java:154)
at android.app.ActivityThread.main + 6262(ActivityThread.java:6262)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run + 890(ZygoteInit.java:890)
at com.android.internal.os.ZygoteInit.main + 780(ZygoteInit.java:780)
REPRODUCIBILITY: (5 of out 5, 1 out of 100, etc)
We receive this crash report from only three devices. And these devices's manufacturer is FUJITSU.
ADDITIONAL INFORMATION:
CODE FRAGMENTS (this will help us troubleshoot your issues):
Our app bind usecases by following code.
private fun bindCameraUseCases(processCameraProvider: ProcessCameraProvider) {
preview = Preview.Builder().apply {
setTargetAspectRatio(AspectRatio.RATIO_4_3)
}.build().apply {
previewSurfaceProvider = binding.previewViewCamera.previewSurfaceProvider
}
imageCapture = ImageCapture.Builder().apply {
setCaptureMode(ImageCapture.CaptureMode.MINIMIZE_LATENCY)
setTargetAspectRatio(AspectRatio.RATIO_4_3)
setFlashMode(FlashMode.OFF)
}.build()
val cameraSelector = CameraSelector.Builder().requireLensFacing(LensFacing.BACK).build()
processCameraProvider.bindToLifecycle(viewLifecycleOwner, cameraSelector, preview, imageCapture)
}