Fixed
Status Update
No update yet.
Comments
ap...@google.com
We will consider this as a feature request.
But, for the moment, in case you have not already done so, you can copy your ninja.exe to the same directory as your downloaded cmake.exe, and that should work around the issue.
ap...@google.com
jomof@ Do you think we should swap the order of 2 and 3 in
ap...@google.com
That seems reasonable
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 9070a18e72f867e987a87f819f7db8b017e767f1
Author: Simon Glass <sjg@chromium.org>
Date: Wed Mar 10 13:56:01 2021
zephyr: Add a step-by-step guide
Add a guide to make it easier for people to add a new Kconfig.
BUG=b:181253613
BRANCH=none
TEST=none
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I2714c02f3541a07c18cfa1d4a40e6b75fb2aa4fa
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2749762
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
M docs/zephyr_shim.md
https://chromium-review.googlesource.com/2749762
Branch: main
commit 9070a18e72f867e987a87f819f7db8b017e767f1
Author: Simon Glass <sjg@chromium.org>
Date: Wed Mar 10 13:56:01 2021
zephyr: Add a step-by-step guide
Add a guide to make it easier for people to add a new Kconfig.
BUG=b:181253613
BRANCH=none
TEST=none
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I2714c02f3541a07c18cfa1d4a40e6b75fb2aa4fa
Reviewed-on:
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
M docs/zephyr_shim.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit ef7546b67594232672de3287e47653ec52d2a2f4
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:03:16 2021
zephyr: doc: Add zephyr docs to sitemap
To make it easier for people to get started with Zephyr, link in the
existing docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I68f0deb52a64147e705e53410699c372fd1e69b8
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807484
Reviewed-by: Yuval Peress <peress@chromium.org>
M docs/sitemap.md
https://chromium-review.googlesource.com/2807484
Branch: main
commit ef7546b67594232672de3287e47653ec52d2a2f4
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:03:16 2021
zephyr: doc: Add zephyr docs to sitemap
To make it easier for people to get started with Zephyr, link in the
existing docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I68f0deb52a64147e705e53410699c372fd1e69b8
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
M docs/sitemap.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 096a53b48cb8f51f838a6a0b87172334cb31073f
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:39:46 2021
zephyr: doc: Add a title to the shimming doc
This is confusing when browsing since it has no title. Add one.
Also move the 'alternatives considered' to the bottom while we are
here, since that is confusing for people who are less interested in
the motivation for shimming and just want to know what to do.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I73a4716278396dfdf0661d6ced67b3d6a9785165
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807487
Reviewed-by: Yuval Peress <peress@chromium.org>
M docs/zephyr_shim.md
https://chromium-review.googlesource.com/2807487
Branch: main
commit 096a53b48cb8f51f838a6a0b87172334cb31073f
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:39:46 2021
zephyr: doc: Add a title to the shimming doc
This is confusing when browsing since it has no title. Add one.
Also move the 'alternatives considered' to the bottom while we are
here, since that is confusing for people who are less interested in
the motivation for shimming and just want to know what to do.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I73a4716278396dfdf0661d6ced67b3d6a9785165
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
M docs/zephyr_shim.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: firmware-asurada-13885.B-main
commit e48015f267eefbdf04b68fe4ac917d50ea5044fc
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:39:46 2021
zephyr: doc: Add a title to the shimming doc
This is confusing when browsing since it has no title. Add one.
Also move the 'alternatives considered' to the bottom while we are
here, since that is confusing for people who are less interested in
the motivation for shimming and just want to know what to do.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I73a4716278396dfdf0661d6ced67b3d6a9785165
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807487
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2810495
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M docs/zephyr_shim.md
https://chromium-review.googlesource.com/2810495
Branch: firmware-asurada-13885.B-main
commit e48015f267eefbdf04b68fe4ac917d50ea5044fc
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:39:46 2021
zephyr: doc: Add a title to the shimming doc
This is confusing when browsing since it has no title. Add one.
Also move the 'alternatives considered' to the bottom while we are
here, since that is confusing for people who are less interested in
the motivation for shimming and just want to know what to do.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I73a4716278396dfdf0661d6ced67b3d6a9785165
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M docs/zephyr_shim.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: firmware-asurada-13885.B-main
commit 5dec88b14314195fb5b18bc7f49d189bf179c2ff
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:03:16 2021
zephyr: doc: Add zephyr docs to sitemap
To make it easier for people to get started with Zephyr, link in the
existing docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I68f0deb52a64147e705e53410699c372fd1e69b8
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807484
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2810494
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M docs/sitemap.md
https://chromium-review.googlesource.com/2810494
Branch: firmware-asurada-13885.B-main
commit 5dec88b14314195fb5b18bc7f49d189bf179c2ff
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 07:03:16 2021
zephyr: doc: Add zephyr docs to sitemap
To make it easier for people to get started with Zephyr, link in the
existing docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I68f0deb52a64147e705e53410699c372fd1e69b8
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M docs/sitemap.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 2867193866966106225b19a3b7d5d18ba43489e8
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 17:04:57 2021
zephyr: zmake: Avoid using pip3 for install
When running on a distribution it seems better to use the standard
install procedure if possible, with pip3 reserved for things that are
not available. If users have an old distribution, they will presumably
fall back to using pip3 anyway.
Update to use 'apt-get install' in the docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I539518a3009e73cb948145ca68f868fa5588909d
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809779
Reviewed-by: Yuval Peress <peress@chromium.org>
M docs/zephyr_build.md
https://chromium-review.googlesource.com/2809779
Branch: main
commit 2867193866966106225b19a3b7d5d18ba43489e8
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 17:04:57 2021
zephyr: zmake: Avoid using pip3 for install
When running on a distribution it seems better to use the standard
install procedure if possible, with pip3 reserved for things that are
not available. If users have an old distribution, they will presumably
fall back to using pip3 anyway.
Update to use 'apt-get install' in the docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I539518a3009e73cb948145ca68f868fa5588909d
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
M docs/zephyr_build.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit caaef81e2ddb1767f29623fe35a39a142042edd3
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 06:58:57 2021
zephyr: Add build instructions
Add some information from the care & feeding guide.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Change-Id: I1ad507cd87359dbfc6e2b89dcfd4c5d4ea77b2ca
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807485
Reviewed-by: Yuval Peress <peress@chromium.org>
A docs/zephyr_build.md
https://chromium-review.googlesource.com/2807485
Branch: main
commit caaef81e2ddb1767f29623fe35a39a142042edd3
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 06:58:57 2021
zephyr: Add build instructions
Add some information from the care & feeding guide.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Change-Id: I1ad507cd87359dbfc6e2b89dcfd4c5d4ea77b2ca
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
A docs/zephyr_build.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: firmware-asurada-13885.B-main
commit 540a5c8c7297a3802e920c7d8f156fa5e4f696d1
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 17:04:57 2021
zephyr: zmake: Avoid using pip3 for install
When running on a distribution it seems better to use the standard
install procedure if possible, with pip3 reserved for things that are
not available. If users have an old distribution, they will presumably
fall back to using pip3 anyway.
Update to use 'apt-get install' in the docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I539518a3009e73cb948145ca68f868fa5588909d
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809779
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813591
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M docs/zephyr_build.md
https://chromium-review.googlesource.com/2813591
Branch: firmware-asurada-13885.B-main
commit 540a5c8c7297a3802e920c7d8f156fa5e4f696d1
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 17:04:57 2021
zephyr: zmake: Avoid using pip3 for install
When running on a distribution it seems better to use the standard
install procedure if possible, with pip3 reserved for things that are
not available. If users have an old distribution, they will presumably
fall back to using pip3 anyway.
Update to use 'apt-get install' in the docs.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I539518a3009e73cb948145ca68f868fa5588909d
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M docs/zephyr_build.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: firmware-asurada-13885.B-main
commit b21a6e202e3334df28ecdb667927fe2455d30e1d
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 06:58:57 2021
zephyr: Add build instructions
Add some information from the care & feeding guide.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Change-Id: I1ad507cd87359dbfc6e2b89dcfd4c5d4ea77b2ca
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807485
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813590
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
A docs/zephyr_build.md
https://chromium-review.googlesource.com/2813590
Branch: firmware-asurada-13885.B-main
commit b21a6e202e3334df28ecdb667927fe2455d30e1d
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 07 06:58:57 2021
zephyr: Add build instructions
Add some information from the care & feeding guide.
BUG=b:181253613
BRANCH=none
TEST=check it in gitiles
Change-Id: I1ad507cd87359dbfc6e2b89dcfd4c5d4ea77b2ca
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on:
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-on:
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
A docs/zephyr_build.md
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 372640be96881bb17ed74dcac05399c5cde4637d
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:15 2021
Makefile.rules: add quiet_cmd...
This enhances the quiet function to optionally print a command specific
terse representation of the make command being invoked. If no custom
command string is specified, the original behavior is preserved: the
terse command string is printed followed by the computed target name.
Now, if quiet_cmd_<CMD> has a non-empty value, its value is printed
instead.
BRANCH=none
BUG=b:181253613
TEST=buildall passes
Change-Id: I8ff13678307a3fe4f2ecd1a4cf89ed550e5702bb
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2803973
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
M Makefile.rules
https://chromium-review.googlesource.com/2803973
Branch: main
commit 372640be96881bb17ed74dcac05399c5cde4637d
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:15 2021
Makefile.rules: add quiet_cmd...
This enhances the quiet function to optionally print a command specific
terse representation of the make command being invoked. If no custom
command string is specified, the original behavior is preserved: the
terse command string is printed followed by the computed target name.
Now, if quiet_cmd_<CMD> has a non-empty value, its value is printed
instead.
BRANCH=none
BUG=b:181253613
TEST=buildall passes
Change-Id: I8ff13678307a3fe4f2ecd1a4cf89ed550e5702bb
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
M Makefile.rules
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 06400d48f1cef8053208ab3d2345fc7d4ac80f07
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:52 2021
Makefile.rules: Make check_allowed invocation less obscure
Originally, the util/check_allowed.sh was completely hidden which made
it hard to track, specially since it often flags a change that needs
further analysis. With this change, make reports the
util/check_allowed.sh invocation as "CHECK_ALLOWED". Also, when building
with V=1, the actual command invocation is reported:
(brya-shared-image) [brya] $ make -j
...
CHECK_ALLOWED build/brya/.config
...
OR:
(brya-shared-image) [brya] $ make V=1 -j
...
./util/check_allowed.sh build/brya/.config util/config_allowed.txt .
...
BRANCH=none
BUG=b:181253613
TEST=verified check_allowed is reporte as "CHECK_ALLOWED" during a
normal build and as a full command invocation with V=1.
Change-Id: Ie1132221ee9b8d5d381adb5413b96ae2a2f71db9
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2803974
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
M Makefile.rules
https://chromium-review.googlesource.com/2803974
Branch: main
commit 06400d48f1cef8053208ab3d2345fc7d4ac80f07
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:52 2021
Makefile.rules: Make check_allowed invocation less obscure
Originally, the util/check_allowed.sh was completely hidden which made
it hard to track, specially since it often flags a change that needs
further analysis. With this change, make reports the
util/check_allowed.sh invocation as "CHECK_ALLOWED". Also, when building
with V=1, the actual command invocation is reported:
(brya-shared-image) [brya] $ make -j
...
CHECK_ALLOWED build/brya/.config
...
OR:
(brya-shared-image) [brya] $ make V=1 -j
...
./util/check_allowed.sh build/brya/.config util/config_allowed.txt .
...
BRANCH=none
BUG=b:181253613
TEST=verified check_allowed is reporte as "CHECK_ALLOWED" during a
normal build and as a full command invocation with V=1.
Change-Id: Ie1132221ee9b8d5d381adb5413b96ae2a2f71db9
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
M Makefile.rules
ap...@google.com
Project: chromiumos/platform/ec
Branch: firmware-asurada-13885.B-main
commit 2119677e34e7faad1de27e396de2262cf4aaff30
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:15 2021
Makefile.rules: add quiet_cmd...
This enhances the quiet function to optionally print a command specific
terse representation of the make command being invoked. If no custom
command string is specified, the original behavior is preserved: the
terse command string is printed followed by the computed target name.
Now, if quiet_cmd_<CMD> has a non-empty value, its value is printed
instead.
BRANCH=none
BUG=b:181253613
TEST=buildall passes
Change-Id: I8ff13678307a3fe4f2ecd1a4cf89ed550e5702bb
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2803973
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2839157
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M Makefile.rules
https://chromium-review.googlesource.com/2839157
Branch: firmware-asurada-13885.B-main
commit 2119677e34e7faad1de27e396de2262cf4aaff30
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:15 2021
Makefile.rules: add quiet_cmd...
This enhances the quiet function to optionally print a command specific
terse representation of the make command being invoked. If no custom
command string is specified, the original behavior is preserved: the
terse command string is printed followed by the computed target name.
Now, if quiet_cmd_<CMD> has a non-empty value, its value is printed
instead.
BRANCH=none
BUG=b:181253613
TEST=buildall passes
Change-Id: I8ff13678307a3fe4f2ecd1a4cf89ed550e5702bb
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on:
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M Makefile.rules
ap...@google.com
Project: chromiumos/platform/ec
Branch: firmware-asurada-13885.B-main
commit a2d41db7f46ee28cbf6b1a72377a6114912db75a
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:52 2021
Makefile.rules: Make check_allowed invocation less obscure
Originally, the util/check_allowed.sh was completely hidden which made
it hard to track, specially since it often flags a change that needs
further analysis. With this change, make reports the
util/check_allowed.sh invocation as "CHECK_ALLOWED". Also, when building
with V=1, the actual command invocation is reported:
(brya-shared-image) [brya] $ make -j
...
CHECK_ALLOWED build/brya/.config
...
OR:
(brya-shared-image) [brya] $ make V=1 -j
...
./util/check_allowed.sh build/brya/.config util/config_allowed.txt .
...
BRANCH=none
BUG=b:181253613
TEST=verified check_allowed is reporte as "CHECK_ALLOWED" during a
normal build and as a full command invocation with V=1.
Change-Id: Ie1132221ee9b8d5d381adb5413b96ae2a2f71db9
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2803974
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2839164
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M Makefile.rules
https://chromium-review.googlesource.com/2839164
Branch: firmware-asurada-13885.B-main
commit a2d41db7f46ee28cbf6b1a72377a6114912db75a
Author: Caveh Jalali <caveh@chromium.org>
Date: Fri Apr 02 19:03:52 2021
Makefile.rules: Make check_allowed invocation less obscure
Originally, the util/check_allowed.sh was completely hidden which made
it hard to track, specially since it often flags a change that needs
further analysis. With this change, make reports the
util/check_allowed.sh invocation as "CHECK_ALLOWED". Also, when building
with V=1, the actual command invocation is reported:
(brya-shared-image) [brya] $ make -j
...
CHECK_ALLOWED build/brya/.config
...
OR:
(brya-shared-image) [brya] $ make V=1 -j
...
./util/check_allowed.sh build/brya/.config util/config_allowed.txt .
...
BRANCH=none
BUG=b:181253613
TEST=verified check_allowed is reporte as "CHECK_ALLOWED" during a
normal build and as a full command invocation with V=1.
Change-Id: Ie1132221ee9b8d5d381adb5413b96ae2a2f71db9
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on:
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on:
Tested-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@chromium.org>
M Makefile.rules
ba...@google.com
Is there anything more to be done in this ticket or can it be closed?
sj...@google.com
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 0ed9052bc706efd3fe55a6f5d813d8a7459c9d9b
Author: Jeremy Bettis <jbettis@google.com>
Date: Tue Jul 12 17:04:11 2022
ec: Shim PLATFORM_EC_PERIPHERAL_CHARGER
Shim CONFIG_PLATFORM_EC_PERIPHERAL_CHARGER in zephyr to
CONFIG_PERIPHERAL_CHARGER in legacy ec.
BRANCH=None
BUG=b:238773780,b:181253613
TEST=make -j40 buildall && util/run_tests.sh
Change-Id: Iedfc6f7eb89fd7018892f9e467c163c453cfcdc6
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3759273
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
M zephyr/shim/include/config_chip.h
M zephyr/Kconfig
M zephyr/CMakeLists.txt
https://chromium-review.googlesource.com/3759273
Branch: main
commit 0ed9052bc706efd3fe55a6f5d813d8a7459c9d9b
Author: Jeremy Bettis <jbettis@google.com>
Date: Tue Jul 12 17:04:11 2022
ec: Shim PLATFORM_EC_PERIPHERAL_CHARGER
Shim CONFIG_PLATFORM_EC_PERIPHERAL_CHARGER in zephyr to
CONFIG_PERIPHERAL_CHARGER in legacy ec.
BRANCH=None
BUG=b:238773780,b:181253613
TEST=make -j40 buildall && util/run_tests.sh
Change-Id: Iedfc6f7eb89fd7018892f9e467c163c453cfcdc6
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on:
Commit-Queue: Keith Short <keithshort@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
M zephyr/shim/include/config_chip.h
M zephyr/Kconfig
M zephyr/CMakeLists.txt
ap...@google.com
Project: chromiumos/platform/ec
Branch: main
commit 3ee8dd3d69a467e695f4263d0aee1ebb26fced76
Author: Jeremy Bettis <jbettis@google.com>
Date: Tue Jul 12 13:27:00 2022
ec: Fix kconfig_check and run unit test in cq
Changed the unit test to fail if it can't find zephyr or the kconfiglib
instead of skipping, and make it pass.
Run the unit test in the CQ.
In the process, I discovered that it never used kconfiglib because of
errors with ZEPHYR_BASE not being set. Changed kconfig_check to output
the error when it falls back to no kconfiglib.
This exposed that there were missing configs in util/config_allowed.txt
BRANCH=None
BUG=b:238773780,b:181253613
TEST=make -j40 buildall && util/run_tests.sh
Change-Id: I28a050d448a40df034dd9f2305a2d17cd0797468
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3759263
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
A util/run_tests.sh
M util/test_kconfig_check.py
M firmware_builder.py
M Makefile.rules
M util/kconfig_check.py
M util/config_allowed.txt
https://chromium-review.googlesource.com/3759263
Branch: main
commit 3ee8dd3d69a467e695f4263d0aee1ebb26fced76
Author: Jeremy Bettis <jbettis@google.com>
Date: Tue Jul 12 13:27:00 2022
ec: Fix kconfig_check and run unit test in cq
Changed the unit test to fail if it can't find zephyr or the kconfiglib
instead of skipping, and make it pass.
Run the unit test in the CQ.
In the process, I discovered that it never used kconfiglib because of
errors with ZEPHYR_BASE not being set. Changed kconfig_check to output
the error when it falls back to no kconfiglib.
This exposed that there were missing configs in util/config_allowed.txt
BRANCH=None
BUG=b:238773780,b:181253613
TEST=make -j40 buildall && util/run_tests.sh
Change-Id: I28a050d448a40df034dd9f2305a2d17cd0797468
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on:
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
A util/run_tests.sh
M util/test_kconfig_check.py
M firmware_builder.py
M Makefile.rules
M util/kconfig_check.py
M util/config_allowed.txt
Description
Still, as ECOS grows in capabilities we should make sure that Zephyr gains these new features so that it does not fall behind.
We need a way to ratchet Zephyr up to parity across all features.
The easiest option seems to be to make sure that new CONFIG options are added both in ECOS and in Zephyr. This is similar to the script used in U-Boot to aid migration to Kconfig, so let's copy that script over and modify it for ECOS.
See go/zephyr-care for more info.