IssueTracker

Fix focus move within child AndroidViews 
 
Fixes: 389994198 
Fixes: 391378895 
 
Relnote: "Fixes focus travel within child AndroidViews where it 
can sometimes jump out of the child to the ComposeView" 
 
Sometimes the native FocusFinder doesn't act properly and finds 
the wrong View when searching. This CL changes the FocusFinder to 
use a newer copy of FocusFinder for all focus search operations 
in AndroidComposeView. 
 
Test: new test, manual testing 
Change-Id: I678c864afe086879c5c45b018dd82da4f23be440

Files:

• M compose/ui/ui/src/androidInstrumentedTest/AndroidManifest.xml
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusListenerTest.kt
• A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/TestActivity2.kt
• A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt
• M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
• M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/FocusFinderCompat.android.kt

Hash: b028bcc322095634123da91c7146bac9e23c13c7
Date:  Tue Jan 14 13:48:11 2025

Disabling isViewFocusFixEnabled and isRemoveFocusedViewFixEnabled 
 
Disabling these flag to unblock 1.8 RC. 
These were features/bug-fixes that were not regressions 
from 1.7 
 
Bug: 406327273 
Bug: 369256395 
Bug: 378570682 
Bug: 376142752 
Bug: 384056227 
Bug: 388590015 
Bug: 389994198 
Bug: 391378895 
Test: Ran presubmits and added TODOs to the affected tests 
Change-Id: I5ffb7ff27c662838c8b464560d1df830751f015c

Files:

• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusViewInteropTest.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/OwnerFocusTest.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposeUiFlags.kt

Hash: 1a33d21734ef7f68d4cad37c8d333831f304a339
Date:  Tue Apr 01 17:46:50 2025

Fix requestFocus with bad previous rectangle 
 
Fixes: 388590015 
 
When requestFocus() is called on a ComposeView with a previousRect 
set to something that doesn't make sense (empty rectangle from the 
wrong direction, for example), the previous behavior would not 
find a matching component in that direction. Instead, it would 
find the next View to focus on and pass the focus on. 
 
With this CL, if the ComposeView isn't currently focused and a 
focusSearch fails to find something focusable in relation to the 
previous rectangle, an attempt is made irrespective of the 
previous rectangle. 
 
Relnote: "Fixed focus issue where requestFocus() with a 
nonsensical previouslyFocusedRect parameter (related to 
the focus direction) would skip past a ComposeView." 
 
Test: new test, manual testing 
Change-Id: Ifdc2f17b23620d1ae14848624f447f84cc1b0b5d

Files:

• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
• M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt

Hash: 8501eec732d61bd71c385a90f58a194191816d57
Date:  Fri Jan 10 11:04:59 2025

Disabling isViewFocusFixEnabled and isRemoveFocusedViewFixEnabled 
 
Disabling these flag to unblock 1.8 RC. 
These were features/bug-fixes that were not regressions 
from 1.7 
 
Bug: 406327273 
Bug: 369256395 
Bug: 378570682 
Bug: 376142752 
Bug: 384056227 
Bug: 388590015 
Bug: 389994198 
Bug: 391378895 
Test: Ran presubmits and added TODOs to the affected tests 
Change-Id: I5ffb7ff27c662838c8b464560d1df830751f015c

Files:

• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusViewInteropTest.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/OwnerFocusTest.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposeUiFlags.kt

Hash: 1a33d21734ef7f68d4cad37c8d333831f304a339
Date:  Tue Apr 01 17:46:50 2025