ROOM should silently use the primary constructor of data classes rather than warn about multiple constructors [105769985]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jun 3, 2018 09:44PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): ROOM
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time

- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:

https://github.com/hzsweers/CatchUp

In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.

Example:

https://github.com/hzsweers/CatchUp/blob/6a6bee429524eb4dece065f6862d2c7ec83d65ce/tooling/moshkt/compiler/src/main/kotlin/io/sweers/moshkt/compiler/MoshKtProcessor.kt#L124

The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API

Comments

yb...@google.com <yb...@google.com> #2Jun 4, 2018 04:14PM

Assigned to yb...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit c73bd92631a2ff341f89001bc9143c7b998333e8
Author: Sanura N'Jaka <sanura@google.com>
Date: Thu Aug 18 18:03:13 2022

Add project dependency constraint between lifecycle-viewmodel and lifecycle-viewmodel-savedstate

Added bi-directional project version constraint between
lifecycle-viewmodel and lifecycle-viewmodel-savedstate.
If both artifacts are in the dependency tree, their
versions should match. This will now be enforced by gradle
automatically bumping up either version to meet constraint.

Test: N/A
Bug: 242871265
Change-Id: I3ab2abf9b6b1861038afc0e651da80e4ee75efb8

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle

https://android-review.googlesource.com/2189976

yb...@google.com <yb...@google.com> #3Jun 4, 2018 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit e7a81dc92c9c56b31455c75161a8becf49f761e3
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Aug 17 22:44:55 2022

Add project dependency constraint between lifecycle-runtime and lifecycle-runtime-compose

Added bi-directional project version constraint between
lifecycle-runtime and lifecycle-runtime-compose. If both
artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle
automatically bumping up either version to meet constraint.

Test: N/A
Bug: 242871265
Change-Id: I0f6b3928ac0b338b0fcc6835828dd43fadee8c0d

M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime/build.gradle

https://android-review.googlesource.com/2189951

za...@gmail.com <za...@gmail.com> #4Jun 4, 2018 05:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit b671082b2d2ba47ca41f33646780e797ac6689cc
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Aug 17 20:02:11 2022

Add project dependency constraint between lifecycle-common and lifecycle-runtime

Added bi-directional project version constraint between lifecycle-common and
lifecycle-runtime. If both artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle automatically bumping up
either version to meet constraint.

Test: N/A
Bug: 242871265
Change-Id: I98fea6d1a6b2cde61b0cf5c7822cd98b6218c578

M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-common/build.gradle

https://android-review.googlesource.com/2188999

za...@gmail.com <za...@gmail.com> #5Jun 25, 2018 12:18AM

Project: platform/frameworks/support
Branch: androidx-main

commit f9794b48f28888fa27810c9b758062461d632454
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Aug 17 22:26:13 2022

Add project dependency constraint between lifecycle-runtime and lifecycle-runtime-testing

Added bi-directional project version constraint between
lifecycle-runtime and lifecycle-runtime-testing. If both
artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle
automatically bumping up either version to meet constraint.

Test: N/A
Bug: 242871265
Change-Id: I3ef6323dbdd3da20bad912e1bd7b9000e6832b7d

M lifecycle/lifecycle-runtime-testing/build.gradle
M lifecycle/lifecycle-runtime/build.gradle

https://android-review.googlesource.com/2188586

yb...@google.com <yb...@google.com> Jun 25, 2018 12:28AM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #6Jun 29, 2018 09:34PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 34098809c70a985495ec836f286a7b8d8245808f
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Aug 17 22:16:45 2022

Add project dependency constraint between lifecycle-runtime and lifecycle-runtime-ktx

Added bi-directional project version constraint between
lifecycle-runtime and lifecycle-runtime-ktx. If both
artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle
automatically bumping up either version to meet constraint.

Test: N/A
Bug: 242871265
Change-Id: Id0a3eae91e652a3bdb7a64d1f17dd5c30e7fa03f

M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime-ktx/build.gradle

https://android-review.googlesource.com/2188585

Issue 105769985