ROOM should silently use the primary constructor of data classes rather than warn about multiple constructors [105769985]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jun 3, 2018 09:44PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): ROOM
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time

- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:

https://github.com/hzsweers/CatchUp

In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.

Example:

https://github.com/hzsweers/CatchUp/blob/6a6bee429524eb4dece065f6862d2c7ec83d65ce/tooling/moshkt/compiler/src/main/kotlin/io/sweers/moshkt/compiler/MoshKtProcessor.kt#L124

The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API

Comments

yb...@google.com <yb...@google.com> #2Jun 4, 2018 04:14PM

Assigned to yb...@google.com.

Please Read: https://developer.android.com/studio/report-bugs.html#emulator-bugs

Android Studio Version: Unknown

Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.3.15-9456632 HAXM / KVM Version: HVF 13.0.0

Android SDK Tools: 26.1.1

Host Operating System: macOS 13.0.1

CPU Manufacturer: Other CPU: 64-bit CPU

RAM: 32768 MB

GPU:

Build Fingerprint:

AVD Details: Name: Pixel_2_API_33 CPU/ABI: arm64 Path: /.android/avd/Pixel_2_API_33.avd Target: google_apis_playstore [Google Play] (API level 33) Skin: 1080x1920 SD Card: 512M AvdId: Pixel_2_API_33 PlayStore.enabled: true avd.ini.displayname: Pixel 2 API 33 avd.ini.encoding: UTF-8 disk.dataPartition.size: 6442450944 fastboot.chosenSnapshotFile: fastboot.forceChosenSnapshotBoot: no fastboot.forceColdBoot: no fastboot.forceFastBoot: yes hw.accelerometer: yes hw.arc: false hw.audioInput: yes hw.battery: yes hw.camera.back: virtualscene hw.camera.front: emulated hw.cpu.ncore: 4 hw.dPad: no hw.device.hash2: MD5:55acbc835978f326788ed66a5cd4c9a7 hw.device.manufacturer: Google hw.device.name: pixel_2 hw.gps: yes hw.gpu.enabled: yes hw.gpu.mode: auto hw.initialOrientation: Portrait hw.keyboard: yes hw.lcd.density: 420 hw.lcd.height: 1920 hw.lcd.width: 1080 hw.mainKeys: no hw.ramSize: 1536 hw.sdCard: yes hw.sensors.orientation: yes hw.sensors.proximity: yes hw.trackBall: no image.sysdir.1: system-images/android-33/google_apis_playstore/arm64-v8a/ runtime.network.latency: none runtime.network.speed: full showDeviceFrame: no skin.dynamic: yes skin.path.backup: /Users/***/Development/Android/skins/pixel_2 tag.display: Google Play tag.id: google_apis_playstore vm.heapSize: 228

Steps to Reproduce Bug:

Install Android Studio Eel
Create an emulator with API 23
Run the emulator from AS

The emulator started from Android studio can't resolve any URLs.

Android Studio: Android Studio Electric Eel | 2022.1.1 Build #AI-221.6008.13.2211.9477386, built on January 11, 2023 Runtime version: 11.0.15+0-b2043.56-8887301 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 13.0.1 GC: G1 Young Generation, G1 Old Generation Memory: 5128M Cores: 10 Registry: external.system.auto.import.disabled=true ide.text.editor.with.preview.show.floating.toolbar=false ide.instant.shutdown=false ide.balloon.shadow.size=0

Non-Bundled Plugins: org.toml.lang (221.6008.15) com.intellij.marketplace (221.6008.18) Key Promoter X (2022.2) mobi.hsz.idea.gitignore (4.4.0) com.developerphil.adbidea (1.6.8) izhangzhihao.rainbow.brackets (2023.1.1-ij)

What helps is to start the emulator from the command line -netdelay none -netspeed full -dns-server '2001:4860:4860::8844,2001:4860:4860::8888,8.8.8.8,8.8.4.4'

Expected Behavior:

Network works on emulator started from AS.

Observed Behavior:

Emualtor started from AS either "in-window" or in a separate window can't set up a network. Though it looks like emulators with API 23,24,25 work fine.

yb...@google.com <yb...@google.com> #3Jun 4, 2018 04:28PM

I think it has to do with your dns configuration on host. Since you mentioned that running command line -netdelay none -netspeed full -dns-server '2001:4860:4860::8844,2001:4860:4860::8888,8.8.8.8,8.8.4.4' works for you. I wonder if you could run emulator with command line -verbose and send the log to us. It will print out the dns server being used.

za...@gmail.com <za...@gmail.com> #4Jun 4, 2018 05:02PM

Thank you for your reply! Here you can find the log. It's worth noting that I haven't changed any default settings.

za...@gmail.com <za...@gmail.com> #5Jun 25, 2018 12:18AM

VERBOSE | Found 2 DNS servers:
VERBOSE |       fe80::16de:39ff:fe44:5806
VERBOSE |       192.168.1.1

It looks like emulator is trying to use fe80::16de:39ff:fe44:5806 which is the link-local address. Emulator always seem to have a problem with local addresses.

yb...@google.com <yb...@google.com> Jun 25, 2018 12:28AM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #6Jun 29, 2018 09:34PM

Marked as fixed.

Hi @maze, do you think it would make sense for emulator to switch to 2001:4860:4860::8844 when ipv6 link local address is present in the local dns config file? Apparently, there is some issue with DNS probe when the host DNS address is link local.

Issue 105769985