Fixed
Status Update
No update yet.
Comments
yb...@google.com
Makes sense, thanks for reporting this, I'll send a fix soon.
yb...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ed9cc5573271288500a7f416520dc509d8047f0f
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 08 13:41:08 2024
Use same visibility as expect declaration when generating RoomDatabaseConstructor
Bug: 358138953
Test: DatabaseObjectConstructorWriterKotlinCodeGenTest
Change-Id: I0b2bb1a590f48199e398f72ac2b881e1eceb571f
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseMigrationTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/DatabaseObjectConstructorWriter.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/kotlinCodeGen/actualDatabaseConstructor_internal.kt
https://android-review.googlesource.com/3213484
Branch: androidx-main
commit ed9cc5573271288500a7f416520dc509d8047f0f
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 08 13:41:08 2024
Use same visibility as expect declaration when generating RoomDatabaseConstructor
Bug: 358138953
Test: DatabaseObjectConstructorWriterKotlinCodeGenTest
Change-Id: I0b2bb1a590f48199e398f72ac2b881e1eceb571f
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseMigrationTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/writer/DatabaseObjectConstructorWriter.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
A room/room-compiler/src/test/test-data/kotlinCodeGen/actualDatabaseConstructor_internal.kt
za...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler:2.7.0-alpha07
za...@gmail.com
Mentioned in the original issue, but dropping here too.
It seems you can't have nullable val properties. If I have a class with all val properties, it works fine. It complains about multiple constructors, but it doesn't fail at least
It seems you can't have nullable val properties. If I have a class with all val properties, it works fine. It complains about multiple constructors, but it doesn't fail at least
Description
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time
- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:
In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.
Example:
The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API