Status Update
No update yet.
Comments
yb...@google.com
Tentatively, the annotation should be something use-case-specific like @OutlinedNewApi that allows alternative build systems (e.g. not R8/D8) to make their own decisions. We'll provide a default Proguard configuration for R8, but it's not guaranteed this will work as intended -- outlining is automatic in newer versions, but it may be disabled.
yb...@google.com
Just as an FYI, this was enabled in AGP 2 years ago (AGP 7.3 as far as I remember), ag/18426192, so for AGP users it might fine to just remove the rule for @DoNotInline. I like the @OutlinedNewApi to make it clear what this is for other consumers to handle it as they see fit.
za...@gmail.com
Given the failure mode can include run-time crashes, that's not an acceptable level of usage.
za...@gmail.com
I think you can still include a top-level proguard.txt, and it will be used by versions that do not support the com.android.tools format. E.g.
Description
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time
- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:
In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.
Example:
The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API