ROOM should silently use the primary constructor of data classes rather than warn about multiple constructors [105769985]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jun 3, 2018 09:44PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): ROOM
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time

- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:

https://github.com/hzsweers/CatchUp

In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.

Example:

https://github.com/hzsweers/CatchUp/blob/6a6bee429524eb4dece065f6862d2c7ec83d65ce/tooling/moshkt/compiler/src/main/kotlin/io/sweers/moshkt/compiler/MoshKtProcessor.kt#L124

The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API

Comments

yb...@google.com <yb...@google.com> #2Jun 4, 2018 04:14PM

Assigned to yb...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

yb...@google.com <yb...@google.com> #3Jun 4, 2018 04:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

za...@gmail.com <za...@gmail.com> #4Jun 4, 2018 05:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

za...@gmail.com <za...@gmail.com> #5Jun 25, 2018 12:18AM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

yb...@google.com <yb...@google.com> Jun 25, 2018 12:28AM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #6Jun 29, 2018 09:34PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

Issue 105769985