ROOM should silently use the primary constructor of data classes rather than warn about multiple constructors [105769985]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jun 3, 2018 09:44PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): ROOM
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time

- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:

https://github.com/hzsweers/CatchUp

In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.

Example:

https://github.com/hzsweers/CatchUp/blob/6a6bee429524eb4dece065f6862d2c7ec83d65ce/tooling/moshkt/compiler/src/main/kotlin/io/sweers/moshkt/compiler/MoshKtProcessor.kt#L124

The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API

Comments

yb...@google.com <yb...@google.com> #2Jun 4, 2018 04:14PM

Assigned to yb...@google.com.

Heres the other logs if the previous log isnt detailed

yb...@google.com <yb...@google.com> #3Jun 4, 2018 04:28PM

Im trying to open the page again using my other project (cgdx-1132485) using Microsoft Edge Version 127.0.2651.98 (Official build) (64-bit) with Windows 11 23H2 Build 22631.3880.

But maybe this helps (Edit: even though if the error said 'Too Many Request', im just opening it normally without reopen the page many times)
VM1948 m=hfcr:34

POST

https://accounts.google.com/RotateCookies 429 (Too Many Requests)
db @ VM1948 m=hfcr:34
fb @ VM1948 m=hfcr:35
(anonymous) @ VM1948 m=hfcr:33
setTimeout
(anonymous) @ VM1948 m=hfcr:33
$a @ VM1948 m=hfcr:33
e @ VM1948 m=hfcr:32
(anonymous) @ VM1948 m=hfcr:32
setTimeout
Xa.start @ VM1948 m=hfcr:32
gb @ VM1948 m=hfcr:36
(anonymous) @ VM1949 RotateCookiesPage:1

za...@gmail.com <za...@gmail.com> #4Jun 4, 2018 05:02PM

I Had same issue with my Laravel project that work in IDX Project. Im using IDX Laravel Template for this

za...@gmail.com <za...@gmail.com> #5Jun 25, 2018 12:18AM

It seems that everyone is struggling with this issue? (Because I see the viewer count at 60+) I hope that this issue can be fixed ASAP

yb...@google.com <yb...@google.com> Jun 25, 2018 12:28AM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #6Jun 29, 2018 09:34PM

Marked as fixed.

i'm also experiencing this issue for about a week now in one of my workspace

Issue 105769985