ROOM should silently use the primary constructor of data classes rather than warn about multiple constructors [105769985]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jun 3, 2018 09:44PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): ROOM
Version used: 1.1.0-present
Theme used: NA
Devices/Android versions reproduced on: NA build-time

- Relevant code to trigger the issue: Any kotlin data class in an external module. Building the following project can reproduce it:

https://github.com/hzsweers/CatchUp

In Kotlin, data classes will have a primary constructor and sometimes generated synthetic constructors. ROOM's processor will complain about the presence of the synthetic ones (which are usually visible when reading the class file from an external library), but since it's reading metadata it could use it to find the "primary" constructor to know for sure.

Example:

https://github.com/hzsweers/CatchUp/blob/6a6bee429524eb4dece065f6862d2c7ec83d65ce/tooling/moshkt/compiler/src/main/kotlin/io/sweers/moshkt/compiler/MoshKtProcessor.kt#L124

The solution would be to find that constructor, then match it to the corresponding constructor as seen in the elements API

Comments

yb...@google.com <yb...@google.com> #2Jun 4, 2018 04:14PM

Assigned to yb...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f570475abb57a6527f861a083ddfccf451b3427b
Author: Sumir Kataria <sumir@google.com>
Date: Wed Aug 29 14:09:32 2018

Add ability to trigger timed work in TestDriver.

Bug: 113360060
Test: Added and ran new tests in TestSchedulerTest.
Change-Id: I681db88e3190b96e90a5d531b7b1fa053eaf8ab9

M work/workmanager-test/src/androidTest/java/androidx/work/test/TestSchedulerTest.java
A work/workmanager-test/src/androidTest/java/androidx/work/test/workers/CountingTestWorker.java
M work/workmanager-test/src/androidTest/java/androidx/work/test/workers/TestWorker.java
M work/workmanager-test/src/main/java/androidx/work/test/TestDriver.java
M work/workmanager-test/src/main/java/androidx/work/test/TestScheduler.java
M work/workmanager-test/src/main/java/androidx/work/test/WorkManagerTestInitHelper.java

https://android-review.googlesource.com/740398

https://goto.google.com/android-sha1/f570475abb57a6527f861a083ddfccf451b3427b

yb...@google.com <yb...@google.com> #3Jun 4, 2018 04:28PM

The testing artifact (work-testing) will have the ability to trigger initial delays and period met signals in alpha09. You should use this to simulate any testing you need.

za...@gmail.com <za...@gmail.com> #4Jun 4, 2018 05:02PM

Wau, that was incredibly fast, thanks!

za...@gmail.com <za...@gmail.com> #5Jun 25, 2018 12:18AM

Mentioned in the original issue, but dropping here too.

It seems you can't have nullable val properties. If I have a class with all val properties, it works fine. It complains about multiple constructors, but it doesn't fail at least

yb...@google.com <yb...@google.com> Jun 25, 2018 12:28AM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #6Jun 29, 2018 09:34PM

Marked as fixed.

This fix will be available in 2.0.0 beta 2.

Issue 105769985