Wrong behavior when Deep Link contains get query parameters [110057514]

Fixed

Bug

Status Update

No update yet.

Description

dj...@gmail.com

created issue #1

Jun 12, 2018 10:43AM

Component used: Android Architecture Components Navigation
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on:
Nexus 5 w 7.1 (Lineage OS)

In my project I created navigation graph as follows: Pages List -> Single Page -> Page Comments.
Each of destinations have their own Deep Link with some parameters in path:
1) Pages List: <deepLink app:uri="

myapp.com" />
2) Single Page: <deepLink app:uri="

myapp.com/{title}" /> (note that {title} matches destination argument)
3) Page Comments: <deepLink app:uri="

myapp.com/{title}/comments" /> (note that {title} matches destination argument)
And with those path arguments all is OK.

Then if we try to replace path arguments with get query parameters - strange things will begin to happen.
For example if we change Single Page deep link to this `<deepLink app:uri="

myapp.com/test/path/param?title={title}" />` - it'll always open root destinations (which is just

myapp.com).
Same for Page Comments, if we would add atleast one get query param - it'll always open root page (Pages List) when opened from matched Deep Link.
Here is link for demo project:

https://github.com/Ekalips/DeepUrlNavigatorTest/tree/broked_get_param (please note that it's special branch where deep link navigation is broken because of GET query parameter)

Comments

il...@google.com <il...@google.com> Jun 20, 2018 08:01PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Aug 14, 2018 08:36PM

Reassigned to wk...@google.com.

[Deleted User] <[Deleted User]> #2Sep 29, 2018 01:05AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

il...@google.com <il...@google.com> Oct 10, 2018 10:52PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #3Oct 12, 2018 10:04AM

This is fixed internally and will be available in 1.0.0-alpha08

il...@google.com <il...@google.com> #4Oct 12, 2018 04:38PM

Marked as fixed.

Thanks!

il...@google.com <il...@google.com> #5Oct 12, 2018 04:39PM

I should say, will work once 1.0.0-alpha07 is released :)

lu...@gmail.com <lu...@gmail.com> #6Nov 30, 2018 12:45PM

This is still happening with 1.0.0-alpha07

il...@google.com <il...@google.com> #7Nov 30, 2018 04:53PM

Re #6 - please file a new bug with a sample project that reproduces your issue.