Wrong behavior when Deep Link contains get query parameters [110057514]

Fixed

Bug

Status Update

No update yet.

Description

dj...@gmail.com

created issue #1

Jun 12, 2018 10:43AM

Component used: Android Architecture Components Navigation
Version used: 1.0.0-alpha02
Devices/Android versions reproduced on:
Nexus 5 w 7.1 (Lineage OS)

In my project I created navigation graph as follows: Pages List -> Single Page -> Page Comments.
Each of destinations have their own Deep Link with some parameters in path:
1) Pages List: <deepLink app:uri="

myapp.com" />
2) Single Page: <deepLink app:uri="

myapp.com/{title}" /> (note that {title} matches destination argument)
3) Page Comments: <deepLink app:uri="

myapp.com/{title}/comments" /> (note that {title} matches destination argument)
And with those path arguments all is OK.

Then if we try to replace path arguments with get query parameters - strange things will begin to happen.
For example if we change Single Page deep link to this `<deepLink app:uri="

myapp.com/test/path/param?title={title}" />` - it'll always open root destinations (which is just

myapp.com).
Same for Page Comments, if we would add atleast one get query param - it'll always open root page (Pages List) when opened from matched Deep Link.
Here is link for demo project:

https://github.com/Ekalips/DeepUrlNavigatorTest/tree/broked_get_param (please note that it's special branch where deep link navigation is broken because of GET query parameter)

Comments

il...@google.com <il...@google.com> Jun 20, 2018 08:01PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Aug 14, 2018 08:36PM

Reassigned to wk...@google.com.

[Deleted User] <[Deleted User]> #2Sep 29, 2018 01:05AM

Just to let you know that this issue present in the latest available release. I did just update to alpha09 and it breaks my code. My PagingSource if a Room backed source, but I have the same issue: the paging library failed to generate a separator for the first item.

It is still working with the alpha08.

il...@google.com <il...@google.com> Oct 10, 2018 10:52PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #3Oct 12, 2018 10:04AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit aa90cc2cb835209e12964d3afbc91e96b6d4e36b
Author: Dustin Lam <dustinlam@google.com>
Date: Tue Nov 24 11:34:08 2020

Add empty terminal insert for separators support with RemoteMediator

Re-applies a previous hack which inserted empty insert events to allow
separators to add terminal separators (header / footer), since
Separators may need to wait for a LoadStateUpdate event to mark terminal
load state from RemoteMediator.

Fixes: 172254056
Test: ./gradlew paging:paging-common:test
Change-Id: I5c5f2ac3860889909a30cd322a1e7b36eec1a9fd

M paging/common/src/main/kotlin/androidx/paging/MutableLoadStateCollection.kt
M paging/common/src/main/kotlin/androidx/paging/PageEvent.kt
M paging/common/src/main/kotlin/androidx/paging/PageFetcher.kt
M paging/common/src/main/kotlin/androidx/paging/Separators.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/common/src/test/kotlin/androidx/paging/SeparatorsTest.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/room/CustomerDao.java
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/NetworkCustomerPagingSource.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RemoteMediator.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RoomAdapter.kt
M paging/integration-tests/testapp/src/main/java/androidx/paging/integration/testapp/v3room/V3RoomViewModel.kt

https://android-review.googlesource.com/1510174

il...@google.com <il...@google.com> #4Oct 12, 2018 04:38PM

Marked as fixed.

We now properly escape characters in your deep links, so deep linking depending on query parameters will work now.

il...@google.com <il...@google.com> #5Oct 12, 2018 04:39PM

I should say, will work once 1.0.0-alpha07 is released :)

lu...@gmail.com <lu...@gmail.com> #6Nov 30, 2018 12:45PM

This is still happening with 1.0.0-alpha07

il...@google.com <il...@google.com> #7Nov 30, 2018 04:53PM

Re #6 - please file a new bug with a sample project that reproduces your issue.