Connect deep link parameters and arguments in a type safe way [110273284]

Fixed

Feature Request

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Jun 15, 2018 10:13PM

Currently it seems like passing parameters through a URL into a destination is a work in progress. It kinda works if you name the URL parameter the same as an argument, but it's not documented and it will only work with a string-type argument, as that's what will be parsed from a URL.

It would be great to have a well-defined, documented and supported way of passing data from a deep link URL to a destination as an argument, with type safety provided by safeargs.

Comments

il...@google.com <il...@google.com> Jun 20, 2018 05:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #2Jul 13, 2018 10:37PM

I have the same issue. There should be a built in method for setting title dynamically.

wk...@google.com <wk...@google.com> Jul 17, 2018 03:08PM

Reassigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 23, 2018 11:41AM

Accepted by wk...@google.com.

be...@google.com <be...@google.com> #3Jul 23, 2018 08:49PM

I would expect a simple API inside the navigation architecture as this is quite a common design requirement

il...@google.com <il...@google.com> #4Sep 14, 2018 11:34PM

To me, it is perfectly reasonable to remove the `android:label` attribute from the nav_graph.xml and set the title manually based on the arguments bundle.

il...@google.com <il...@google.com> #5Dec 11, 2018 06:14PM

Marked as fixed.

I'm currently working around this limitation by adding an "onNavigatedListener" to my root Activity and using the "

destination.id" property against a lookup mapping to a desired title:

private val onNavigatedListener: (NavController, NavDestination) -> Unit = { _, destination ->
this.title = titleLookup[

destination.id]
}