Connect deep link parameters and arguments in a type safe way [110273284]

Fixed

Feature Request

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Jun 15, 2018 10:13PM

Currently it seems like passing parameters through a URL into a destination is a work in progress. It kinda works if you name the URL parameter the same as an argument, but it's not documented and it will only work with a string-type argument, as that's what will be parsed from a URL.

It would be great to have a well-defined, documented and supported way of passing data from a deep link URL to a destination as an argument, with type safety provided by safeargs.

Comments

il...@google.com <il...@google.com> Jun 20, 2018 05:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #2Jul 13, 2018 10:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1dc8469381c79612a3d8f7ec138866c732506950
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jun 16 16:00:41 2020

Add ActivityResult lint to update Fragment dependency

When using the ActivityResult APIs, you should update the
fragment dependency to at least 1.3.0-alpha06 to ensure that
FragmentActivity is compatible.

This change adds a lint check to notify the user that their dependency
should be updated. This is only a warning, the user must fix the
dependency manually. The quick fix will be in a later CL.

Test: added ActivityResultFragmentVersionDetectorTest
Bug: 152554847
Change-Id: Ie59c1e2d428ce473f4e57939a69616b9052936c5

A activity/activity-lint/src/main/java/androidx/activity/lint/ActivityIssueRegistry.kt
A activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt
A activity/activity-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
A activity/activity-lint/src/test/java/androidx/activity/lint/ActivityResultFragmentVersionDetectorTest.kt
A activity/activity-lint/src/test/java/androidx/activity/lint/ApiLintVersionsTest.kt
A activity/activity-lint/src/test/java/androidx/activity/lint/stubs/Stubs.kt

https://android-review.googlesource.com/1332135

wk...@google.com <wk...@google.com> Jul 17, 2018 03:08PM

Reassigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 23, 2018 11:41AM

Accepted by wk...@google.com.

be...@google.com <be...@google.com> #3Jul 23, 2018 08:49PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 88b606aa168d0131d366a790183453d52ed97d26
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jun 11 11:27:35 2020

Create activity-lint module

Created module for custom activity lint checks.

Test: ./gradlew bOS
Bug: 152554847
Change-Id: Ice5a9794fcc769a82f1831cc10337d9b82fbbb71

A activity/activity-lint/build.gradle
M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M settings.gradle

https://android-review.googlesource.com/1332134

il...@google.com <il...@google.com> #4Sep 14, 2018 11:34PM

This has been fixed internally and will be available in the Activity 1.2.0-alpha07 release.

il...@google.com <il...@google.com> #5Dec 11, 2018 06:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a17089efb14fcfb5e3938680f0d3b3103245092c
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jul 01 17:59:41 2020

Publish the activity lint rule

We should actually publish the lint rule.

Also ignoring any project dependencies since they would be using the
most recent version of fragments anyway.

Test: ./gradlew bOS
Bug: 152554847
Change-Id: Ica57230490024b6aff32fcc3ec83d1c6f800f05f

M activity/activity-ktx/build.gradle
M activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt
M activity/activity-lint/src/test/java/androidx/activity/lint/ActivityResultFragmentVersionDetectorTest.kt
M activity/activity/build.gradle
M activity/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/1354243