Connect deep link parameters and arguments in a type safe way [110273284]

Fixed

Feature Request

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Jun 15, 2018 10:13PM

Currently it seems like passing parameters through a URL into a destination is a work in progress. It kinda works if you name the URL parameter the same as an argument, but it's not documented and it will only work with a string-type argument, as that's what will be parsed from a URL.

It would be great to have a well-defined, documented and supported way of passing data from a deep link URL to a destination as an argument, with type safety provided by safeargs.

Comments

il...@google.com <il...@google.com> Jun 20, 2018 05:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #2Jul 13, 2018 10:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ae09f6e6686b32c5677c086d51d5737553e2aeb9
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1373433

wk...@google.com <wk...@google.com> Jul 17, 2018 03:08PM

Reassigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 23, 2018 11:41AM

Accepted by wk...@google.com.

be...@google.com <be...@google.com> #3Jul 23, 2018 08:49PM

We've fixed this internally and are preparing a DrawerLayout 1.1.1 release with this fix.

il...@google.com <il...@google.com> #4Sep 14, 2018 11:34PM

Project: platform/frameworks/support
Branch: snap-temp-L48600000649720827

commit 6e863d72d89137a408907be4c44f5444b51f8dab
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1374836

il...@google.com <il...@google.com> #5Dec 11, 2018 06:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: snap-temp-L11100000649726887

commit 4b1419f8d1c41233b1af357a178c1eb6e71e3fb0
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 27 17:51:04 2020

Ensure open() and close() always work

As per the Javadoc on LOCK_MODE_LOCKED_CLOSED
and LOCK_MODE_LOCKED_OPEN, the app should
still be able to open() and close() the drawer
programmatically.

This change aligns open() and close() with
openDrawer() and closeDrawer() to allow
programmatic usage no matter what LOCK_MODE
is used.

Test: tested in sample app
BUG: 162253907
Change-Id: I74f2f7ea5ff8ce06bfcfeff09aedd980f385ffc7
(cherry picked from commit ae09f6e6686b32c5677c086d51d5737553e2aeb9)

M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java

https://android-review.googlesource.com/1374876