Connect deep link parameters and arguments in a type safe way [110273284]

Fixed

Feature Request

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Jun 15, 2018 10:13PM

Currently it seems like passing parameters through a URL into a destination is a work in progress. It kinda works if you name the URL parameter the same as an argument, but it's not documented and it will only work with a string-type argument, as that's what will be parsed from a URL.

It would be great to have a well-defined, documented and supported way of passing data from a deep link URL to a destination as an argument, with type safety provided by safeargs.

Comments

il...@google.com <il...@google.com> Jun 20, 2018 05:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #2Jul 13, 2018 10:37PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

wk...@google.com <wk...@google.com> Jul 17, 2018 03:08PM

Reassigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 23, 2018 11:41AM

Accepted by wk...@google.com.

be...@google.com <be...@google.com> #3Jul 23, 2018 08:49PM

yea i'll take it.

il...@google.com <il...@google.com> #4Sep 14, 2018 11:34PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

il...@google.com <il...@google.com> #5Dec 11, 2018 06:14PM

Marked as fixed.

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}