Destructively migrate on library downgrade [110416954]

Fixed

Feature Request

Status Update

No update yet.

Description

ku...@gmail.com

created issue #1

Jun 20, 2018 12:25AM

If I migrate my app from version n to version n + 1, the underlying database gets migrated too. If I then checkout a different branch or want to downgrade WorkManager later, there is no database migration path from n + 1 back to n.
It is preferable to have a destructive migration to crashing the app.

Comments

su...@google.com <su...@google.com> #2Jun 20, 2018 03:51PM

I was able to repro locally using the snippet in #1. The slide should never be applied to the content for state == 0, i.e. the green box.

Will take a look. Thanks for the repro steps, Jeremy.

ku...@gmail.com <ku...@gmail.com> #3Jun 20, 2018 04:57PM

I'm having an issue with Compose navigation-animation which might be caused by this.

I have two screens: List and Details.

List screen uses default transitions.

Details screen uses the following transitions:

enterTransition = {
    slideIntoContainer(
        AnimatedContentScope.SlideDirection.Up,
        animationSpec = tween(400)
    )
},
popExitTransition = {
    slideOutOfContainer(
        AnimatedContentScope.SlideDirection.Down,
        animationSpec = tween(200)
    )
},

The video is showing the bug vs expected. It's hard to describe: after clicking the back button before the transition to the Details screen was completed, the List screen moves up a little.

su...@google.com <su...@google.com> #4Jun 20, 2018 05:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7e3b52b20e73c397019f474ab15eb8ea64a872d3
Author: Doris Liu <tianliu@google.com>
Date: Thu Sep 29 18:06:42 2022

Fix incorrect interruption animation in AnimatedContent

Bug: 238662479

Test: included
Change-Id: I86bb98800070f4584e30a1d0a4edec274b0c7e5c

A compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/visualinspection/AnimatedContentWithInterruptions.kt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/AnimatedContentTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedContent.kt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimationDemos.kt

https://android-review.googlesource.com/2239235

yb...@google.com <yb...@google.com> #5Jun 20, 2018 09:12PM

Assigned to da...@google.com.

The following release(s) address this bug:

androidx.compose.animation:animation:1.4.0-alpha01

ia...@gmail.com <ia...@gmail.com> #6Jun 20, 2018 09:15PM

Why is this not released as a hotfix so stable users can get the bug fix right away?

yb...@google.com <yb...@google.com> #7Jun 20, 2018 10:54PM

He is mine just saying his time is my time

da...@google.com <da...@google.com> #8Jul 9, 2018 11:51PM

Marked as fixed.

This feature will be available in Room 2.1.0.