Support Serializable objects in Safe Args [111316353]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 10, 2018 09:35PM

Component used: Safe Args
Version used: 1.0.0-alpha02

As an expansion on

https://issuetracker.google.com/issues/79563966 and in the interest of completeness, Safe Args should also support Serializable objects.

Comments

ai...@gmail.com <ai...@gmail.com> #2Jul 13, 2018 01:57AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b55fe68edc02b253b908a1c7c2e98350ba67afe4
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 12 14:21:57 2020

Ignore Animations/Animator when Transitions run

For a given Fragment, a single owner for its
transition from visible to non-visible is needed
to avoid conflicts as different systems try to
influence the same set of properties.

This has two consequences:
- Animations (which work at the parent container level)
will interfere if there are *any* Transitions run.
- Animators will interfere if there are any Transitions
run on that specific Fragment.

By tracking which Transitions were started and using
that information to selectively ignore conflicting
Animations/Animators, we can avoid visual artifacts.

Test: updated tests pass
BUG: 149569323
Change-Id: I9e5169ffd36853c3dfbd7f217837a74674a9508d

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1398530

th...@gmail.com <th...@gmail.com> #3Jul 13, 2018 09:24AM

There are two parallel systems in Android - the Animation system and the Animator system (which the Transition system is built on top of). With this change and Fragment 1.3.0-alpha08, no Animation will run if there are any Transitions kicked off at the same time and no Animator will run on Fragments that have Transitions directly associated with them (either via an enter/exit transition or as part of a shared element transition).

ai...@gmail.com <ai...@gmail.com> #4Jul 13, 2018 10:38AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fa55358f7f2870bf05ef5cce12d2b4e2d86732aa
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 11:30:52 2020

Ignore Animations when Animators run

As a continuation of the work in

b/149569323

,
we now prioritize running Animators over running
Animations. This avoids cases where both are
running simultaneously.

As Animations and Animators are now properly
decoupled, we can use animator.cancel() when
our CancelationSignal is triggered instead of
using clearAnimation().

Test: all tests pass, updated FragmentAnimatorTest passes
BUG: 167579557
Change-Id: I7b3f5c1cc1355e02ff770838cb485d659dfb1619

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimatorTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1427449

wk...@google.com <wk...@google.com> Jul 20, 2018 02:59PM

Accepted by wk...@google.com.

ap...@google.com <ap...@google.com> #5Nov 19, 2018 07:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

wk...@google.com <wk...@google.com> Nov 26, 2018 08:58PM

Marked as fixed.

il...@google.com <il...@google.com> #6Nov 29, 2018 06:40PM

This is fixed internally and will be available in 1.0.0-alpha08

b9...@gmail.com <b9...@gmail.com> #7Apr 9, 2019 05:41PM

What happened if I declaire app:argType="androidx.navigation.test.TestEnum" and turn on proguard/R8? Because both ProGuard and R8 will optimize trivial enums into ints.

il...@google.com <il...@google.com> #8Apr 9, 2019 05:46PM

Since you need to explicitly keep argTypes as per

https://issuetracker.google.com/issues/122634648, they'll be kept.

b9...@gmail.com <b9...@gmail.com> #9Apr 9, 2019 06:31PM

Thanks. Just saw the latest documentation.