NavController.setGraph does not reset back stack [111450672]

Fixed

Bug

Status Update

No update yet.

Description

jf...@gmail.com

created issue #1

Jul 16, 2018 02:59AM

Library name: Navigation
Library version: 1.0.0-alpha03

When setting a new NavGraph to NavController, the back stack is not resetted.
From the documentation, "Any current navigation graph data will be replaced."
If a NavGraph is already setted then the back stack containts the default destination. In calling NavGraph.setGraph(NavGraph) and in the new graph, the destination is different, then the new destination is not displayed because back stack is not resetted.
Is it expected feature or not?

Comments

il...@google.com <il...@google.com> #2Jul 17, 2018 06:16PM

FWIW, I've created a PR on https://github.com/androidx/androidx/pull/636 with a regression test.

ha...@googlemail.com <ha...@googlemail.com> #3Jul 17, 2018 08:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit 812fe658e564bb57b0bea0ae79946d04e2b85610
Author: Simon Marquis <contact@simon-marquis.fr>
Date: Tue Dec 19 21:46:01 2023

[GH] Fix regression in dynamic labels with non-string typed arguments

Regression introduced in

https://github.com/androidx/androidx/commit/76f9009e6cfc1cba5314cad87a6f1923203c54fa Reported in

https://issuetracker.google.com/issues/316676794

Test: ./gradlew navigation:navigation-ui:cC
Fixes: 316676794

[AndroidX Navigation 2.6.0 broke dynamic app bar title for non String arguments](

https://issuetracker.google.com/issues/316676794)

This is an imported pull request from

https://github.com/androidx/androidx/pull/636.

Resolves #636
Github-Pr-Head-Sha: f455c6d1e641cc72cc1bd371b1f47b7d87ec8eff
GitOrigin-RevId: 3ad8f763f17acb22678f1a87e183ef4e7dac5a9d
Change-Id: I94b4e28bb847632663be32b11e481d13789e8c1b

M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-ui/src/androidTest/java/androidx/navigation/ui/NavigationUITest.kt

https://android-review.googlesource.com/2882895

il...@google.com <il...@google.com> #4Jul 23, 2018 11:04PM

Assigned to il...@google.com.

Thanks for pointing this out and putting up the PR to fix this! We'll look at doing a Navigation 2.7.7 release with this fix.

bo...@gmail.com <bo...@gmail.com> #5Sep 17, 2018 01:24PM

Awesome, thanks for the quick merge 😀

il...@google.com <il...@google.com> Jan 11, 2019 01:22AM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #6Jan 11, 2019 10:59PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-alpha01
androidx.navigation:navigation-ui:2.8.0-alpha01

lb...@gmail.com <lb...@gmail.com> #7Sep 6, 2024 10:29PM

I can confirm the issue reported here is fixed in 2.8.0-alpha01. Not sure why there is no mention of it in the release notes though. I should have added a RelNotes trailer to the git commit message, or can it be added afterwards?