Safe Args should also support Collections objects. [111487504]

Fixed

Feature Request

Status Update

No update yet.

Description

zy...@gmail.com

created issue #1

Jul 16, 2018 06:39PM

Component used:Safe Args
Version used:1.0.0-alpha03

Safe Args should also support Collections objects. Simple types will be enough for the first time. Thanks.

Comments

il...@google.com <il...@google.com> Jul 16, 2018 08:30PM

Assigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 20, 2018 02:59PM

Accepted by wk...@google.com.

ap...@google.com <ap...@google.com> #2Nov 19, 2018 07:02PM

Thanks for the report!

Could you please confirm for us which version of Compose is your project using? Does it happen if you change the version?

Relevant crash from device:

2022-07-05 03:42:05.712 13983-13983 DEBUG                   pid-13983                            A    NOTE: Function names and BuildId information is missing for some frames due
                                                                                                      NOTE: to unreadable libraries. For unwinds of apps, only shared libraries
                                                                                                      NOTE: found under the lib/ directory are readable.
                                                                                                      NOTE: On this device, run setenforce 0 to make the libraries readable.
                                                                                                      NOTE: Unreadable libraries:
                                                                                                      NOTE:   /data/data/com.app.work/cache/androidx.compose.ui-ui-1.2.0-rc03-inspector.jar_unpacked_lib/libcompose_inspection_jni.so
2022-07-05 03:42:05.712 13983-13983 DEBUG                   pid-13983                            A        #00 pc 000000000004b5bc  /apex/com.android.runtime/lib64/bionic/libc.so (__strncmp_aarch64+252) (BuildId: 058e3ec96fa600fb840a6a6956c6b64e)
2022-07-05 03:42:05.712 13983-13983 DEBUG                   pid-13983                            A        #01 pc 00000000000028f4  /data/data/com.app.work/cache/androidx.compose.ui-ui-1.2.0-rc03-inspector.jar_unpacked_lib/libcompose_inspection_jni.so (compose_inspection::analyzeLines(_jvmtiEnv*, int, _jvmtiLineNumberEntry*, int, _jvmtiLocalVariableEntry*, int*, int*)+160) (BuildId: 0990d56fd5c4090102a504def1e5a1657300399e)
2022-07-05 03:42:05.712 13983-13983 DEBUG                   pid-13983                            A        #02 pc 0000000000002eb4  /data/data/com.app.work/cache/androidx.compose.ui-ui-1.2.0-rc03-inspector.jar_unpacked_lib/libcompose_inspection_jni.so (compose_inspection::resolveLocation(_JNIEnv*, _jclass*)+840) (BuildId: 0990d56fd5c4090102a504def1e5a1657300399e)
2022-07-05 03:42:05.712 13983-13983 DEBUG                   pid-13983                            A        #03 pc 0000000000440154  /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+148) (BuildId: 5de55fd6e2a9191dd8c1362ea79ef5f6)
2022-07-05 03:42:05.712 13983-13983 DEBUG                   pid-13983                            A        #04 pc 000000000044049c  /apex/com.android.art/lib64/libart.so (BuildId: 5de55fd6e2a9191dd8c1362ea79ef5f6)
2022-07-05 03:42:05.730   771-771   tombstoned              tombstoned                           E  Tombstone written to: tombstone_09

il...@google.com <il...@google.com> Nov 27, 2018 12:43AM

Marked as fixed.

il...@google.com <il...@google.com> #3Nov 29, 2018 06:40PM

I can confirm same crash
composeVersion = '1.2.0-beta03'
+ these deps included
debugImplementation "androidx.compose.ui:ui-tooling:$composeVersion"
debugImplementation "androidx.compose.ui:ui-tooling-preview:$composeVersion"
debugImplementation "androidx.customview:customview:1.2.0-alpha01"
debugImplementation "androidx.customview:customview-poolingcontainer:1.0.0-rc01"

also tested 1.2.0-beta02, 1.3.0-alpha01 (with 1.2.0 composeCompiler)..., same crash

zy...@gmail.com <zy...@gmail.com> #4Nov 29, 2018 06:45PM

I was using Compose 1.2.0-rc03 and Compose Compiler 1.2.0. But this issue was present in previous versions (1.2.0-RCxx) of the compiler too.

Yesterday I was testing how it works with Compose 1.1.1 and Compose 1.3.0-alpha01. It seemed to be working better, I could inspect the app for 5-10 minutes until it crashed. However, fetching view atributes was really unreliable: sometimes instantaneous, other times with a huge delay or not it all. And I believe crashes are related to the attributes section.

Most of the crashes had these messages in the Logcat afterwards: (see the attached file)

Issue 111487504