Safe Args should also support Collections objects. [111487504]

Fixed

Feature Request

Status Update

No update yet.

Description

zy...@gmail.com

created issue #1

Jul 16, 2018 06:39PM

Component used:Safe Args
Version used:1.0.0-alpha03

Safe Args should also support Collections objects. Simple types will be enough for the first time. Thanks.

Comments

il...@google.com <il...@google.com> Jul 16, 2018 08:30PM

Assigned to wk...@google.com.

wk...@google.com <wk...@google.com> Jul 20, 2018 02:59PM

Accepted by wk...@google.com.

ap...@google.com <ap...@google.com> #2Nov 19, 2018 07:02PM

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

il...@google.com <il...@google.com> Nov 27, 2018 12:43AM

Marked as fixed.

il...@google.com <il...@google.com> #3Nov 29, 2018 06:40PM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

zy...@gmail.com <zy...@gmail.com> #4Nov 29, 2018 06:45PM

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

Issue 111487504