Fixed
Status Update
No update yet.
Comments
yb...@google.com
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d92e6ab2da02250bfbff957f733a4a2aaaf0c82c
Author: Ian Lake <ilake@google.com>
Date: Thu Jul 09 16:04:11 2020
Allow multiple destinations in NavDeepLinkBuilder
Expand the ability of NavDeepLinkBuilder to support
adding multiple destinations. This allows developers
to effectively build a custom synthetic back stack
that goes through multiple destinations in the same
graph or through destinations in separate graphs.
This augments, not replaces, the existing synthetic
back stack logic: the start destinations of any
graphs needed to make the chosen destination visible
*are* still added to the back stack.
To maintain behavior compatibility, setArguments()
continues to apply the arguments set there to all
destinations created by the deep link. However, this
CL would be first step to also supporting arguments
at a destination level.
Test: newly added tests pass
Relnote: "`NavDeepLinkBuilder` now supports adding
multiple distinct destinations to the generated
back stack."
BUG: 147913689
Change-Id: I3ee0d5251ec1047774aa4e826b25a6d8cf4ec28d
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.java
M navigation/navigation-common/src/test/java/androidx/navigation/NavDestinationTest.kt
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
https://android-review.googlesource.com/1359698
Branch: androidx-master-dev
commit d92e6ab2da02250bfbff957f733a4a2aaaf0c82c
Author: Ian Lake <ilake@google.com>
Date: Thu Jul 09 16:04:11 2020
Allow multiple destinations in NavDeepLinkBuilder
Expand the ability of NavDeepLinkBuilder to support
adding multiple destinations. This allows developers
to effectively build a custom synthetic back stack
that goes through multiple destinations in the same
graph or through destinations in separate graphs.
This augments, not replaces, the existing synthetic
back stack logic: the start destinations of any
graphs needed to make the chosen destination visible
*are* still added to the back stack.
To maintain behavior compatibility, setArguments()
continues to apply the arguments set there to all
destinations created by the deep link. However, this
CL would be first step to also supporting arguments
at a destination level.
Test: newly added tests pass
Relnote: "`NavDeepLinkBuilder` now supports adding
multiple distinct destinations to the generated
back stack."
BUG: 147913689
Change-Id: I3ee0d5251ec1047774aa4e826b25a6d8cf4ec28d
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.java
M navigation/navigation-common/src/test/java/androidx/navigation/NavDestinationTest.kt
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
he...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit cd8fc14c6f2ad77d563e726eb30aa36f324259d0
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 10 13:22:43 2020
Support per destination arguments in NavDeepLinkBuilder
In addition to continuing to support setArguments()
as a way to set global arguments that apply to all
destinations, add an optional Bundle parameter to
setDestination() and addDestination() to allow per
destination arguments.
Test: updated tests pass
BUG: 147913689
Relnote: "`NavDeepLinkBuilder` now allows you to set
arguments at a per destination level in addition to
the global arguments set via `setArguments()`."
Change-Id: I3a18cbb67b5836db013804a6d6c468cb0bc22102
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavDeepLinkBuilderTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
https://android-review.googlesource.com/1360905
Branch: androidx-master-dev
commit cd8fc14c6f2ad77d563e726eb30aa36f324259d0
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 10 13:22:43 2020
Support per destination arguments in NavDeepLinkBuilder
In addition to continuing to support setArguments()
as a way to set global arguments that apply to all
destinations, add an optional Bundle parameter to
setDestination() and addDestination() to allow per
destination arguments.
Test: updated tests pass
BUG: 147913689
Relnote: "`NavDeepLinkBuilder` now allows you to set
arguments at a per destination level in addition to
the global arguments set via `setArguments()`."
Change-Id: I3a18cbb67b5836db013804a6d6c468cb0bc22102
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavDeepLinkBuilderTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
Description
Version used:1.1.1
Devices/Android versions reproduced on: All
File: FrameworkSQLiteOpenHelper
FrameworkSQLiteDatabase getWrappedDb(SQLiteDatabase sqLiteDatabase) {
FrameworkSQLiteDatabase dbRef = mDbRef[0];
if (dbRef == null) {
dbRef = new FrameworkSQLiteDatabase(sqLiteDatabase);
mDbRef[0] = dbRef;
}
return mDbRef[0];
}
Room always preserve The First Open db, even if it is closed.
Sometimes sqLiteDatabase != mDbRef[0].mDelegate, we get the wrong db from room.
This occurs when opening db, then something wrong and throws exception, but app caught it. The next time we use room, it throws re-open exception.
I thinks mDbRef[0].mDelegate should change when sqLiteDatabase is changed.
Like this:
FrameworkSQLiteDatabase getWrappedDb(SQLiteDatabase sqLiteDatabase) {
FrameworkSQLiteDatabase dbRef = mDbRef[0];
if (dbRef == null || dbRef.isDatabaseChanged(sqLiteDatabase)) {
dbRef = new FrameworkSQLiteDatabase(sqLiteDatabase);
mDbRef[0] = dbRef;
}
return mDbRef[0];
}
File: FrameworkSQLiteDatabase
public boolean isDatabaseChanged(SQLiteDatabase db) {
return mDelegate != db;
}