IssueTracker

My guess is an AutoValue extension is what's needed here: http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in https://android.googlesource.com, and it doesn't seem to be inside https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!

Add autovalue support also means you can easily achieve parcelable by https://github.com/rharter/auto-value-parcel. Please consider support this.

AutoValue is really a handy way to ensure data integrity.

Please add AutoValue support. AutoValue is a Google library with really good benefits such as toString() , hashCode() , AutoValue.Builder , checks at creation time if @NonNull values are null, etc.

FWIW, issue 64206877 is not publicly accessible.

@Yigit: That appears to be a private ticket.  Any way we can have access to keep up with it?

Have any updates?

news?

Is there any update? This is huge for app that  absolutely enforces immutable entities.

SqlDelight has out of the box support for AutoValue.  Use it with SqlBrite and you've got *pretty good* parity with Room.  With the lack of movement on this ticket, I'd suggest at least taking a look at those if AutoValue is important to you.

Support on olways

Sorry this used to be higher priority but other features got in the way (and to be honest, androidX migration took a lot more time than we thought).

I want to make 1 thing clear though, Room does support immutable entities. One of the reasons why this ticket lost some priority is that it is specific to AutoValue, not immutability. If you are using Kotlin, data classes give you the same power and Room supports them properly. (hence, there is an easy way to achieve immutability w/ Room).

The issue in this one is that we don't have out of the box support to discover AutoValue builders.
We still plan to do this, sorry that it is taking longer than we initially communicated.

I'd like to piggy back onto this issue, because I've fun into a similar problem with immutability that does NOT involve autovalue. What I have found is either a bug or a missing feature, depending on your perspective.

Let's say I have a Kotlin data class with only `val` properties. I want to serialize this into my Room database, but I want to decorate it with a few other values, for example a timestamp so I know when it was last updated, and a userId because my database supports multiple users. Oh look! There's an annotation `@Embedded` that seems to do just want I want. I can create a new class specific to Room persistence, add the few new properties I want, and then "embed" the original object, and damn that was easy.

Oh no. Now my project won't compile. It seems that embedded objects must have public getters -- all my `val`s must now be `var`s. D:

Sigh. I guess I'll just write a new class that has _all_ the properties of the original, plus a few more, and write an extension function to transform from one to the other. Really glad Room saved me all that Sqlite boilerplate, so I now have time for Room-specific boilerplate ;-)

*public setters, not public getters

#17 seems like a bug, we are supposed to handle Embedded fields in constructor parameters.

Can you file a bug with a sample project ?

We do have a test for having embedded as a constructor parameter, so maybe something else is wrong.


from one of our tests:

    @Entity(tableName = "fc")
    static class FullConstructor {
        @PrimaryKey
        public final int a;
        public final int b;
        @Embedded
        public final MyEmbedded embedded;

        FullConstructor(int a, int b, MyEmbedded embedded) {
            this.a = a;
            this.b = b;
            this.embedded = embedded;
        }
    }

Sure, I'd be happy to put up a sample project. I'll try to pull something together later today or maybe tomorrow.

Well, I tried. Either I did something wrong the first time, or... I did something wrong the first time :shrug-emoji: Tried reproducing in a sample project, couldn't. Mystified, I tried again in my much more complex work project -- couldn't. So, I guess that's a good thing!

if added this feature will be good!

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8c2d348127161daaf624f77d80cb662e65e3af2a
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Fri Jul 13 15:18:42 2018

    Add support for using AutoValue classes as Pojos and Entities.
   
    Support using AutoValue generated classes as Pojos by processing the
    AutoValue_* generated class that contains fields and getter
    implementations.
   
    To support the AutoValue api @PrimaryKey and @ColumnInfo have been
    opened up to target methods. However, since we only want to allow their
    usage in methods to support AutoValue a new processing step was added
    that throws an error if it finds a method not implement by AutoValue
    with any of these two annotations.
   
    Note that Embedded and Relations are not yet supported.
   
    Bug: 62408420
    Test: ./gradlew :room:room-compiler:test \
          :room:integration-tests:testapp:cC \
          :room:integration-tests:autovaluetestapp:cC
    Change-Id: I782d6ec074776f7af7cae977848443f3311b1d87

M       app-toolkit/settings.gradle
M       buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M       room/common/src/main/java/androidx/room/ColumnInfo.java
M       room/common/src/main/java/androidx/room/PrimaryKey.java
M       room/compiler/build.gradle
M       room/compiler/src/main/kotlin/androidx/room/RoomProcessor.kt
A       room/compiler/src/main/kotlin/androidx/room/checker/AutoValueTargetChecker.kt
M       room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/EntityProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/PojoProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
A       room/compiler/src/main/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegate.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/Constructor.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/Warning.kt
M       room/compiler/src/main/kotlin/androidx/room/writer/FieldReadWriteWriter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/EntityProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
A       room/compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
A       room/compiler/src/test/kotlin/androidx/room/processor/checker/AutoValueTargetCheckerTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A       room/integration-tests/autovaluetestapp/.gitignore
A       room/integration-tests/autovaluetestapp/build.gradle
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/TestDatabase.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/ParcelableEntityDao.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PersonDao.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PetDao.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/ParcelableEntityDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PersonDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PetDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/TestDatabaseTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/EmbeddedAutoValue.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/ParcelableEntity.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Person.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Pet.java
A       room/integration-tests/autovaluetestapp/src/main/AndroidManifest.xml
M       settings.gradle

https://android-review.googlesource.com/720548
https://goto.google.com/android-sha1/8c2d348127161daaf624f77d80cb662e65e3af2a

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 038e674add5afddbb34371b9c1fda6885efbd7be
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Fri Jul 13 15:18:42 2018

    Add support for using AutoValue classes as Pojos and Entities.
   
    Support using AutoValue generated classes as Pojos by processing the
    AutoValue_* generated class that contains fields and getter
    implementations.
   
    To support the AutoValue api @PrimaryKey and @ColumnInfo have been
    opened up to target methods. However, since we only want to allow their
    usage in methods to support AutoValue a new processing step was added
    that throws an error if it finds a method not implement by AutoValue
    with any of these two annotations.
   
    Note that Embedded and Relations are not yet supported.
   
    Bug: 62408420
    Test: ./gradlew :room:room-compiler:test \
          :room:integration-tests:testapp:cC \
          :room:integration-tests:autovaluetestapp:cC
    Change-Id: Idce0b5934e0aa864117fc95e7d19a7edc2c94f9f

M       app-toolkit/settings.gradle
M       buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M       room/common/src/main/java/androidx/room/ColumnInfo.java
M       room/common/src/main/java/androidx/room/PrimaryKey.java
M       room/compiler/build.gradle
M       room/compiler/src/main/kotlin/androidx/room/RoomProcessor.kt
A       room/compiler/src/main/kotlin/androidx/room/checker/AutoValueTargetChecker.kt
M       room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/EntityProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/PojoProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
A       room/compiler/src/main/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegate.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/Constructor.kt
M       room/compiler/src/main/kotlin/androidx/room/vo/Warning.kt
M       room/compiler/src/main/kotlin/androidx/room/writer/FieldReadWriteWriter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/EntityProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
A       room/compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
A       room/compiler/src/test/kotlin/androidx/room/processor/checker/AutoValueTargetCheckerTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A       room/integration-tests/autovaluetestapp/.gitignore
A       room/integration-tests/autovaluetestapp/build.gradle
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/TestDatabase.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/ParcelableEntityDao.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PersonDao.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PetDao.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/ParcelableEntityDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PersonDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PetDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/TestDatabaseTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/EmbeddedAutoValue.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/ParcelableEntity.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Person.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Pet.java
A       room/integration-tests/autovaluetestapp/src/main/AndroidManifest.xml
M       settings.gradle

https://android-review.googlesource.com/720788
https://goto.google.com/android-sha1/038e674add5afddbb34371b9c1fda6885efbd7be

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b4e0fe5d54a89ce8ce9a852774892c498edd4508
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Mon Jul 23 19:51:46 2018

    Add support for @Embedded in AutoValue Pojos.
   
    Bug: 62408420
    Test: ./gradlew :room:integration-tests:autovaluetestapp:cC
    Change-Id: I4aa02aae022e4971a8708c4aba4cf9f3e90f65a5

M       room/common/src/main/java/androidx/room/Embedded.java
M       room/compiler/src/main/kotlin/androidx/room/checker/AutoValueTargetChecker.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/checker/AutoValueTargetCheckerTest.kt
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PersonDao.java
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PetDao.java
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PersonDaoTest.java
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PetDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/PersonAndCat.java
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Pet.java

https://android-review.googlesource.com/720896
https://goto.google.com/android-sha1/b4e0fe5d54a89ce8ce9a852774892c498edd4508

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0f55cbbe13e26294af67aca6bce0e13a960ae752
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Mon Jul 30 17:06:22 2018

    Add support for @Relation in AutoValue Pojos.
   
    Bug: 62408420
    Test: ./gradlew :room:integration-tests:autovaluetestapp:cC
    Change-Id: I7634ac388e328dca9c33f7ac422080b42b362ee0

M       room/common/src/main/java/androidx/room/Relation.java
M       room/compiler/src/main/kotlin/androidx/room/checker/AutoValueTargetChecker.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/checker/AutoValueTargetCheckerTest.kt
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PersonDao.java
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/dao/PetDao.java
M       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/test/PersonDaoTest.java
A       room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/PersonWithCats.java

https://android-review.googlesource.com/723664
https://goto.google.com/android-sha1/0f55cbbe13e26294af67aca6bce0e13a960ae752

This feature will be available in Room 2.1.0

Does this means it could be used only with AutoValue, and not with other code generators like Immutables https://immutables.github.io/ ?
In that case it's really limited.

Can you provide way to have static factory methods instead of constructors? Then we can use whatever code generator.
Like:

@RoomFactoryMethod
public static MyEntity create(int id, String name) {
    return ImmutableMyEntity.of(id, name);
}

Yes, this is specific to AutoValue (we also support regular java immutables and kotlin) as this solves the problem w/o any extra code on the developer side.
Having an entity factory method seems reasonable too as a future improvement.

Would it be possible to support the AutoValue Builder pattern? Currently the only supported pattern appears to require a create() method.

Your AutoValue class can have an @AutoValue.Builder along side with a create() method as shown here: https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Person.java. If you are asking for Room to solely support the Builder pattern without any create() method then please file a separate issue since that is not currently available.

This just have happened to a user. We use a unique work to download assets, that can be more than 100. We usually don't have issue but this time the user got:
Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:2013)
       at android.os.Parcel.readException(Parcel.java:1951)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:180)

Device Mi A1 with Android 8.1.0. WorkManager 1.0.0-alpha06

This is the code:
        val workers = assets.map { assetModel ->
            val data = Data.Builder()
                    .putString(ASSET_UUID, assetModel.uuid)
                    .putString(ASSET_URL, assetModel.url)
                    .putString(ASSET_VERSION, assetModel.version.toString())
                    .build()
            OneTimeWorkRequest.Builder(AssetDownloadWorker::class.java)
                    .setInputData(data)
                    .build()
        }

        val continuation = workManager?.beginUniqueWork(
                DOWNLOAD_WORK_NAME + mainUuid,
                ExistingWorkPolicy.KEEP,
                workers.toList())

#32: As noted earlier, this is fixed in newer versions of WorkManager.  Please update to the latest version.

Sorry, for the wrong report. Seems to work fine for me now.

We are using alpha08 and we are still getting this exception. We use the WorkManager to send events to our backend. So we can enque a lot of requests (more than 100) in a short period of time.

We don't know exactly how to reproduce this error but we see in crashlytics that two users are getting this issue lots of times. The date we have about this users and crashes:

User 1, 11 crashes: Android  7.1.1 Nubia NX591J
Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:1692)
       at android.os.Parcel.readException(Parcel.java:1637)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
       at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(SystemJobScheduler.java:126)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(SystemJobScheduler.java:95)
       at androidx.work.impl.Schedulers.schedule(Schedulers.java:99)
       at androidx.work.impl.utils.EnqueueRunnable.scheduleWorkInBackground(EnqueueRunnable.java:114)
       at androidx.work.impl.utils.EnqueueRunnable.run(EnqueueRunnable.java:86)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:761)

User 2, 17 crashes: Android 7.0 Asus X008D
Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:1691)
       at android.os.Parcel.readException(Parcel.java:1636)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
       at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(SystemJobScheduler.java:126)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(SystemJobScheduler.java:95)
       at androidx.work.impl.Schedulers.schedule(Schedulers.java:99)
       at androidx.work.impl.utils.EnqueueRunnable.scheduleWorkInBackground(EnqueueRunnable.java:114)
       at androidx.work.impl.utils.EnqueueRunnable.run(EnqueueRunnable.java:86)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:761)

Yeah.. a fix should be available in alpha09 shortly. The relevant issue is https://issuetracker.google.com/issues/115560696

This was happening on android.arch.work:work-runtime:1.0.0-alpha01

This is not still happening on version :1.0.0-alpha09

Hi, this still happening in 1.0.0-alpha09. Only devices with 7 and 8 versions of android are affected.

Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:1967)
       at android.os.Parcel.readException(Parcel.java:1905)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:180)
       at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:44)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(SystemJobScheduler.java:148)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(SystemJobScheduler.java:117)
       at androidx.work.impl.Schedulers.schedule(Schedulers.java:99)
       at androidx.work.impl.utils.EnqueueRunnable.scheduleWorkInBackground(EnqueueRunnable.java:114)
       at androidx.work.impl.utils.EnqueueRunnable.run(EnqueueRunnable.java:86)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
       at java.lang.Thread.run(Thread.java:764)

The code, that i used:

class App : MultiDexApplication() {
 
  override fun onCreate() {
    super.onCreate()
    Job.schedule()
  }
}

class Job(ctx: Context, params: WorkerParameters) : Worker(ctx, params) {

  override fun doWork(): Worker.Result {
    Log.d("-------------------Job is done!--------------------")
    return  Result.SUCCESS
  }

  companion object {
    private const val TAG = "my_job"

    fun schedule() {
      val workManager = WorkManager.getInstance()
      val work = PeriodicWorkRequest.Builder(Job::class.java, 1, DAYS).addTag(TAG).build()
      workManager.enqueueUniquePeriodicWork(TAG, KEEP, work)
    }
  }
}

In our case, seems that alpha-10 is not having this crash anymore. After four days in production no events have happened.

Ok I'm updated to alpha10, and watching for statistics now.

Updated to alpha10 and the crash persisted. Doesn't seem to be fixed, so reverting my app back to firebase jobdispatcher.

We had this problem on aplha08, aplha09 and now on alpha11. On alpha11 it is happening less than before, but there are still many crashes.

I'm removing WorkManager from our project and getting back to JobScheduler.

I can't believe that Google is not able to fix a base/core issue in this library for 11 versions straight, it is totally unusable with this bug.

Is there a way we can raise this ticket to someone more competent that is able to solve this problem???

Such a shame Google...

We have fixed all known issues around this. If you are still seeing this, feel free to send us a stacktrace and a sample app that reproduces the problem.

Sorry, I could not reproduce the issue myself. I lost a whole day trying to reproduce the issue and I could not do it, but it does not mean that the crash is not happening.

On 50K users using the app (with alpha11 library), we see that around 0.1% (50) of them have these crashes. It only happens on Android version 7 and 8.

We had a bigger crash rate before upgrading to alpha11, but the bug is still happening.

The only traces I have are these from Fabric:

Android 7
Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:1701)
       at android.os.Parcel.readException(Parcel.java:1646)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
       at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(Unknown Source:148)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(Unknown Source:117)
       at androidx.work.impl.Schedulers.schedule(Unknown Source:99)
       at androidx.work.impl.WorkManagerImpl.rescheduleEligibleWork(Unknown Source:550)
       at androidx.work.impl.utils.ForceStopRunnable.run(Unknown Source:74)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:762)
           
           
Android 7  
Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:1691)
       at android.os.Parcel.readException(Parcel.java:1636)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
       at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(Unknown Source:148)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(Unknown Source:117)
       at androidx.work.impl.Schedulers.schedule(Unknown Source:99)
       at androidx.work.impl.WorkManagerImpl.rescheduleEligibleWork(Unknown Source:550)
       at androidx.work.impl.utils.ForceStopRunnable.run(Unknown Source:74)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:761)
           
           
Android 8
Fatal Exception: java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
       at android.os.Parcel.readException(Parcel.java:1975)
       at android.os.Parcel.readException(Parcel.java:1913)
       at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:180)
       at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:44)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(Unknown Source:148)
       at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(Unknown Source:117)
       at androidx.work.impl.Schedulers.schedule(Unknown Source:99)
       at androidx.work.impl.WorkManagerImpl.rescheduleEligibleWork(Unknown Source:550)
       at androidx.work.impl.utils.ForceStopRunnable.run(Unknown Source:74)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
       at java.lang.Thread.run(Thread.java:764)

           
It is happening on a wide range of devices (some of them):

Samsung Galaxy S7 (herolte),
Samsung Galaxy S7 (heroltebmc), Android 7.0
Samsung Galaxy Note5 (noblelte), Android 7.0
Samsung Galaxy S6 (zeroflte), Android 7.0
Samsung Galaxy S7 edge (hero2lte), Android 8.0
Motorola Moto G (5th Gen) (cedric), Android 8.1
Motorola Moto G(4) Plus (athene_f), Android 7.0
LGE V20 (elsa), Android 8.0
LGE LG K20 (lv517n), Android 7.0
dream2qltesq, Android 7.0
Huawei 荣耀畅玩 6X (HWBLN-H), Android 7.0
Sony Xperia Z5 (SO-01H), Android 7.0
Sony Xperia XZ Premium (SO-04J), Android 8.0

I think what might be happening is that some of the already scheduled jobs, may be stuck in a certain state.
You might want to push an update on the next version of your app, where you can cancelAllWork(), and reschedule all the Workers you need.

I have tried with cancelAllWorkByTag using the tag we used to create the jobs in the newest staged release but it did not help. We are still seeing the same crashes. We have also updated the lib to the latest (beta01) version.

cancelAllWorkByTag() only cancels work with tag.To be sure, you could cancelAllWork() [https://developer.android.com/reference/androidx/work/WorkManager.html#cancelAllWork()]
That way you are guaranteed to start from a clean slate, and then you can reschedule your work. Also, are you using a custom configuration when instantiating WorkManager ?

Yes, but we used a static constant in NotificationWorker.class to initialize it and used the same constant to cancel the work, so all workers should be stopped.

Here is the code:

        WorkManager.getInstance().cancelAllWorkByTag(NotificationWorker.TAG);

        PeriodicWorkRequest.Builder notificationsWorkBuilder = new PeriodicWorkRequest.Builder(NotificationWorker.class, NOTIFICATIONS_PERIOD, TimeUnit.MILLISECONDS);
        notificationsWorkBuilder.addTag(NotificationWorker.TAG);
        PeriodicWorkRequest notificationWork = notificationsWorkBuilder.build();
        WorkManager.getInstance().enqueueUniquePeriodicWork(NotificationWorker.TAG, ExistingPeriodicWorkPolicy.REPLACE, notificationWork);

If that is the only worker, then you are good. If there are other workers with other tags involved then using cancelAllWork() is what I would recommend.
Just to ensure that you are starting from a clean slate I would also try and call https://developer.android.com/reference/android/app/job/JobScheduler#cancelAll(), and reschedule work.

Yes, this is the only worker.  In the latest build I've added the cancelAllWork() call just to be sure that all work is cancelled (even we don't have more workers), but since we had a lot of crashes, I wasn't allowed to "play" anymore with WorkManager and we replaced it with JobScheduler for API23+ devices.

Hello,

We recently launched an update that includes "androidx.work:work-runtime:2.0.1", and we used it to schedule all our tasks now, in a satisfactory way. I just want to inform, (as you can see in the images attached below), that this problem keeps happening sporadically.

Keep in mind that the number of users affected in our case is small, since the app has several million active users, but it also starts to be worrisome, since the number of errors generated by each user is high.

The errors mainly occur in Android 6 and 7, and sometimes in 8, but especially in Android 7.

I do not expose implementation details, since the documentation of this SDK has been thoroughly studied, and in case there was a bad implementation, the number of errors would be infinitely greater.

Greetings.

We are having the same issue as in #52, (lots of crashes from small number of users) on WorkManager 1.0.1

Can you please add your notes to this bug report going forward.

https://issuetracker.google.com/issues/134058261

This bug report talks about this crash in the 1.x alpha era. So I just want to disambiguate the problem.

Updated workmanager from 1.0.0-beta02 to 1.0.1, as you recommended before, this should fix an issue.
Total crash count is raised drasticly, here we have stats for 40000 devices with 1.0.1 workmanager version: This issue has 46707 crashes affecting 347 users

Hi, unfortunately you're dealing with ~6 month old versions at this point.  You should upgrade to the latest version (2.2) - we won't be diagnosing issues on older versions anymore.

Hi, we're facing this issue too, also with v1.0.1.

We're using WorkManager#enqueue(OneTimeWorkRequest), instead of WorkManager#beginUniqueWork(OneTimeWorkRequest).

Upgrading to v2.x as you suggest forces us to migrate to Android X too. On v2.x I didn't see anything related in the changelog to justify the migration to Android X.. how can I be sure that migrating both Android X and work-runtime v2.x is gonna fix our issues?

Currently it's happening only in Android 7 (API 24), mainly in Motorola phones (70% Moto C Plus: https://www.gsmarena.com/motorola_moto_c_plus-8646.php)..

Thank you, regards!

We made a lot of improvements in 2.X apart from the AndroidX migrations. This problem should go away when you switch to WorkManager 2.2.0. We recommend updating to the latest version asap.

This is a bug.

the same problem continues to appear in androidx.work:work-runtime:2.0.1

androidx.work:work-runtime-ktx 2.5.0

Fatal Exception: java.lang.IllegalStateException
JobScheduler 100 job limit exceeded. We count 0 WorkManager jobs in JobScheduler; we have 1 tracked jobs in our DB; our Configuration limit is 20.
androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal (SystemJobScheduler.java:204)
androidx.work.impl.background.systemjob.SystemJobScheduler.schedule (SystemJobScheduler.java:132)
androidx.work.impl.Schedulers.schedule (Schedulers.java:108)
androidx.work.impl.utils.ForceStopRunnable.forceStopRunnable (ForceStopRunnable.java:176)
androidx.work.impl.utils.ForceStopRunnable.run (ForceStopRunnable.java:102)
androidx.work.impl.utils.SerialExecutor$Task.run (SerialExecutor.java:91)
java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
java.lang.Thread.run (Thread.java:764)
Caused by java.lang.IllegalStateException
Apps may not schedule more than 100 distinct jobs
android.os.Parcel.createException (Parcel.java:1958)
android.os.Parcel.readException (Parcel.java:1918)
android.os.Parcel.readException (Parcel.java:1868)
android.app.job.IJobScheduler$Stub$Proxy.schedule (IJobScheduler.java:184)
android.app.JobSchedulerImpl.schedule (JobSchedulerImpl.java:44)
androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal (SystemJobScheduler.java:186)
androidx.work.impl.background.systemjob.SystemJobScheduler.schedule (SystemJobScheduler.java:132)
androidx.work.impl.Schedulers.schedule (Schedulers.java:108)
androidx.work.impl.utils.ForceStopRunnable.forceStopRunnable (ForceStopRunnable.java:176)
androidx.work.impl.utils.ForceStopRunnable.run (ForceStopRunnable.java:102)
androidx.work.impl.utils.SerialExecutor$Task.run (SerialExecutor.java:91)
java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
java.lang.Thread.run (Thread.java:764)