Verified
Status Update
Comments
ad...@google.com <ad...@google.com> #2
This has been fixed internally in https://android-review.googlesource.com/870975 and will be available in Navigation 1.0.0-alpha10.
Now, instead of crashing, we ignore invalid deep links, printing a log message saying as much.
Now, instead of crashing, we ignore invalid deep links, printing a log message saying as much.
cc...@google.com <cc...@google.com> #3
Hi team.
The problem still occurs on version 2.2.0-rc04
The problem still occurs on version 2.2.0-rc04
rh...@abc.net.au <rh...@abc.net.au> #4
Hi, still getting crash for 2.1.0
cc...@google.com <cc...@google.com> #5
still getting crash on version 2.2.0
Description
Version used: 27.1.1
Theme used: N/A
Devices/Android versions reproduced on: Any
Regarding the check at the top of `submitList` here:
```
if (newList == mList) {
// nothing to do
return;
}
```
There's a race condition -- suppose we have lists A and B, and the differ's `mList` before starting is list A.
1. Submit list B - async diff generation N kicks off
2. Submit list A - `newList` matches `mList` since diff gen N hasn't completed yet, but `mMaxScheduledGeneration` is not incremented and this returns early
3. Async diff gen N is accepted, despite list A being submitted after list B.
Seems this could be fixed by incrementing `mMaxScheduledGeneration`. As a workaround, I am wrapping my lists in a new identity before submitting them to the differ.