Verified
Status Update
Comments
cc...@google.com <cc...@google.com> #2
This is definitely on our radar and there are plans to support it coming soon. We'll keep you updated on this bug.
cc...@google.com <cc...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 65e1ddf3b22249241c496890510071648bdff904
Author: Sumir Kataria <sumir@google.com>
Date: Mon Apr 01 16:33:01 2019
On-demand initialization for WorkManager.
This CL introduces WorkManager#getInstance(Context) as the preferred
method and deprecates the argument-less version. This method performs
on-demand initialization of WorkManager if it hasn't been initialized
previously by looking to see if the application Context implements
Configuration.Provider and querying it for the Configuration.
The exact order of initialization checks are now as follows:
1. Through WorkManagerInitializer if it's enabled.
2. Otherwise, through a WorkManager#initialize in Application#onCreate
or ContentProvider#onCreate if specified by the developer.
3. Otherwise, through WorkManager#getInstance(Context) if the
application Context implements Configuration.Provider. Using
WorkManager#getInstance() at this point results in an exception as
it does not contain the necessary information to initialize.
4. Otherwise, throws an IllegalStateException.
This change allows WorkManager to be setup in a manner where you can
only allow it to be initialized when it is needed. This is good for
apps that care about the critical path initialization needed by
WorkManager; in addition, all of WorkManager's own BroadcastReceivers
and Services are set up to try to auto-initialize if needed. Note
that this initialization can still happen on the main thread.
Bug: 127497100
Test: Ran integration tests with integration app doing on-demand init.
Change-Id: I30930d6445c0e9c5f08eaaab554963aaac99b3c9
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RecursiveWorker.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RetryActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/TestApplication.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/imageprocessing/ImageProcessingActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/sherlockholmes/AnalyzeSherlockHolmesActivity.java
M work/workmanager-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmService.java
M work/workmanager-testing/api/2.1.0-alpha01.txt
M work/workmanager-testing/api/current.txt
M work/workmanager-testing/src/androidTest/java/androidx/work/testing/TestSchedulerTest.java
M work/workmanager-testing/src/androidTest/java/androidx/work/testing/WorkManagerInitHelperTest.java
M work/workmanager-testing/src/main/java/androidx/work/testing/TestScheduler.java
M work/workmanager-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/workmanager-testing/src/main/java/androidx/work/testing/WorkManagerTestInitHelper.java
M work/workmanager-testing/src/main/java/androidx/work/testing/package-info.java
M work/workmanager-testing/src/test/java/androidx/work/testing/RobolectricSmokeTest.java
M work/workmanager/api/2.1.0-alpha01.txt
M work/workmanager/api/current.txt
M work/workmanager/src/androidTest/java/androidx/work/impl/background/systemjob/SystemJobServiceTest.java
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/WorkManager.java
M work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/RescheduleReceiver.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/workmanager/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
https://android-review.googlesource.com/937085
https://goto.google.com/android-sha1/65e1ddf3b22249241c496890510071648bdff904
Branch: androidx-master-dev
commit 65e1ddf3b22249241c496890510071648bdff904
Author: Sumir Kataria <sumir@google.com>
Date: Mon Apr 01 16:33:01 2019
On-demand initialization for WorkManager.
This CL introduces WorkManager#getInstance(Context) as the preferred
method and deprecates the argument-less version. This method performs
on-demand initialization of WorkManager if it hasn't been initialized
previously by looking to see if the application Context implements
Configuration.Provider and querying it for the Configuration.
The exact order of initialization checks are now as follows:
1. Through WorkManagerInitializer if it's enabled.
2. Otherwise, through a WorkManager#initialize in Application#onCreate
or ContentProvider#onCreate if specified by the developer.
3. Otherwise, through WorkManager#getInstance(Context) if the
application Context implements Configuration.Provider. Using
WorkManager#getInstance() at this point results in an exception as
it does not contain the necessary information to initialize.
4. Otherwise, throws an IllegalStateException.
This change allows WorkManager to be setup in a manner where you can
only allow it to be initialized when it is needed. This is good for
apps that care about the critical path initialization needed by
WorkManager; in addition, all of WorkManager's own BroadcastReceivers
and Services are set up to try to auto-initialize if needed. Note
that this initialization can still happen on the main thread.
Bug: 127497100
Test: Ran integration tests with integration app doing on-demand init.
Change-Id: I30930d6445c0e9c5f08eaaab554963aaac99b3c9
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RecursiveWorker.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RetryActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/TestApplication.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/imageprocessing/ImageProcessingActivity.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/sherlockholmes/AnalyzeSherlockHolmesActivity.java
M work/workmanager-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmService.java
M work/workmanager-testing/api/2.1.0-alpha01.txt
M work/workmanager-testing/api/current.txt
M work/workmanager-testing/src/androidTest/java/androidx/work/testing/TestSchedulerTest.java
M work/workmanager-testing/src/androidTest/java/androidx/work/testing/WorkManagerInitHelperTest.java
M work/workmanager-testing/src/main/java/androidx/work/testing/TestScheduler.java
M work/workmanager-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/workmanager-testing/src/main/java/androidx/work/testing/WorkManagerTestInitHelper.java
M work/workmanager-testing/src/main/java/androidx/work/testing/package-info.java
M work/workmanager-testing/src/test/java/androidx/work/testing/RobolectricSmokeTest.java
M work/workmanager/api/2.1.0-alpha01.txt
M work/workmanager/api/current.txt
M work/workmanager/src/androidTest/java/androidx/work/impl/background/systemjob/SystemJobServiceTest.java
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/WorkManager.java
M work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/RescheduleReceiver.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/workmanager/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
cc...@google.com <cc...@google.com> #4
Thanks for the fix! Is there any information about when this can be released to production?
Description