Fixed
Status Update
No update yet.
Comments
wk...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7b17505c2e3679330cf386efe69f1aa95b6ae9e9
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 06 14:47:42 2022
Update safeArgs to AGP 7.0.4
Updating safeArgs to depend on AGP 7.0.4.
Removing the use of reflection from the plugin since we no longer
needed.
RelNote: "Safe Args now depends on Android Gradle Plugin version 7.0.4.
This means that Navigation Safe Args will no longer be compatible with
Android Studio versions prior to 7.0."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 213086135
Bug: 207670704
Change-Id: I41c88ee06ad827c61cb1bbdc5ba58b3d56155caf
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1940534
Branch: androidx-main
commit 7b17505c2e3679330cf386efe69f1aa95b6ae9e9
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 06 14:47:42 2022
Update safeArgs to AGP 7.0.4
Updating safeArgs to depend on AGP 7.0.4.
Removing the use of reflection from the plugin since we no longer
needed.
RelNote: "Safe Args now depends on Android Gradle Plugin version 7.0.4.
This means that Navigation Safe Args will no longer be compatible with
Android Studio versions prior to 7.0."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 213086135
Bug: 207670704
Change-Id: I41c88ee06ad827c61cb1bbdc5ba58b3d56155caf
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
il...@google.com
Do you know if I can try this out in a snapshot or has it been published under a version name? (sorry, things in gerrit still confuse me so maybe its already clear that this is fixed and shipped!)
Description
Navigation Arch component and Safe Args Plugin versions 1.0.0-alpha02, 1.0.0-alpha04
Device: Samsung Galaxy S6
I have an argument for activity or fragment when using Navigation Arch component
<argument
android:name="EXTRA_INTEGER"
app:argType="reference"
android:defaultValue="@integer/integer_value"/>
where @integer/integer_value is: <item name="integer_value" format="integer" type="integer">-1</item>
When it navigates with code:
NavHostFragment.findNavController(this).navigate(R.id.action_openFragment)
the value of arguments or intent extra becomes equal -1 (arguments.getInt("EXTRA_INTEGER") or intent.getIntExtra("EXTRA_INTEGER"))
When I use Safe Args plugin generated class
NavHostFragment.findNavController(this).navigate(MyFragmentDirections.actionOpenFragment())
it turns out to be equal reference itself (e.g. 2131296267)
It is an inconsistent behavior and should be fixed in one or another way