Fixed
Status Update
No update yet.
Comments
se...@google.com
Could we get an official response to this feature request? Is there an idea to support SafeArgs in navigation-compose one day? Not asking for any time frames. Maybe there is no plans for statically generated args for navigation-compose at all.
au...@gmail.com
Please check out my implementation of the same-
Part 1-https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-95c84722eec2
Part 2-https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-2-218a6ae7a027
Github repo-https://github.com/dilrajsingh1997/safe-compose-args
Part 1-
Part 2-
Github repo-
il...@google.com
il...@google.com
fa...@gmail.com
+1
ko...@gmail.com
this library make it super easy if can you support this on the native way
Description
Navigation
Version used:
1.0.0-alpha04
Devices/Android versions reproduced on:
All
Steps to reproduce:
- Create multiple fragments with separate Toolbars. Lets Say A and B
- Move from A -> B and use NavigationUI.setupWithNavController(fragmentBToolbar, nav)
- Go back to A. Layout of fragment B is leaked forever.
Problem:
With every call
navController.addOnNavigatedListener(new NavigationUI.ToolbarOnNavigatedListener(toolbar, drawerLayout));
new listener is added to navController with hard reference to Toolbar view. And ToolbarView has reference to its parent View (fragments View). And never cleared