NavigationUI.setupWithNavController going to leak views if used multiple time with toolbar/collapsingToolbarLayout [111961977]

Fixed

Bug

Status Update

No update yet.

Description

au...@gmail.com

created issue #1

Jul 30, 2018 03:30PM

Component used:
Navigation
Version used:
1.0.0-alpha04
Devices/Android versions reproduced on:
All

Steps to reproduce:
- Create multiple fragments with separate Toolbars. Lets Say A and B
- Move from A -> B and use NavigationUI.setupWithNavController(fragmentBToolbar, nav)
- Go back to A. Layout of fragment B is leaked forever.

Problem:
With every call
navController.addOnNavigatedListener(new NavigationUI.ToolbarOnNavigatedListener(toolbar, drawerLayout));
new listener is added to navController with hard reference to Toolbar view. And ToolbarView has reference to its parent View (fragments View). And never cleared

Comments

se...@google.com <se...@google.com> #2Jul 30, 2018 11:32PM

Assigned to il...@google.com.

The removal of the nested graphs and using popUpTo the given fragment appears to prevent the crash from happening in 1.0.0-alpha11.

au...@gmail.com <au...@gmail.com> #3Aug 3, 2018 08:00AM

Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev

commit 63bc1ff1fe7c348138295ee7efb8cdc2999622c0
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:18:53 2019

Update prebuilts for Navigation 1.0.0-beta01

Include fix for

b/123803044

Test: ./gradlew bOS
Change-Id: Icb2a50975541a7bd3327054c72a591c7689c9741

M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.sha1

https://android-review.googlesource.com/892878

https://goto.google.com/android-sha1/63bc1ff1fe7c348138295ee7efb8cdc2999622c0

il...@google.com <il...@google.com> Aug 15, 2018 11:07PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Aug 16, 2018 05:00PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019

Return true when popping from FragmentNavigator

Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().

This ensures that the FragmentManager state and the
NavController states don't get out of sync.

Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/892996

https://goto.google.com/android-sha1/c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec

il...@google.com <il...@google.com> Aug 16, 2018 05:03PM

Marked as fixed.

fa...@gmail.com <fa...@gmail.com> #5Oct 23, 2022 11:13AM

This is actually an issue where the NavController's back stack state is going out of sync with the FragmentManager / FragmentNavigator's state. This has been fixed and will be available in the next release.

ko...@gmail.com <ko...@gmail.com> #6Oct 9, 2023 09:39AM

Nice job! A quick response!

Message last modified on Dec 20, 2023 11:17AM