NavigationUI.setupWithNavController going to leak views if used multiple time with toolbar/collapsingToolbarLayout [111961977]

Fixed

Bug

Status Update

No update yet.

Description

au...@gmail.com

created issue #1

Jul 30, 2018 03:30PM

Component used:
Navigation
Version used:
1.0.0-alpha04
Devices/Android versions reproduced on:
All

Steps to reproduce:
- Create multiple fragments with separate Toolbars. Lets Say A and B
- Move from A -> B and use NavigationUI.setupWithNavController(fragmentBToolbar, nav)
- Go back to A. Layout of fragment B is leaked forever.

Problem:
With every call
navController.addOnNavigatedListener(new NavigationUI.ToolbarOnNavigatedListener(toolbar, drawerLayout));
new listener is added to navController with hard reference to Toolbar view. And ToolbarView has reference to its parent View (fragments View). And never cleared

Comments

se...@google.com <se...@google.com> #2Jul 30, 2018 11:32PM

Assigned to il...@google.com.

Great

au...@gmail.com <au...@gmail.com> #3Aug 3, 2018 08:00AM

Project: platform/frameworks/support
Branch: androidx-main

commit a735aaa4d06c90454de772fae5a02f6cbde210b3
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 28 22:58:23 2023

Ensure FragmentNavigator destroys intermediate entries on popUpTo

We need to make sure that when Fragment are destroyed their entries are
also always destroyed.

RelNote: "Fixes a regressions in previous release that caused the wrong
BottomNav menu item to be highlighted when using system back to go
between tabs."
Test: Added FragmentNavigatorTest
Bug: 270447657

Change-Id: I634f6047b7016bcb8b690047605a6f66b2dc1438

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2461556

il...@google.com <il...@google.com> Aug 15, 2018 11:07PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Aug 16, 2018 05:00PM

This has been fixed internally and will be available in the Navigation 2.6.0-alpha07 release.

il...@google.com <il...@google.com> Aug 16, 2018 05:03PM

Marked as fixed.

fa...@gmail.com <fa...@gmail.com> #5Oct 23, 2022 11:13AM

Project: platform/frameworks/support
Branch: androidx-main

commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023

Add FragmentNavigator test to assert entry destroyed

Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.

Asserts that the fix on this bug also fixes

b/270610768

.

Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt

https://android-review.googlesource.com/2464422

ko...@gmail.com <ko...@gmail.com> #6Oct 9, 2023 09:39AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

Message last modified on Dec 20, 2023 11:17AM