Fixed
Status Update
No update yet.
Comments
se...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 44991c9a6f7d832decb7a19b9d795f8644bc8503
Author: jbwoods <jbwoods@google.com>
Date: Fri Mar 15 10:58:23 2019
Add NavDirections overload for createOnClickListener in Navigation
Gives developers the convenient option of just passing navDirections to
createOnClickListener instead of manually exactings the ActionID and
Bundle.
Test: ./gradlew checkApi
BUG: 127631752
Change-Id: Icfc3762570ccf5efac83afc0375cbdb8c0acee11
M navigation/runtime/api/2.1.0-alpha01.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/Navigation.java
https://android-review.googlesource.com/930453
https://goto.google.com/android-sha1/44991c9a6f7d832decb7a19b9d795f8644bc8503
Branch: androidx-master-dev
commit 44991c9a6f7d832decb7a19b9d795f8644bc8503
Author: jbwoods <jbwoods@google.com>
Date: Fri Mar 15 10:58:23 2019
Add NavDirections overload for createOnClickListener in Navigation
Gives developers the convenient option of just passing navDirections to
createOnClickListener instead of manually exactings the ActionID and
Bundle.
Test: ./gradlew checkApi
BUG: 127631752
Change-Id: Icfc3762570ccf5efac83afc0375cbdb8c0acee11
M navigation/runtime/api/2.1.0-alpha01.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/Navigation.java
au...@gmail.com
This has been added internally and will be available in Navigation 2.1.0-alpha01
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d87596efaefed2570133a883d7c304e9ea95e7a8
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 15 16:04:39 2018
Use WeakReferences in NavigationUI
Avoid storing a strong reference to views
(such as a Toolbar within a Fragment) in
OnNavigatedListeners created by
NavigationUI.
NavigationUI makes an effort to clean up
after itself by removing the
OnNavigatedListener if one of its
WeakReferences was garbage collected.
Test: ran the integration test app
BUG: 111961977
Change-Id: Iea466591cc77e79b3b056108d2818afe22d1ddc6
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
https://android-review.googlesource.com/732894
https://goto.google.com/android-sha1/d87596efaefed2570133a883d7c304e9ea95e7a8
Branch: androidx-master-dev
commit d87596efaefed2570133a883d7c304e9ea95e7a8
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 15 16:04:39 2018
Use WeakReferences in NavigationUI
Avoid storing a strong reference to views
(such as a Toolbar within a Fragment) in
OnNavigatedListeners created by
NavigationUI.
NavigationUI makes an effort to clean up
after itself by removing the
OnNavigatedListener if one of its
WeakReferences was garbage collected.
Test: ran the integration test app
BUG: 111961977
Change-Id: Iea466591cc77e79b3b056108d2818afe22d1ddc6
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
il...@google.com
ko...@gmail.com
yes i tested it on
Description
Navigation
Version used:
1.0.0-alpha04
Devices/Android versions reproduced on:
All
Steps to reproduce:
- Create multiple fragments with separate Toolbars. Lets Say A and B
- Move from A -> B and use NavigationUI.setupWithNavController(fragmentBToolbar, nav)
- Go back to A. Layout of fragment B is leaked forever.
Problem:
With every call
navController.addOnNavigatedListener(new NavigationUI.ToolbarOnNavigatedListener(toolbar, drawerLayout));
new listener is added to navController with hard reference to Toolbar view. And ToolbarView has reference to its parent View (fragments View). And never cleared