Support Gradle incremental annotation processing [112110217]

Fixed

Feature Request

Status Update

No update yet.

Description

da...@google.com

created issue #1

Aug 1, 2018 11:57PM

See:

https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing

Comments

da...@google.com <da...@google.com> #2Mar 15, 2019 05:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1b9ae441be4de3443b138e789c85722bba29c356
Author: Clara F <clarafok@google.com>
Date: Mon Mar 14 15:26:56 2022

[GH] Add room-paging-guava module to Room

Create module for integrating Guava into Room Paging

Test: n/a
Bug: 203666906

This is an imported pull request from

https://github.com/androidx/androidx/pull/337.

Resolves #337

Relnote: "Added a new artifact, room-paging-guava, for ListenableFuturePagingSource in
room-paging."

Github-Pr-Head-Sha: f62df108d6d5dd765c43b1e75472ddd0a097f9de
GitOrigin-RevId: 8c86aaa8e3a856614cbdccabe07c0d658efb0407
Change-Id: Ie14a1beef5d3b7ba07f3acc3fdd1f7bfc6fd1b9e

A room/room-paging-guava/src/androidTest/AndroidManifest.xml
A room/room-paging-guava/api/public_plus_experimental_current.txt
M settings.gradle
M docs-tip-of-tree/build.gradle
A room/room-paging-guava/api/restricted_current.txt
A room/room-paging-guava/api/res-current.txt
A room/room-paging-guava/src/main/AndroidManifest.xml
A room/room-paging-guava/api/current.txt
A room/room-paging-guava/build.gradle

https://android-review.googlesource.com/2025245

to...@gmail.com <to...@gmail.com> #3Apr 12, 2019 09:13AM

Project: platform/frameworks/support
Branch: androidx-main

commit eb60980fbbeb3a9d824e721969a54db902c44857
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:08:03 2022

[GH] Add room-paging-rxjava3 module to Room

Test: n/a
Bug: 203666906
Relnote: Integrating rxjava3 support in Room Paging

This is an imported pull request from

https://github.com/androidx/androidx/pull/339.

Resolves #339
Github-Pr-Head-Sha: 274be4dcfc6f40861b476638c9671503e28129d4
GitOrigin-RevId: f081e641921b7dd64f1bba5800b4395074f902e1

Change-Id: I00d8884025aa4263a96dc509ccb8e303b53beeb8

M settings.gradle
A room/room-paging-rxjava3/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava3/api/restricted_current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava3/api/current.txt
A room/room-paging-rxjava3/build.gradle
A room/room-paging-rxjava3/src/main/AndroidManifest.xml
A room/room-paging-rxjava3/api/public_plus_experimental_current.txt
A room/room-paging-rxjava3/api/res-current.txt

https://android-review.googlesource.com/2027363

se...@gmail.com <se...@gmail.com> #4Apr 12, 2019 09:16AM

Project: platform/frameworks/support
Branch: androidx-main

commit 41a1d4f8677c57db934d37bb0cd8db9d3f3aae6c
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:10:36 2022

[GH] Add room-paging-rxjava2 module to Room

Test: n/a
Bug: 203666906
Relnote: "Added new artifact room-paging-rxjava2 for rxjava2 support in Room Paging"

This is an imported pull request from

https://github.com/androidx/androidx/pull/338.

Resolves #338
Github-Pr-Head-Sha: f8c5c6f04217e43bbc4a78b9715deb920b830fa3
GitOrigin-RevId: 1dbf1e202286c42fc34c89a808d8c421fa1303af

Change-Id: I88f076392f1917c2fec52d3bd58d91e73b12a53b

A room/room-paging-rxjava2/api/current.txt
A room/room-paging-rxjava2/api/restricted_current.txt
M settings.gradle
A room/room-paging-rxjava2/api/res-current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava2/src/main/AndroidManifest.xml
A room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava2/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2027364

to...@gmail.com <to...@gmail.com> #5May 21, 2019 01:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2f45502b3d448965f0e52067e8b39108708d1faf
Author: clarafok <clarafok@google.com>
Date: Mon Apr 11 15:50:07 2022

Implement LimitOffsetListenableFuturePagingSource

An abstract implementation of ListenableFuturePagingSource to be
implemented by Room. Supports Guava operations through ListenableFuture.

Test: ./gradlew room:room-paging-guava:cC
Bug: 203666906

Change-Id: I3ec746a072d28e856018d03aeb08931a8d42fa93

A room/room-paging-guava/src/main/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
A room/room-paging-guava/src/androidTest/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSourceTest.kt
M room/room-paging/build.gradle
M room/room-paging-guava/build.gradle
M room/room-paging/src/main/kotlin/androidx/room/paging/util/RoomPagingUtil.kt

https://android-review.googlesource.com/2037356

da...@google.com <da...@google.com> #6May 21, 2019 03:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date: Thu Apr 28 17:05:24 2022

Hook up room-paging-guava to room-compiler

Test: ./gradlew :room:room-compiler:test
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/integration-tests/kotlintestapp/build.gradle
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-paging-guava/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java

https://android-review.googlesource.com/2067883

ap...@google.com <ap...@google.com> #7May 29, 2019 10:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit a5a856d88a480cbb1d4364f6b3d64ff450411cfd
Author: clarafok <clarafok@google.com>
Date: Wed May 11 13:52:19 2022

Implement room-paging-rxjava3 LimitOffsetRxPagingSource

Test: ./gradlew room:room-paging-rxjava3:cC
Bug: 203666906
Change-Id: I0127af74e4ec38c0570f56a5783ec2157f9bb9fc

A room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
A room/room-paging-rxjava3/src/androidTest/kotlin/androidx/room/paging/rxjava3/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava3/build.gradle

https://android-review.googlesource.com/2094107

ap...@google.com <ap...@google.com> #8May 30, 2019 06:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit c7b01e966accae484bb1dd081e3fa5f3f38047fc
Author: clarafok <clarafok@google.com>
Date: Thu May 12 15:28:45 2022

Hook up rxjava3 LimitOffsetRxPagingSource to room-compiler

Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: I57099d83a8c845263c5031990de3124971ac2363

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
A room/room-compiler/src/test/data/common/input/Rx3PagingSource.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx3PagingSource.java
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava3PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2097220

ap...@google.com <ap...@google.com> #9Jun 6, 2019 05:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit c4782c289e754747e1a98a28e2700836d78d7578
Author: clarafok <clarafok@google.com>
Date: Fri May 13 14:12:02 2022

Implement rxjava2 LimitOffsetRxPagingSource

Test: ./gradlew room:room-paging-rxjava2:cC
Bug: 203666906
Change-Id: Iefd883d45b18b032bb3a29d51209fc7de169c1aa

A room/room-paging-rxjava2/src/androidTest/kotlin/androidx/room/paging/rxjava2/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt

https://android-review.googlesource.com/2098470

ap...@google.com <ap...@google.com> #10Jun 7, 2019 07:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit d1ba57918465b84aa9564074df68d3136a4f8fcd
Author: clarafok <clarafok@google.com>
Date: Fri May 13 16:09:09 2022

Hook up room-paging-rxjava2 to room-compiler

Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Fixes: 203666906
Change-Id: Ic8f07f14491ece38b1296ca71c761511218a65a9

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/test/data/common/input/Rx2PagingSource.java
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava2PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx2PagingSource.java
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2098475

da...@google.com <da...@google.com> #11Jun 7, 2019 07:40PM

Marked as fixed.

Room 2.2.0 will be an incremental annotation processing when enabled via the option 'room.incremental = true'

to...@avast.com <to...@avast.com> #12Jun 28, 2019 10:38AM

When will be some alpha or at least snapshot build with this support, please?

yb...@google.com <yb...@google.com> #13Jun 28, 2019 07:17PM

in a couple of weeks, we should have it.

mi...@gtempaccount.com <mi...@gtempaccount.com> #14Oct 10, 2019 05:19AM

I updated to 2.2.0 stable release and added the option "room.incremental = true" to my gradle properties.
But I am still seeing this warning:
w: [kapt] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

mi...@gtempaccount.com <mi...@gtempaccount.com> #15Oct 10, 2019 05:30AM

Sorry about my last comment. I just saw I configured it wrong. It is not supposed to be se tin the gradle.properties, but in the annotationProcessorOptions.

android {
...
defaultConfig {
...
javaCompileOptions {
annotationProcessorOptions {
arguments = [
"room.schemaLocation":"$projectDir/schemas".toString(),
"room.incremental":"true",
"room.expandProjection":"true"]
}
}
}
}

co...@protonmail.com <co...@protonmail.com> #16Jan 23, 2020 07:03AM

@Yigit Will a future version of room have this enabled by default?

yb...@google.com <yb...@google.com> #17Jan 23, 2020 05:30PM

yes, it will be but we are looking for some feedback before we make the switch just to be safe and not break other people.

ap...@google.com <ap...@google.com> #18Jun 18, 2020 05:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2715143f2b6f2b74a088b242b39c9841d2d8dcf2
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Jun 18 09:54:58 2020

Make room.incremental default be true

Relnote: Room's incremental annotation processing option is now ON by default.
Bug: 112110217
Test: :room:integration-tests:room-i-a-p:test
Change-Id: If46d955da45d985543ab982bd0e9d27bbd961517

M room/compiler/src/main/kotlin/androidx/room/processor/Context.kt

https://android-review.googlesource.com/1343816

bl...@gmail.com <bl...@gmail.com> #19Aug 20, 2020 08:45AM

Is it switched on by default in 2.2.5? Because I still got the message got a warning from kapt

[WARN] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

Solved to adding "room.incremental"="true" in the annotation params.

bl...@gmail.com <bl...@gmail.com> #20Aug 20, 2020 08:46AM

Oops, spoke too soon. First appears in the release notes for 2.3.0:

https://developer.android.com/jetpack/androidx/releases/room#2.3.0-alpha02

hu...@google.com <hu...@google.com> #21Sep 17, 2020 09:27PM

KNOWN ISSUE: Note that incremental Room is currently broken in some cases (Issue 159501719), so we may need to revert this change or send out a patch to at least provide workarounds to users. https://issuetracker.google.com//159501719#comment18 lists the possible fixes.

hu...@google.com <hu...@google.com> #22Sep 17, 2020 09:33PM

Sorry there was a typo, correction: https://issuetracker.google.com/159501719#comment18