Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bade7af890d31f0f4a4b094ff1fd475b24fff95c
Author: jbwoods <jbwoods@google.com>
Date: Mon Feb 25 15:49:05 2019
Fix typo in ActivityNavigator
Both popEnterAnim and popExitAnim were getting the intent extra intended
for popEnterAnim in the applyPopAnimationsToPendingTransition method. Made
popExitAnim get the proper extra.
Test: ran nav test app
BUG: 126237567
Change-Id: Iecdcdd62695f66e1a66eeb5ec84df09c1faaff24
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
https://android-review.googlesource.com/912259
https://goto.google.com/android-sha1/bade7af890d31f0f4a4b094ff1fd475b24fff95c
Branch: androidx-master-dev
commit bade7af890d31f0f4a4b094ff1fd475b24fff95c
Author: jbwoods <jbwoods@google.com>
Date: Mon Feb 25 15:49:05 2019
Fix typo in ActivityNavigator
Both popEnterAnim and popExitAnim were getting the intent extra intended
for popEnterAnim in the applyPopAnimationsToPendingTransition method. Made
popExitAnim get the proper extra.
Test: ran nav test app
BUG: 126237567
Change-Id: Iecdcdd62695f66e1a66eeb5ec84df09c1faaff24
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
Description
NavController.getGraph is marked as @Nullable, though it seems that in default case it is @NonNull.
As Jake suggested, we probably should reshape API expose two versions Null/NonNull