Fixed
Status Update
Comments
yb...@google.com <yb...@google.com>
su...@google.com <su...@google.com> #2
Can you please try with alpha07? I suspect it may have been fixed with some bug fixes as part of that release.
ad...@okcredit.in <ad...@okcredit.in> #3
I tried using alpha-07, now I'm getting the "indefinite enqueued" state even on Pixel 2 (running android P). So, basically, the problem is that if the work is enqueued after it starts running (either due to RETRY on failure or if the internet is turned off), it stays in "enqueued" state indefinitely. "Force Stopping" the app and opening it again resolves everything.
I'm attaching the two apks for reference (one for each version of work manager) and the code is available at
https://gist.github.com/aditya-prasad/9aec64d556f02effca6fc018713ad95e
I'm attaching the two apks for reference (one for each version of work manager) and the code is available at
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 26a1f5c745d722aa3e6a41df178d4f00b0be30ee
Author: Sumir Kataria <sumir@google.com>
Date: Mon Aug 20 15:38:18 2018
Don't cancel work needing a reschedule on completion.
alpha06 introduced a bug where we always cancelled work on
all schedulers after execution. We should only do this when
we are truly done with it and don't need a reschedule.
Bug: 112604021
Test: Added a ProcessorTest
Change-Id: Iee367d7c57a14d0ac5328d4e5f83cfc3fd1ad1b7
M work/integration-tests/testapp/src/main/AndroidManifest.xml
A work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RetryActivity.java
A work/integration-tests/testapp/src/main/res/layout/retry_activity.xml
M work/workmanager-firebase/src/main/java/androidx/work/impl/background/firebase/FirebaseJobService.java
M work/workmanager/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/workmanager/src/main/java/androidx/work/impl/Processor.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
https://android-review.googlesource.com/735184
https://goto.google.com/android-sha1/26a1f5c745d722aa3e6a41df178d4f00b0be30ee
Branch: androidx-master-dev
commit 26a1f5c745d722aa3e6a41df178d4f00b0be30ee
Author: Sumir Kataria <sumir@google.com>
Date: Mon Aug 20 15:38:18 2018
Don't cancel work needing a reschedule on completion.
alpha06 introduced a bug where we always cancelled work on
all schedulers after execution. We should only do this when
we are truly done with it and don't need a reschedule.
Bug: 112604021
Test: Added a ProcessorTest
Change-Id: Iee367d7c57a14d0ac5328d4e5f83cfc3fd1ad1b7
M work/integration-tests/testapp/src/main/AndroidManifest.xml
A work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RetryActivity.java
A work/integration-tests/testapp/src/main/res/layout/retry_activity.xml
M work/workmanager-firebase/src/main/java/androidx/work/impl/background/firebase/FirebaseJobService.java
M work/workmanager/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/workmanager/src/main/java/androidx/work/impl/Processor.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 440bc98a105bde429033a009f46a768759811894
Author: Sumir Kataria <sumir@google.com>
Date: Tue Aug 21 09:59:13 2018
Reset the scheduled bit when rescheduling on AlarmManager.
This matches reschneduleAndNotify's functionality with
resetPeriodicAndNotify. AlarmManager impls don't pick up
and schedule work if this bit isn't reset.
Bug: 112604021
Test: Ran integration tests on API 16.
Change-Id: I2fdb0576dd66673842e4890915c3d526624deb72
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
https://android-review.googlesource.com/735815
https://goto.google.com/android-sha1/440bc98a105bde429033a009f46a768759811894
Branch: androidx-master-dev
commit 440bc98a105bde429033a009f46a768759811894
Author: Sumir Kataria <sumir@google.com>
Date: Tue Aug 21 09:59:13 2018
Reset the scheduled bit when rescheduling on AlarmManager.
This matches reschneduleAndNotify's functionality with
resetPeriodicAndNotify. AlarmManager impls don't pick up
and schedule work if this bit isn't reset.
Bug: 112604021
Test: Ran integration tests on API 16.
Change-Id: I2fdb0576dd66673842e4890915c3d526624deb72
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
Description
Version used: 1.0.0-alpha06
Devices/Android versions reproduced on: 4.4.2
following issue contains relevant details: