Crash on device that FBE is enabled [112665532]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 16, 2018 03:46AM

About Android FBE information is as follows：

https://source.android.com/security/encryption/file-based

https://developer.android.com/training/articles/direct-boot

My app starts by receiving "android.intent.action.LOCKED_BOOT_COMPLETED", WorkManager initial before user unlocked.

It cause crash:
java.lang.IllegalStateException: SharedPreferences in credential encrypted storage are not available until after user is unlocked

Because WorkManager use context.applicationContext accessing data/data/package/xxxx.

I tried to disable WorkManagerInitializer in AndroidManifest.xml and initial WorkManager on my first activity.But it cause another crash:
08-16 11:02:07.441 E/AndroidRuntime(19740): java.lang.RuntimeException: Unable to create service androidx.work.impl.background.systemjob.SystemJobService: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.handleCreateService(ActivityThread.java:3415)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.-wrap4(Unknown Source:0)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1738)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.os.Handler.dispatchMessage(Handler.java:106)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.os.Looper.loop(Looper.java:164)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.main(ActivityThread.java:6618)
08-16 11:02:07.441 E/AndroidRuntime(19740): at java.lang.reflect.Method.invoke(Native Method)
08-16 11:02:07.441 E/AndroidRuntime(19740): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
08-16 11:02:07.441 E/AndroidRuntime(19740): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:810)
08-16 11:02:07.441 E/AndroidRuntime(19740): Caused by: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().
08-16 11:02:07.441 E/AndroidRuntime(19740): at androidx.work.impl.background.systemjob.SystemJobService.onCreate(SystemJobService.java:67)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.handleCreateService(ActivityThread.java:3405)
08-16 11:02:07.441 E/AndroidRuntime(19740): ... 8 more

Comments

su...@google.com <su...@google.com> #2Aug 16, 2018 03:53AM

since these are in public API (:/) we need to do this in 1.2

[Deleted User] <[Deleted User]> #3Aug 16, 2018 04:56AM

since it is already marked as deprecated, we can probably do it by now.

su...@google.com <su...@google.com> #4Aug 16, 2018 04:34PM

Opening diff shortly

il...@google.com <il...@google.com> #5Aug 16, 2018 06:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

su...@google.com <su...@google.com> Aug 16, 2018 11:09PM

Assigned to su...@google.com.

ap...@google.com <ap...@google.com> #6Aug 17, 2018 10:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f3e63e3a3432b5fb941aec3d4a21e9a5ea42f1d1
Author: Sumir Kataria <sumir@google.com>
Date: Fri Aug 17 14:34:56 2018

Explicitly label WM components as direct boot unaware.

Because WM defaults to a database in encrypted storage, it
cannot run while in direct boot. By explicitly labelling the
components this way, they cannot inherit a directBootAware
flag from the merged <application> xml.

In the future, we will provide a version of WorkManager that
is direct-boot aware. See the tracking feature request at

https://issuetracker.google.com/112773820 This is something
that might land post-1.0.

Bug: 112665532
Test: Ran some integration tests in a test app.
Change-Id: Ide87b8e4c5dfefb88a54c3ce4c45262335f47e96

M work/workmanager/src/main/AndroidManifest.xml

https://android-review.googlesource.com/734390

https://goto.google.com/android-sha1/f3e63e3a3432b5fb941aec3d4a21e9a5ea42f1d1

su...@google.com <su...@google.com> #7Aug 17, 2018 10:43PM

Marked as fixed.

Further work will be tracked on

https://issuetracker.google.com/112773820.

[Deleted User] <[Deleted User]> #8Aug 17, 2018 11:55PM

1st exception:
java.lang.IllegalStateException: SharedPreferences in credential encrypted storage are not available until after user is unlocked
2nd exception:
java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().

I'm enqueuing Work with WorkManager on some specific activity or fragment. So I tried to call WorkManager.initialize() on my launch activity after the 1st exception is thrown. The 2nd exception happened only once after clicking on the launch icon.I am not sure how to reproduce the 2nd one.

ra...@google.com <ra...@google.com> #9Aug 18, 2018 01:44AM

The ContentProvider attempted to initialize WorkManager, when it was in direct boot mode. That failed (because the device was in direct boot mode). Hence WorkManager was not initialized.
So the subsequent calls to use the application after the device is unlocked will fail, as WorkManager has still not been initialized.

ma...@gmail.com <ma...@gmail.com> #10Aug 18, 2018 05:06PM

tolonglah

so...@gmail.com <so...@gmail.com> #11Jan 21, 2020 12:41PM

is workmanager now available with boot aware changes.
Please let me know will library version it is.

so...@gmail.com <so...@gmail.com> #12Mar 3, 2020 05:56AM