Crash on device that FBE is enabled [112665532]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 16, 2018 03:46AM

About Android FBE information is as follows：

https://source.android.com/security/encryption/file-based

https://developer.android.com/training/articles/direct-boot

My app starts by receiving "android.intent.action.LOCKED_BOOT_COMPLETED", WorkManager initial before user unlocked.

It cause crash:
java.lang.IllegalStateException: SharedPreferences in credential encrypted storage are not available until after user is unlocked

Because WorkManager use context.applicationContext accessing data/data/package/xxxx.

I tried to disable WorkManagerInitializer in AndroidManifest.xml and initial WorkManager on my first activity.But it cause another crash:
08-16 11:02:07.441 E/AndroidRuntime(19740): java.lang.RuntimeException: Unable to create service androidx.work.impl.background.systemjob.SystemJobService: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.handleCreateService(ActivityThread.java:3415)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.-wrap4(Unknown Source:0)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1738)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.os.Handler.dispatchMessage(Handler.java:106)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.os.Looper.loop(Looper.java:164)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.main(ActivityThread.java:6618)
08-16 11:02:07.441 E/AndroidRuntime(19740): at java.lang.reflect.Method.invoke(Native Method)
08-16 11:02:07.441 E/AndroidRuntime(19740): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
08-16 11:02:07.441 E/AndroidRuntime(19740): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:810)
08-16 11:02:07.441 E/AndroidRuntime(19740): Caused by: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvider#onCreate() or an Application#onCreate().
08-16 11:02:07.441 E/AndroidRuntime(19740): at androidx.work.impl.background.systemjob.SystemJobService.onCreate(SystemJobService.java:67)
08-16 11:02:07.441 E/AndroidRuntime(19740): at android.app.ActivityThread.handleCreateService(ActivityThread.java:3405)
08-16 11:02:07.441 E/AndroidRuntime(19740): ... 8 more

Comments

su...@google.com <su...@google.com> #2Aug 16, 2018 03:53AM

Seems like it happens on API 21-22 too.

[Deleted User] <[Deleted User]> #3Aug 16, 2018 04:56AM

This is expected. You are calling: enqueueUniquePeriodicWork() with an ExistingPeriodicWorkPolicy.REPLACE. This will cancel running work, and kick off new instances of all Workers.

https://github.com/rubensousa/WorkManagerKitkatBug/blob/master/app/src/main/java/com/github/rubensousa/workkitkatbug/MainActivity.kt#L24

su...@google.com <su...@google.com> #4Aug 16, 2018 04:34PM

I just ran the sample again and now the behaviour is different for some weird reason. I forgot to mention that I only used REPLACE to test this properly. Because it also happens with KEEP.

il...@google.com <il...@google.com> #5Aug 16, 2018 06:06PM

And shouldn't the behaviour be consistent across all Android versions?

su...@google.com <su...@google.com> Aug 16, 2018 11:09PM

Assigned to su...@google.com.

ap...@google.com <ap...@google.com> #6Aug 17, 2018 10:42PM

We don't see any issues with KEEP. If you have a way for us to reproduce any problems, please send us the appropriate instructions.

su...@google.com <su...@google.com> #7Aug 17, 2018 10:43PM

Marked as fixed.

Ok, I found something odd. Seems like setRequiredNetworkType(NetworkType.UNMETERED) causes this for some reason. I'm going to update the sample so you can review this again. Please, reopen this since it's not intended behavior.

[Deleted User] <[Deleted User]> #8Aug 17, 2018 11:55PM

This happens on a fresh install with KEEP instead of REPLACE if the constraints have setRequiredNetworkType(NetworkType.UNMETERED). I've updated the sample

ra...@google.com <ra...@google.com> #9Aug 18, 2018 01:44AM

"And shouldn't the behaviour be consistent across all Android versions?"
The behavior is actually consistent. Once your worker starts running, if we get a call to enqueueUniquePeriodicWork a new work request and with ExistingPeriodicWorkPolicy.REPLACE we will stop existing work.
If your Worker was not running, then there is nothing to cancel. This is just a matter of timing.

ma...@gmail.com <ma...@gmail.com> #10Aug 18, 2018 05:06PM

I'm not arguing against the expected behavior of ExistingPeriodicWorkPolicy.REPLACE, since that's working as intended. But this is happening only when setRequiredNetworkType(NetworkType.UNMETERED) is used while having ExistingPeriodicWorkPolicy.KEEP.

so...@gmail.com <so...@gmail.com> #11Jan 21, 2020 12:41PM

Can you send us an updated sample ?

so...@gmail.com <so...@gmail.com> #12Mar 3, 2020 05:56AM

Looks like you have updated the sample, let me take another look.