Deeplink with a custom scheme containing dots. [112806402]

Fixed

Feature Request

Status Update

No update yet.

Description

ou...@gmail.com

created issue #1

Aug 19, 2018 03:21PM

Component used: Navigation
Version used: android.arch.navigation:navigation-ui:1.0.0-alpha05
Devices/Android versions reproduced on: any

I suppose it's no a bug, but just a wrong behavior.
If i have i custom scheme, like "com.example://" - this could not be used and inside framework http(s) will be appended.

NavDeeplink states that there is a scheme pattern, that should detect if there is any scheme before ":", but it fails if there is any dot in scheme. So any scheme that contains dots will fail. Only schemes with "-" are supported by now.
private static final Pattern SCHEME_PATTERN = Pattern.compile("^(\\w+-)*\\w+:");

Comments

il...@google.com <il...@google.com> #2Aug 21, 2018 12:01AM

Assigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

ou...@gmail.com <ou...@gmail.com> #3Aug 25, 2018 06:20PM

This is fixed internally and will be available in 1.0.0-alpha08

il...@google.com <il...@google.com> Oct 10, 2018 10:59PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Oct 12, 2018 10:04AM

Thanks!

il...@google.com <il...@google.com> #5Oct 12, 2018 04:36PM

Assigned to sp...@google.com.

The library now supports all schemes supported by

https://tools.ietf.org/html/rfc3986#section-3.1

The regex being used is ^[a-zA-Z]+[+\w\-.]*:

Over to Studio to ensure that Manifest Merger also supports the updated schema types.

sp...@google.com <sp...@google.com> #6Oct 12, 2018 06:41PM

Marked as fixed.

Yes, Manifest Merger supports this. Pending CL adds test for this scenario.

Issue 112806402