Deeplink with a custom scheme containing dots. [112806402]

Fixed

Feature Request

Status Update

No update yet.

Description

ou...@gmail.com

created issue #1

Aug 19, 2018 03:21PM

Component used: Navigation
Version used: android.arch.navigation:navigation-ui:1.0.0-alpha05
Devices/Android versions reproduced on: any

I suppose it's no a bug, but just a wrong behavior.
If i have i custom scheme, like "com.example://" - this could not be used and inside framework http(s) will be appended.

NavDeeplink states that there is a scheme pattern, that should detect if there is any scheme before ":", but it fails if there is any dot in scheme. So any scheme that contains dots will fail. Only schemes with "-" are supported by now.
private static final Pattern SCHEME_PATTERN = Pattern.compile("^(\\w+-)*\\w+:");

Comments

il...@google.com <il...@google.com> #2Aug 21, 2018 12:01AM

Assigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 7b17505c2e3679330cf386efe69f1aa95b6ae9e9
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 06 14:47:42 2022

Update safeArgs to AGP 7.0.4

Updating safeArgs to depend on AGP 7.0.4.

Removing the use of reflection from the plugin since we no longer
needed.

RelNote: "Safe Args now depends on Android Gradle Plugin version 7.0.4.
This means that Navigation Safe Args will no longer be compatible with
Android Studio versions prior to 7.0."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 213086135
Bug: 207670704

Change-Id: I41c88ee06ad827c61cb1bbdc5ba58b3d56155caf

M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt

https://android-review.googlesource.com/1940534

ou...@gmail.com <ou...@gmail.com> #3Aug 25, 2018 06:20PM

Do you know if I can try this out in a snapshot or has it been published under a version name? (sorry, things in gerrit still confuse me so maybe its already clear that this is fixed and shipped!)

il...@google.com <il...@google.com> Oct 10, 2018 10:59PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Oct 12, 2018 10:04AM

Yes, you can follow the snapshot instruction and try this out with build id #8054565.

il...@google.com <il...@google.com> #5Oct 12, 2018 04:36PM

Assigned to sp...@google.com.

@jb...@google.com comment#4

Is the snapshot I'm trying to use 2.5.0-SNAPSHOT?

sp...@google.com <sp...@google.com> #6Oct 12, 2018 06:41PM

Marked as fixed.

Yay. I can confirm that your fix worked. Thanks! And you were able to beat out the firebase perf plugin in getting a fix released. Thank you! This unblocks my team!

Heads up what I had to do. add the maven repo to buildscript repos

buildscript {
  repositories {
    google()
    mavenCentral()
    maven("https://androidx.dev/snapshots/builds/8054565/artifacts/repository")
  }
}

then update the plugin to

classpath("androidx.navigation:navigation-safe-args-gradle-plugin:2.5.0-SNAPSHOT")

I don't know whether I should update the rest of my nav deps to 2.5.0 snapshot, but this'll do for now.

Issue 112806402