Periodic work is not triggered more than once on 1.0.0-alpha07 [112859683]

Fixed

Bug

Status Update

No update yet.

Description

ne...@gmail.com

created issue #1

Aug 20, 2018 10:08PM

Component used: WorkManager
Version used: 1.0.0-alpha07
Devices/Android versions reproduced on: Pixel 2, Android 9 Pie

The work request below is executed once but not periodically on version alpha07, this works correctly and periodically on version alpha06

val constraints = androidx.work.Constraints.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED)
.build() // Run only when network is available
val workRequest =
PeriodicWorkRequestBuilder<ReportUploader>(REPORTING_REPEAT_INTERVAL_IN_MINUTES, TimeUnit.MINUTES)
.addTag(REPORTER_TAG)
.setConstraints(constraints)
.setBackoffCriteria(BackoffPolicy.EXPONENTIAL, 10, TimeUnit.SECONDS)
.build() // Run every 15 mins
workManager
.enqueueUniquePeriodicWork(REPORTER_TAG, ExistingPeriodicWorkPolicy.KEEP, workRequest)

Comments

ne...@gmail.com <ne...@gmail.com> #2Aug 20, 2018 10:10PM

Easy repro: Tap back key during gesture selection.

ra...@google.com <ra...@google.com> Aug 21, 2018 11:33PM

Assigned to ra...@google.com.

su...@google.com <su...@google.com> Aug 21, 2018 11:45PM

Accepted by su...@google.com.

ap...@google.com <ap...@google.com> #3Aug 22, 2018 12:44AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc37dddeefb6910a229d81612a60374678e615b4
Author: Steve McKay <smckay@google.com>
Date: Wed Aug 14 23:48:25 2019

Add support for resetting library state in response to CANCEL events and clearing of selection.

Sepcifically:
- BandSelectionHelper#reset
- GestureSelectionHelper#reset
- Clearing Selection in tracker.
- Reset the OperationMonitor.
- Connect explicit clearSelection (as clients call from back button) to reset.

GestureDetector is already listening for CANCEL events, cleans up its own state internally.

Related cleanups:
- Add onSelectionCleared support to SelectionObserver class.
- Guard all runtime state checking behind DEBUG bit (mis-configuration still throws).
- Deprecate support for setting gesture/pointer tooltypes.
- Define more events in TestEvents.
- Cleanup naming and consoliate some tests in BandSelectionHelperTest.
- Remove support POINTER_UP in BandSelectionHelper...POINTER_UP is for secondary pointer
devices only, which is outside of the domain of BandSelectionHelper.

BUG: 137460699
Test: Passing, added new test related to reset behavior.
Change-Id: Ie7127571dfa95f571ac754b3ae58e03bb153cbe8

M recyclerview/recyclerview-selection/api/1.1.0-alpha07.txt
M recyclerview/recyclerview-selection/api/current.txt
M recyclerview/recyclerview-selection/api/public_plus_experimental_1.1.0-alpha07.txt
M recyclerview/recyclerview-selection/api/public_plus_experimental_current.txt
M recyclerview/recyclerview-selection/api/restricted_1.1.0-alpha07.txt
M recyclerview/recyclerview-selection/api/restricted_current.txt
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTracker_SingleSelectTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/GestureSelectionHelperTest.java
A recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/ResetMangerTest.java
A recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/SelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/TouchInputHandlerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestEvents.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestRunnable.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/GestureDetectorOnItemTouchListenerAdapter.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/GestureSelectionHelper.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/MotionEvents.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/MouseInputHandler.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/OperationMonitor.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/Range.java
A recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ResetManager.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/SelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/TouchInputHandler.java

https://android-review.googlesource.com/1103351

lo...@gmail.com <lo...@gmail.com> #4Aug 22, 2018 03:24PM

Aiming to have a 1.1 beta release out soon including this fix.

All defensive check stability issues should be resolved with this CL.

su...@google.com <su...@google.com> #5Aug 22, 2018 04:03PM

Marked as fixed.

The fix will be available in alpha08.

ta...@gmail.com <ta...@gmail.com> #6Oct 6, 2018 09:23AM

I'm facing this in alpha09 on Android Pie

ta...@gmail.com <ta...@gmail.com> #7Oct 7, 2018 09:48AM

Update: alpha09 works fine in pre-Oreo with a minimum interval of 15 minutes. Post Oreo, never gets triggered. Haven't yet checked the interference of battery optimization. Will update on the same soon.

ah...@gmail.com <ah...@gmail.com> #8Nov 4, 2018 09:36AM

Still facing this in alpha10 on Oreo and Pie

ar...@gmail.com <ar...@gmail.com> #9Nov 22, 2018 06:10PM

solved in alpha 11 i have not this problem but some times WorkManger run 2 times instead one Worker class in Periodic work

pr...@gmail.com <pr...@gmail.com> #10Nov 24, 2018 09:32AM

Is there any other way to use periodic job scheduler except WorkManager,Job Creator?