AppCompatTextView.setTextFuture no support layout direction from right to lef (RTL) [113070424]

Verified

Bug

[AOSP] assigned

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 23, 2018 07:50AM

Version used: androidx.appcompat:appcompat:1.0.0-rc01 (or 28.0.0-rc01)
Theme used: Theme.AppCompat.Light.DarkActionBar or Theme.MaterialComponents
Devices/Android versions reproduced on: irrelevant. (Tested on Nokia 8 Android 8.1, Nokia 7 Plus Android P beta 04)

I'm testing the method AppCompatTextView.setTextFuture but I realized, it didn't support layout direction (android:layoutDirection="rtl") from righ to left (RTL) or on a device has the system language shows from RTL as the Arabic language, even I removed the attr android:layoutDirection="rtl". The app will crash. Please test again.

java.lang.IllegalArgumentException: Given text can not be applied to TextView.
at androidx.core.widget.TextViewCompat.setPrecomputedText(TextViewCompat.java:889)
at androidx.appcompat.widget.AppCompatTextView.consumeTextFutureAndSetBlocking(AppCompatTextView.java:468)
at androidx.appcompat.widget.AppCompatTextView.onMeasure(AppCompatTextView.java:500)
at android.view.View.measure(View.java:22112)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6613)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1514)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:806)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:685)
at android.view.View.measure(View.java:22112)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6613)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at androidx.appcompat.widget.ContentFrameLayout.onMeasure(ContentFrameLayout.java:143)
at android.view.View.measure(View.java:22112)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6613)
at androidx.appcompat.widget.ActionBarOverlayLayout.onMeasure(ActionBarOverlayLayout.java:401)
at android.view.View.measure(View.java:22112)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6613)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at android.view.View.measure(View.java:22112)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6613)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1514)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:806)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:685)
at android.view.View.measure(View.java:22112)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6613)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:185)
at com.android.internal.policy.DecorView.onMeasure(DecorView.java:875)
at android.view.View.measure(View.java:22112)
at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:2426)
at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:1508)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1765)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1396)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6773)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:978)
at android.view.Choreographer.doCallbacks(Choreographer.java:790)
at android.view.Choreographer.doFrame(Choreographer.java:725)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:964)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6501)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

-------------------------------------------------

Source code:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="

http://schemas.android.com/apk/res/android"
xmlns:tools="

http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:padding="16dp"
android:orientation="vertical"
android:layoutDirection="rtl"
tools:context=".MainActivity">

<androidx.appcompat.widget.AppCompatTextView
android:id="@+id/textView"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:textAppearance="@style/TextAppearance.AppCompat.Medium" />

</LinearLayout>

------------------------------------------------------------------------

class MainActivity : AppCompatActivity() {

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_main)

val textView = findViewById<AppCompatTextView>(R.id.textView);

setAsyncText(textView, "Testing the setTextFuture method ")
}

private fun setAsyncText(textView: AppCompatTextView, text: String?) {
if (!text.isNullOrEmpty()) {
val textFuture = PrecomputedTextCompat.getTextFuture(text!!, TextViewCompat.getTextMetricsParams(textView), null)
textView.setTextFuture(textFuture) // Crash

//textView.text = text // No crash
//textView.setPrecomputedText(PrecomputedTextCompat.create(text, textView.textMetricsParamsCompat)) // No crash
}
}
}

--------------------------------------------------------------

<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/AppTheme">
<activity android:name=".MainActivity">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
</application>

--------------------------------------
My device

Android Studio 3.3 Canary 6
Build #AI-182.3684.101.33.4954005, built on August 15, 2018
JRE: 1.8.0_152-release-1136-b06 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

dependencies {
classpath 'com.android.tools.build:gradle:3.3.0-alpha06'

classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-alpha10'

classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.2.61"
}

Comments

[Deleted User] <[Deleted User]> #2Aug 23, 2018 08:38AM

This also brings back dialog content size animations issues :( But on all devices this time.

See attached video

Repro:

Dialog(
                    onDismissRequest = {
                        if (dialogState.canDismiss.value) {
                            dialogNavigator.hide()
                        }
                    },
                    properties = properties,
                    content = {
                        Surface(
                            modifier = modifier
                                .safeContentPadding()
                                .fillMaxWidth(0.8f)
                                .animateContentSize(),
                            shape = shape,
                            color = backgroundColor,
                            contentColor = contentColor,
                        ) {
                            .....A composable that change it's size
                        }
                    },
                )

da...@gmail.com <da...@gmail.com> #3Aug 23, 2018 01:36PM

Can you give a fuller example for the animateContentSize() problem?

[Deleted User] <[Deleted User]> #4Aug 23, 2018 02:32PM

It does that for all the cases where the content change.

properties = DialogProperties(usePlatformDefaultWidth = false)

var show by remember { mutableStateOf(false) }

LaunchedEffect(Unit)  {
 delay(1000)
 show = true
}

Column {
  Text("X")
if (show) {
   Text"Y) 
}

}

Edit: This was a well known long time issue when not using usePlatformDefaultWidth = false so we were forced to workaround with that. Now even with it it trigger that. (Depending on the phone, it's either super slow, or laggy and jumping).

[Deleted User] <[Deleted User]> #5Aug 23, 2018 02:43PM

I am seeing a problem with decorFitsSystemWindows = false where it continues to invalidate the layout even after the animation completes. I don't think that's the problem you're worried about, though.

If I understand correctly, the problem you're seeing is something about it being laggy? And it didn't happen in the previous version, right?

That problem is likely due to the Window resizing on every frame, which is more expensive than the window content resizing on every frame. In a previous iteration, the window size was full screen and the content resized itself. You can resolve this yourself by doing this:

                Surface(
                    modifier = Modifier.safeContentPadding()
                        .fillMaxSize()
                        .wrapContentHeight()
                        .fillMaxWidth(0.8f)
                        .animateContentSize(),
...

I'll see if I can fix the problem with decorFitsSystemWindows = false invalidating layout continuously.

da...@gmail.com <da...@gmail.com> #6Aug 23, 2018 03:49PM

There's 2 very different issue here. The main very blocking is the Samsung dialogs from a bottomsheet/popup being at the bottom and under the navigation bar. Samsung is a very large percent of users. And a full rewrite of all M3 AlerDialog to something else to workaround is a pain as most M3 things are private / internal.

The second issue is about the huge lag. It was present since a very long time with usePlatformDefaultWidth = true but not with usePlatformDefaultWidth = false now it's always present.

AFAIR previously all the workaround based on .fillMaxSize() had issues with the dialog scrim, but I'll try again if there's a fix for the Samsung devices.

vi...@google.com <vi...@google.com> Aug 27, 2018 07:04AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> #7Aug 27, 2018 01:46PM

I just verified that an AlertDialog called from a ModalBottomSheet from a Pixel 9XL works fine. I'll see if I can find a Samsung device to test.

[Deleted User] <[Deleted User]> #8Aug 28, 2018 12:56PM

Yes this is specific to Samsung as stated in first message.

I repro via Samsung testlab as I do not have a device myself, but A54 A55 with Android 14 there does reproduce the issue. (And a few different other Android 14 samsung devices from my beta users)

da...@gmail.com <da...@gmail.com> #9Aug 28, 2018 01:14PM

I just verified that I can repro on a Samsung device.

vi...@google.com <vi...@google.com> #10Aug 31, 2018 06:28AM

Perfect.

Just quickly tested the

.fillMaxSize()
.wrapContentHeight()

And it seems to behave correctly for the dialog scrim so works as a solution, may worth a note somewhere as cheating with usePlatformDefaultWidth = false was often found as solution in a few posts over Internet.

A quick "mostly" related question to the dialog scrim, many users requested an option to hide the status bar in my app to be in full immersive mode, but there's no way to do that with dialogs right now. Is this something that can be requested? I have a fork of M3 BottomSheet to handle that, but handling a fork of the low level dialog requires a full copy and rewrite of everything that depends on it.

cc...@google.com <cc...@google.com> #11Nov 8, 2018 04:14PM

Verified by cc...@google.com.

Have you tried using the DialogWindowProvider?:

fun findDialogWindowProviderInParent(view: View): DialogWindowProvider? {
    if (view is DialogWindowProvider) {
        return view
    }
    val parent = view.parent ?: return null
    if (parent is View) {
        return findDialogWindowProviderInParent(parent)
    }
    return null
}

@Composable
MyDialogContent() {
    val dialogWindowProvider = findDialogWindowProviderInParent(LocalView.current)
    dialogWindowProvider?.window?.addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN)
    ...
}

ve...@google.com <ve...@google.com> #12Jan 29, 2019 06:19AM

Not at all I always failed at finding the proper window, this works perfectly thanks a lot.

                        val dialogWindowProvider = findDialogWindowProviderInParent(LocalView.current)
                        val window = dialogWindowProvider?.window
                        if (window != null) {
                            WindowCompat.getInsetsController(window, window.decorView).apply {
                                hide(WindowInsetsCompat.Type.statusBars())
                                systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
                            }
                        }

ve...@google.com <ve...@google.com> #13Jan 29, 2019 06:23AM

Returning to the 2nd issue about the lag and your solution.

Using a .fillMaxSize() breaks the second .fillMaxWidth(0.8f). In my case since only the height change I can use a .fillMaxHeight() but I do not really understand what is happening. See attached screenshots.

I can just return to usePlatformDefaultWidth = true since your workaround fixes the lag and then it behave as expected.

So just reporting in case there's something else about measurement that changes and was not expected.