submitList with equals list and loadAfter will not be invoked [113122599]

Verified

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Aug 24, 2018 09:27PM

Component used: Paging library
Version used: 1.0.1
Devices/Android versions reproduced on: Any

If adapter already has items and you submit a new equals list (`submitList` in `PagedListAdapter`) and they do not feet all screen, `loadAfter` will not be invoked.
In my case, I use a refresh and create new PagedList from new DataSource but a content of items will not be changed.

https://drive.google.com/file/d/1WwQd4juoM4HYiVNu4Z_d9ARaMckd_YiA/view?usp=drive_web (device-2018-08-25-000409.webm)

https://drive.google.com/file/d/1z5wGxQTHxrPiEexMpeu3rafRBzWavkjo/view?usp=drive_web (device-2018-08-25-001519.webm)

Comments

cc...@google.com <cc...@google.com> #2Sep 18, 2018 06:30PM

Accepted by cc...@google.com.

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

initialload.mp4

10 MB

Download

cc...@google.com <cc...@google.com> #3Sep 18, 2018 09:01PM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

cc...@google.com <cc...@google.com> #4Sep 19, 2018 05:09PM

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

cc...@google.com <cc...@google.com> #5Sep 20, 2018 09:55PM

Marked as fixed.

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!

ap...@google.com <ap...@google.com> #6Sep 20, 2018 09:56PM

Add autovalue support also means you can easily achieve parcelable by

https://github.com/rharter/auto-value-parcel. Please consider support this.

cc...@google.com <cc...@google.com> #7Oct 15, 2018 09:56PM

Verified by cc...@google.com.

AutoValue is really a handy way to ensure data integrity.

[Deleted User] <[Deleted User]> #8Jan 2, 2019 02:11AM

Please add AutoValue support. AutoValue is a Google library with really good benefits such as toString() , hashCode() , AutoValue.Builder , checks at creation time if @NonNull values are null, etc.