AS 3.3a7 refuses to sync with stable versions of AGP [113167627]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

yo...@gmail.com

created issue #1

Aug 26, 2018 03:46PM

Build: 3.3 Canary 7, AI-182.3911.36.33.4968538, 201808212234,

Android Gradle Plugin: 3.3.0-alpha07
Gradle: 4.9

Load the arch components Gihub browser sample app

https://github.com/googlesamples/android-architecture-components/tree/master/GithubBrowserSample/

Actual:
With stable AGP versions (e.g. 3.1.2 or 3.1.4), it fails to sync and forces you to use AGP 3.3a7 .

Expected:
preview AS builds should sync with any AGP stable version from at least the last 12 months.

Comments

ra...@google.com <ra...@google.com> Aug 28, 2018 08:19PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Aug 28, 2018 08:24PM

Reassigned to sr...@google.com.

sr...@google.com <sr...@google.com> #2Aug 28, 2018 11:21PM

Accepted by sr...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3531312

Convert navigation-testing to KMP

Expand for full commit details

Convert navigation-testing to KMP 
 
Moving the navigation-testing module to KMP. This supports all the same 
platforms as the rest of Navigation and has converted all uses of Bundle 
to the new SaveState. 
 
RelNote: "Navigation Testing is now a KMP module." 
Test: all tests pass 
Bug: 398265336 
Change-Id: I2b7707a56f263be30420cae57e3b38480d7f0625

Files:

M docs-tip-of-tree/build.gradle
A navigation/navigation-testing/bcv/native/current.txt
M navigation/navigation-testing/build.gradle
M navigation/navigation-testing/src/androidInstrumentedTest/AndroidManifest.xml
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavHostControllerTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavigatorStateTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/res/navigation/test_graph.xml
M navigation/navigation-testing/src/androidMain/AndroidManifest.xml
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavHostController.android.kt
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavigatorState.android.kt
A navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/RobolectricTest.android.kt
M navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt
A navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/SavedStateHandleFactory.kt
M navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/TestNavigatorProvider.kt
D navigation/navigation-testing/src/main/AndroidManifest.xml
D navigation/navigation-testing/src/main/java/androidx/navigation/testing/SavedStateHandleFactory.kt

Hash: 31ae4c7ebb13918db0e022b19246b7a47755ac65
Date: Fri Mar 07 09:11:14 2025

safeargs.diff

1.1 KB

View

Download

sr...@google.com <sr...@google.com> Sep 5, 2018 07:09PM

Status: Won't Fix (Infeasible)

yo...@gmail.com <yo...@gmail.com> #3Sep 5, 2018 10:30PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3545603

Implement jvmTest for navigation-testing

Expand for full commit details

Implement jvmTest for navigation-testing 
 
Adding a copy of TestSavedStateHandleFactory to jvmCommonTest to ensure 
that is runs on all nonAndroid platforms. 
 
The `nullLiteralArgument` and `emptyStringArgument` tests are expected 
to fail as they require the encoding and decoding the types which is 
behavior only supported on the jetbrains fork. 
 
Test: added tests 
Bug: 398265336 
Change-Id: I4c1dcfb697d6e9e16995b249b9a8351bd925e0f3

Files:

M navigation/navigation-testing/build.gradle
A navigation/navigation-testing/src/jvmCommonTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt

Hash: 139d2423c7625f19ececc94b2df5bfde24e2cf95
Date: Fri Mar 14 23:48:06 2025

xa...@google.com <xa...@google.com> #4Sep 5, 2018 11:31PM

Status: Assigned (reopened)

We need to review this plugin and see what it does in general.

The fact that a non final plugin depend on a non final version of our plugin and breaks things is sad but not something we can solve easily on our end. (we need to have other plugin depend on a more stable API artifact rather than specific versions of our plugin.

il...@google.com <il...@google.com> #5Sep 6, 2018 06:01PM

Reassigned to se...@google.com.

The source is available here:

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/navigation/safe-args-gradle-plugin/

il...@google.com <il...@google.com> Oct 10, 2018 11:39PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #6Oct 23, 2018 03:57PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d276ac5482afaf12a78ea357fffe40b2a7964301
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Oct 22 14:18:06 2018

Set fixed Android Gradle Plugin dependency version for SafeArgs.

Fixing the version makes it so that if the plugin is updated to a beta
or alpha version for frameworks/support we don't ship SafeArgs with
a non-stable dependency that can cause olders Android Studio versions
to reject syncing.

Bug: 113167627
Test: SafeArgs Tests
Change-Id: Id2de86e4ac724d6d812ea6bd383059737695e948

M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/safe-args-gradle-plugin/build.gradle

https://android-review.googlesource.com/798471

https://goto.google.com/android-sha1/d276ac5482afaf12a78ea357fffe40b2a7964301

il...@google.com <il...@google.com> Oct 23, 2018 03:58PM

Marked as fixed.