AS 3.3a7 refuses to sync with stable versions of AGP [113167627]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

yo...@gmail.com

created issue #1

Aug 26, 2018 03:46PM

Build: 3.3 Canary 7, AI-182.3911.36.33.4968538, 201808212234,

Android Gradle Plugin: 3.3.0-alpha07
Gradle: 4.9

Load the arch components Gihub browser sample app

https://github.com/googlesamples/android-architecture-components/tree/master/GithubBrowserSample/

Actual:
With stable AGP versions (e.g. 3.1.2 or 3.1.4), it fails to sync and forces you to use AGP 3.3a7 .

Expected:
preview AS builds should sync with any AGP stable version from at least the last 12 months.

Comments

ra...@google.com <ra...@google.com> Aug 28, 2018 08:19PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Aug 28, 2018 08:24PM

Reassigned to sr...@google.com.

sr...@google.com <sr...@google.com> #2Aug 28, 2018 11:21PM

Accepted by sr...@google.com.

Another option is to provide a setContent like API specifically for Fragments.

E.g., an extension like:

fun Fragment.content(content: @Composable () -> Unit): ComposeView {
    return ComposeView(requireContext()).apply {
        setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
        setContent(content)
    }
}

which would let you write a Fragment like:

class ExampleFragment : Fragment() {
    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
    ) = content {
        // Write your @Composable content here
        val viewModel: ExampleViewModel = viewModel()
        // or extract it into a separate, testable method
        ExampleComposable(viewModel)
    }
}

safeargs.diff

1.1 KB

View

Download

sr...@google.com <sr...@google.com> Sep 5, 2018 07:09PM

Status: Won't Fix (Infeasible)

yo...@gmail.com <yo...@gmail.com> #3Sep 5, 2018 10:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit a066a43da39b518751bcbd5baed63decb657f3bb
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 16 22:11:03 2024

Add Fragment Compose module in Androidx

Adding Fragment Compose module using the create_project.py script.

RelNote: n/a
Test: ./gradlew updateApi
Bug: 258046948
Change-Id: Ia35d149c8ab0d78331206accf53e25a717f97291

M docs-tip-of-tree/build.gradle
A fragment/fragment-compose/api/current.txt
A fragment/fragment-compose/api/res-current.txt
A fragment/fragment-compose/api/restricted_current.txt
A fragment/fragment-compose/build.gradle
A fragment/fragment-compose/src/main/java/androidx/fragment/androidx-fragment-fragment-compose-documentation.md
M settings.gradle

https://android-review.googlesource.com/2912225

xa...@google.com <xa...@google.com> #4Sep 5, 2018 11:31PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: androidx-main

commit 561cb75bdf7e971f0ba2dec3cdc3286e1b415ecf
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 16 23:53:00 2024

Add Fragment.content extension

Provides an easy integration for providing Compose content inside of a
Fragment that sets the ComposeView and ViewCompositionStrategy.

RelNote: "The new Fragment Compose module provides a Fragment.content
extension function to handle setting a Fragment's view in Compose."
Test: added test
Bug: 258046948

Change-Id: Ia166527918517593e94bcae239ff714df4dc00ad

M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/TestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/activity_main.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/Fragment.kt

https://android-review.googlesource.com/2911416

il...@google.com <il...@google.com> #5Sep 6, 2018 06:01PM

Reassigned to se...@google.com.

This has been fixed internally and will be available in the Fragment 1.7.0-alpha09 release.

il...@google.com <il...@google.com> Oct 10, 2018 11:39PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #6Oct 23, 2018 03:57PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.protolayout:protolayout-material-core:1.1.0-rc01
androidx.wear.tiles:tiles-tooling:1.3.0-rc01
androidx.wear.tiles:tiles-tooling-preview:1.3.0-rc01

il...@google.com <il...@google.com> Oct 23, 2018 03:58PM

Marked as fixed.