Fixed
Status Update
Comments
ra...@google.com <ra...@google.com>
al...@google.com <al...@google.com>
sr...@google.com <sr...@google.com> #2
This is because a PendingIntent doesn't use the extras/arguments to compare 2 intents, so each notification actually use the same pending intent, and the extras arguments are updated (PendingIntent.FLAG_UPDATE_CURRENT).
If you have a <deepLink> element in your destination, you should use the Uri to navigate to it.
```
<deepLink app:uri="http://www.example.com/users/{id} ">
Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse("http://www.example.com/users/42 ");
```
If you have a <deepLink> element in your destination, you should use the Uri to navigate to it.
```
<deepLink app:uri="
Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse("
```
sr...@google.com <sr...@google.com>
yo...@gmail.com <yo...@gmail.com> #3
This has been fixed internally in https://android-review.googlesource.com/861068 and will be available in Navigation 1.0.0-alpha10. Navigation now uses both the destination ID and the arguments to build a unique requestCode for the PendingIntent, ensuring that you can create multiple PendingIntents to the same destination.
xa...@google.com <xa...@google.com> #4
We need to review this plugin and see what it does in general.
The fact that a non final plugin depend on a non final version of our plugin and breaks things is sad but not something we can solve easily on our end. (we need to have other plugin depend on a more stable API artifact rather than specific versions of our plugin.
The fact that a non final plugin depend on a non final version of our plugin and breaks things is sad but not something we can solve easily on our end. (we need to have other plugin depend on a more stable API artifact rather than specific versions of our plugin.
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d276ac5482afaf12a78ea357fffe40b2a7964301
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Oct 22 14:18:06 2018
Set fixed Android Gradle Plugin dependency version for SafeArgs.
Fixing the version makes it so that if the plugin is updated to a beta
or alpha version for frameworks/support we don't ship SafeArgs with
a non-stable dependency that can cause olders Android Studio versions
to reject syncing.
Bug: 113167627
Test: SafeArgs Tests
Change-Id: Id2de86e4ac724d6d812ea6bd383059737695e948
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/safe-args-gradle-plugin/build.gradle
https://android-review.googlesource.com/798471
https://goto.google.com/android-sha1/d276ac5482afaf12a78ea357fffe40b2a7964301
Branch: androidx-master-dev
commit d276ac5482afaf12a78ea357fffe40b2a7964301
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Oct 22 14:18:06 2018
Set fixed Android Gradle Plugin dependency version for SafeArgs.
Fixing the version makes it so that if the plugin is updated to a beta
or alpha version for frameworks/support we don't ship SafeArgs with
a non-stable dependency that can cause olders Android Studio versions
to reject syncing.
Bug: 113167627
Test: SafeArgs Tests
Change-Id: Id2de86e4ac724d6d812ea6bd383059737695e948
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/safe-args-gradle-plugin/build.gradle
Description
Android Gradle Plugin: 3.3.0-alpha07
Gradle: 4.9
Load the arch components Gihub browser sample app
Actual:
With stable AGP versions (e.g. 3.1.2 or 3.1.4), it fails to sync and forces you to use AGP 3.3a7 .
Expected:
preview AS builds should sync with any AGP stable version from at least the last 12 months.